Rate-limit bootstrap and device signature auth#78015
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close as superseded: this branch overlaps the already-open per-surface gateway auth fixes for bootstrap-token and device-signature rate limiting, while the umbrella issue should stay with those canonical PRs and its remaining alerting work. So I’m closing this here and keeping the remaining discussion on the canonical linked item. Review detailsBest possible solution: Continue review on #77527 and #77492 as the canonical narrow fixes, then keep the umbrella issue open for any remaining failed-auth alerting policy. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection on current main shows bootstrap-token and device-signature verification happening before the new limiter scopes, and the canonical linked PRs include concrete PoC-style reproduction details. Is this the best way to solve the issue? No. This branch is a plausible partial fix, but the narrower canonical PRs already track the same surfaces with more complete proof and should be the review targets. Security review: Security review cleared: The diff is security-sensitive but narrow and does not introduce a concrete supply-chain, secrets, workflow, dependency, or privilege regression. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 7dc6007aeea2. |
Summary
bootstrap-tokenanddevice-signatureFixes #77980.
Verification