Fix bundled capability contract propagation#78012
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close as duplicate/superseded: the same manifest-contract propagation work is now actively tracked by #81312, which includes real behavior proof and current review feedback, while this PR lacks after-fix proof and current main remains unfixed. So I’m closing this here and keeping the remaining discussion on the canonical linked item. Review detailsBest possible solution: Use #81312 as the canonical fix path, address its deduplication review feedback, and let the merged PR close the linked openclaw-lark bug. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main creates bundled capability records without contracts and then validates captured tools against Is this the best way to solve the issue? No for merging this PR now. The code direction is narrow, but the newer open PR covers the same fix with real behavior proof and is already the better canonical path for the remaining work. Security review: Security review cleared: The diff only propagates existing in-memory manifest metadata and adds local temp-dir tests; it does not touch dependencies, workflows, secrets, packaging, or external code execution sources. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 49e288823cda. |
Summary
contractsinto bundled capability plugin recordsFixes #77982.
Verification
src/plugins/bundled-capability-runtime.test.ts.