fix(agents): rebuild sandbox skill prompts from sandbox workspace#77661
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: no. live high-confidence reproduction was established in this read-only review. Source inspection gives a clear current-main path: non-rw sandbox runs use the sandbox workspace while snapshot prompt/env data can still come from host-path skill snapshots. Real behavior proof Next step before merge Security Review detailsBest possible solution: Land this PR after maintainer review, green CI/Testbox, and real sandbox output showing Do we have a high-confidence way to reproduce the issue? No live high-confidence reproduction was established in this read-only review. Source inspection gives a clear current-main path: non-rw sandbox runs use the sandbox workspace while snapshot prompt/env data can still come from host-path skill snapshots. Is this the best way to solve the issue? Yes, the code direction appears to be the narrowest maintainable fix: bypass saved snapshots only for sandboxed non-rw runs and keep existing snapshot behavior elsewhere. Merge should still wait for real behavior proof and normal validation. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 70f34bf1779c. |
3d4f1a3 to
9db6f4f
Compare
|
@clawsweeper automerge |
|
🦞🧹
Draft PRs stay fix-only until GitHub marks them ready for review. Pause with Automerge progress:
|
|
🦞✅ Source: I added |
Signed-off-by: sallyom <[email protected]>
9db6f4f to
2c7c63c
Compare
…7661) Signed-off-by: sallyom <[email protected]>
…7661) Signed-off-by: sallyom <[email protected]>
…7661) Signed-off-by: sallyom <[email protected]>
…7661) Signed-off-by: sallyom <[email protected]>
Summary:
Fixes #50590
Fixes #43383
Tests: