fix(media): allow aws-sdk auth for image runtime#77479
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. source-level. Current main resolves Bedrock Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Keep the focused image carve-out, replace the runner sentinel with a real credentialless execution path or explicit auth-mode contract, then require live Bedrock Do we have a high-confidence way to reproduce the issue? Yes, source-level. Current main resolves Bedrock Is this the best way to solve the issue? No, not as submitted. The image change follows the existing text-runtime carve-out, but the runner change is not the narrowest maintainable fix because it sends a fake credential through the real media provider execution path. Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 04442f4c059f. |
65e3431 to
0477474
Compare
0477474 to
864c2c7
Compare
|
Added the missing changelog entry and updated the PR body with a Real behavior proof section. Proof run from pnpm openclaw --version
pnpm test src/media-understanding/image.test.ts src/media-understanding/runner.video.test.ts
pnpm exec oxfmt --check --threads=1 src/media-understanding/image.ts src/media-understanding/image.test.ts src/media-understanding/runner.entries.ts src/media-understanding/runner.video.test.ts
git diff --checkResult: OpenClaw built at New head: Caveat: no live Bedrock network generation was run because complete AWS runtime credentials were not available here; the proof covers the real local checkout plus the regression path that was failing before provider execution. |
2f2dd38 to
82f1b67
Compare
|
Closing as duplicate of #72092 (opened 2026-04-26), which addresses the same Bedrock |
Closes #77397\n\nAllows Bedrock image/runtime execution to proceed without a static API key when auth mode is "aws-sdk".\n\nChanges:\n- Allow aws-sdk auth to skip requireApiKey for Bedrock image runtime setup\n- Preserve runtime API key behavior only when a static key exists\n- Pass aws-sdk auth through media runner execution setup without forcing a static key\n- Add regression coverage for image and runner auth paths\n
Real behavior proof
auth: "aws-sdk"no longer fails at OpenClaw's static API-key guard before the AWS SDK credential chain can run.pnpm openclawat head2f2dd3832d361a8210a401d620de15b356125a33; AWS credential values were not printed.pnpm openclaw --version pnpm test src/media-understanding/image.test.ts src/media-understanding/runner.video.test.tsaws-sdkmedia-auth regression path reaches provider execution with the AWS SDK credential-chain sentinel instead of throwing the missing static API-key error.