feat(cron): add agentId filtering to cron list#77188
feat(cron): add agentId filtering to cron list#77188zhanggttry wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Adds optional agentId parameter to cron list action, allowing agents to filter cron jobs by their own agentId. This reduces noise in multi-agent setups where each agent sees all jobs across all agents. Changes: - Protocol schema: add optional agentId to CronListParamsSchema - Service types: add agentId to CronListPageOptions - Service ops: filter by agentId when provided - Gateway handler: pass through agentId param - Agent tool: auto-fill agentId from session context (like cron add) - CLI: add --agent <id> option to 'openclaw cron list' When called from an agent session without explicit agentId, the tool auto-fills it from the calling agent's session context. When called from CLI without --agent, all jobs are shown (backward compatible). Closes openclaw#77118
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection shows current main has no Next step before merge Security Review findings
Review detailsBest possible solution: Land this as a focused cron feature after normalizing the filter value consistently and adding regression tests plus docs/changelog entries. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main has no Is this the best way to solve the issue? No, not yet. The API shape is reasonable, but the maintainable fix should normalize the requested agent ID before filtering and ship with tests, docs, and changelog coverage. Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against fcb396bf6589. |
|
@clawsweeper automerge |
|
ClawSweeper 🐠 reef update Thanks for the work on this. ClawSweeper did not have permission to update this branch directly, so it opened a narrow replacement PR instead. that's a branch access thing, not a knock on the contribution. Replacement PR: #77602 fish notes: model gpt-5.5, reasoning high; reviewed against dab0e0a. |
Summary
Adds optional
agentIdparameter tocron listaction, allowing agents to filter cron jobs by their own agentId. This reduces noise in multi-agent setups where each agent sees all jobs across all agents.Closes #77118
Changes
agentIdtoCronListParamsSchemaagentIdtoCronListPageOptionsagentIdwhen provided inlistPage()agentIdparamagentIdfrom session context (mirrors existing behavior incron add)--agent <id>option toopenclaw cron listBehavior