Skip to content

[codex] TUI: simplify stale response notice#77120

Merged
davemorin merged 1 commit into
openclaw:mainfrom
davemorin:codex/tui-stale-response-copy
May 4, 2026
Merged

[codex] TUI: simplify stale response notice#77120
davemorin merged 1 commit into
openclaw:mainfrom
davemorin:codex/tui-stale-response-copy

Conversation

@davemorin

Copy link
Copy Markdown
Member

Summary

  • Replace the TUI stale-response watchdog notice with plain user-facing copy.
  • Keep the existing watchdog recovery behavior intact, including the silent reconnect/history reload path.
  • Update TUI event-handler coverage to assert the new copy and guard the paths that should not show it.

Why

The previous message exposed implementation details like "streaming watchdog", "backend", "run", and "resync". That made a recoverable stale-response state sound like an internal failure report. The new copy tells users only what matters: the response is taking longer than expected, and they can send another message to continue.

Testing

  • pnpm test src/tui/tui-event-handlers.test.ts

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels May 4, 2026
@clawsweeper

clawsweeper Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

Summary
The PR replaces the TUI streaming-watchdog stale-response notice with plain user-facing copy, updates focused event-handler assertions, and adds a changelog entry.

Reproducibility: not applicable. this is a cleanup PR for user-facing copy, not a bug report. Source inspection confirms current main still emits the old internal watchdog notice on the timeout path.

Next step before merge
Draft and protected-label state require maintainer handling, and the review found no narrow automated repair to queue.

Security
Cleared: The diff only changes TUI notice text, focused tests, and the changelog; it does not touch secrets, dependencies, workflows, package resolution, or code-execution plumbing.

Review details

Best possible solution:

Land a reviewed version of this copy-only TUI change after draft/mergeability is resolved and the focused TUI event-handler test passes.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a cleanup PR for user-facing copy, not a bug report. Source inspection confirms current main still emits the old internal watchdog notice on the timeout path.

Is this the best way to solve the issue?

Yes for the stated goal: replacing the string at the existing watchdog system-notice point while preserving timeout and reconnect behavior is the narrowest maintainable solution. Maintainers should still approve the final wording before landing.

What I checked:

Likely related people:

  • @xantorres: The watchdog feature history credits Xan Torres for adding the TUI streaming watchdog and its user-visible reset notice in commit f44ab20. (role: introduced behavior; confidence: medium; commits: f44ab20d4db5; files: src/tui/tui-event-handlers.ts, src/tui/tui-event-handlers.test.ts, CHANGELOG.md)
  • Ayaan Zaidi: Commit 3525273 is the visible merged fix keeping the TUI watchdog bound to the active run for fix(stability): session skills snapshot, tool-loop guard, TUI watchdog, LM Studio preload backoff #67401, adjacent to the notice path this PR edits. (role: recent watchdog maintainer; confidence: medium; commits: 352527393079; files: src/tui/tui-event-handlers.ts, src/tui/tui-event-handlers.test.ts)
  • @steipete: Recent history shows Peter Steinberger maintaining TUI/session recovery and stalled-session logging, including commit 65f2c2a near this surface. (role: adjacent owner; confidence: medium; commits: 65f2c2a0db7c; files: src/tui/tui-event-handlers.ts, docs/web/tui.md)
  • @vignesh07: The TUI history contains many recent TUI behavior and rendering fixes by Vignesh Natarajan, making them a useful adjacent reviewer for terminal UX copy and behavior. (role: heavy TUI contributor; confidence: low; commits: 68cb4fc8a163, 1cc2263578e9, b4cdffc7a429; files: src/tui)

Remaining risk / open question:

  • No tests were run in this read-only review, so the PR author's focused test claim remains unverified here.
  • The provided GitHub context reports the PR as draft and not mergeable, so landing readiness is not established.

Codex review notes: model gpt-5.5, reasoning high; reviewed against e2f4aa461700.

@davemorin
davemorin force-pushed the codex/tui-stale-response-copy branch from 6d63b89 to dd62232 Compare May 4, 2026 05:49
@davemorin
davemorin marked this pull request as ready for review May 4, 2026 05:50
@davemorin
davemorin merged commit 1df6226 into openclaw:main May 4, 2026
48 checks passed
@davemorin
davemorin deleted the codex/tui-stale-response-copy branch May 4, 2026 05:50
vincentkoc added a commit that referenced this pull request May 4, 2026
#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
lxe pushed a commit to lxe/openclaw that referenced this pull request May 6, 2026
lxe pushed a commit to lxe/openclaw that referenced this pull request May 6, 2026
openclaw#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
openclaw#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
openclaw#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
openclaw#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
openclaw#77120 added user-facing TUI copy that replaces the stale-response
watchdog notice with plain language, but the entry landed without
contributor attribution. Add the merging PR ref and credit the human
contributor @davemorin per CLAUDE.md changelog-attribution rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant