fix(doctor): persist group visible reply default#76513
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection shows current main defaults group/channel delivery to message-tool-only, while the current doctor compatibility chain has no path that persists Next step before merge Security Review findings
Review detailsBest possible solution: Keep the doctor-only compatibility repair, align configured-channel detection with reserved channel metadata keys, then continue maintainer review with exact-head validation. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main defaults group/channel delivery to message-tool-only, while the current doctor compatibility chain has no path that persists Is this the best way to solve the issue? No, not quite. The doctor-only migration is the right maintainable surface, but the configured-channel check should ignore Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against e02377f52281. |
1691249 to
00d9384
Compare
00d9384 to
d171bf1
Compare
|
Landed in 85e4ec1 from source d171bf1. Verification before merge:
|
Summary
messages.groupChat.visibleReplies: "message_tool"for configs with configured channels and no explicit visible-reply policy.messages.visibleRepliesandmessages.groupChat.visibleRepliessettings, and leave configs without channels untouched.Why
Upgrades from 2026.4.26 can have configured channel/group chat setups that predate
messages.groupChat.visibleReplies. Persisting the new default through doctor keeps the intended tool-only group/channel reply policy visible in config without adding a startup/load-time core migration.Verification
pnpm test src/commands/doctor-legacy-config.migrations.test.ts src/config/defaults.test.ts src/commands/setup.test.tspnpm config:docs:checkpnpm check:changedgit diff --check