Skip to content

fix(memory): load configured memory slot for runtime checks#76495

Closed
jonathangu wants to merge 2 commits into
openclaw:release/2026.5.2from
jonathangu:fix/ocb-memory-runtime-slot-loading
Closed

fix(memory): load configured memory slot for runtime checks#76495
jonathangu wants to merge 2 commits into
openclaw:release/2026.5.2from
jonathangu:fix/ocb-memory-runtime-slot-loading

Conversation

@jonathangu

Copy link
Copy Markdown

Summary\n- load the configured plugins.slots.memory plugin when memory runtime checks run before the full runtime registry is active\n- keep status/doctor/memory-search paths from reporting no active memory plugin when a memory plugin is installed in the configured slot\n- add regression coverage for slot-scoped loading\n\n## Test\n- pnpm test src/plugins/memory-runtime.test.ts\n

@clawsweeper

clawsweeper Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for the context here. I did a careful shell check against current main, and this is already implemented.

Current main already contains and ships the same narrow memory-runtime fix via the merged canonical implementation, so this PR no longer carries a unique change to land.

Root-cause cluster
Relationship: superseded
Canonical: #76393
Summary: The same configured-memory-slot doctor/status runtime-check problem was fixed by the merged and shipped PR at #76393.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

So I’m closing this as already implemented rather than keeping a duplicate issue open.

Review details

Best possible solution:

Close this branch and keep the shipped implementation from #76393; broader memory-role architecture work remains separate in #88504.

Do we have a high-confidence way to reproduce the issue?

Yes for the historical bug: before the merged fix, the helper only probed an already-loaded registry and could leave getMemoryRuntime() empty in standalone doctor/status paths. Current main no longer reproduces that source path because it loads the configured memory-slot plugin on a cold registry.

Is this the best way to solve the issue?

Yes. The shipped solution is the narrow plugin-runtime boundary fix: load only the configured memory slot through the standalone registry loader instead of broad plugin activation or a new config workaround.

Security review:

Security review cleared: The diff touches memory runtime loading, tests, and changelog only; it does not change dependencies, workflows, secrets, package metadata, or other supply-chain surfaces.

AGENTS.md: found and applied where relevant.

What I checked:

Likely related people:

  • neeravmakwana: Authored the merged canonical fix in fix(cli): load memory plugin for doctor/status when registry is cold #76393, which changed the same memory runtime files and is now present in release source. (role: introduced shipped fix; confidence: high; commits: 5de8ffe7bf17, b6cbd9225c91; files: src/plugins/memory-runtime.ts, src/plugins/memory-runtime.test.ts, CHANGELOG.md)
  • Vincent Koc: Current main and the latest release tag carrying this implementation are authored by Vincent in the available checkout history, making him a likely recent routing candidate for the plugin-runtime surface. (role: recent area contributor; confidence: medium; commits: c645ec4555c0, ad304e790d0c; files: src/plugins/memory-runtime.ts, src/plugins/memory-runtime.test.ts, CHANGELOG.md)

Codex review notes: model internal, reasoning high; reviewed against ad304e790d0c; fix evidence: release v2026.6.9, commit b6cbd9225c91.

@spartman

spartman commented May 3, 2026

Copy link
Copy Markdown

Hitting this in the field — openclaw doctor warns about missing memory plugin even though it's configured and works at runtime (lazy-loaded via onStartup: false). Would love to see this merged. 👍

@openclaw-barnacle

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle Bot added stale Marked as stale due to inactivity triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. labels May 18, 2026
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. P2 Normal backlog priority with limited blast radius. labels May 18, 2026
@openclaw-barnacle openclaw-barnacle Bot removed the stale Marked as stale due to inactivity label May 19, 2026
@RomneyDa

Copy link
Copy Markdown
Member

Heads up: this PR needs to be updated against current main before the new required Dependency Guard check can pass.

@clawsweeper clawsweeper Bot added the status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. label Jun 14, 2026
@clawsweeper clawsweeper Bot added rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jun 21, 2026
@openclaw-barnacle openclaw-barnacle Bot added the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 21, 2026
@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jun 21, 2026
@xuwei-xy

Copy link
Copy Markdown

I think the fix would involve adjusting config. Would that work for your use case?

@clawsweeper clawsweeper Bot added rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jun 21, 2026
@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. and removed status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Jun 21, 2026
@openclaw-barnacle

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Jul 7, 2026
@steipete

steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Thanks @jonathangu for the contribution.

Closing as superseded by merged #76393, commit b6cbd9225c91. The merged PR carries the same three-file implementation and regression-test surface for loading the configured memory plugin during doctor/status checks when the registry is cold.

That fix is already on main, so this branch no longer contains unique work to land.

@steipete steipete closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: S stale Marked as stale due to inactivity status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants