fix(memory): load configured memory slot for runtime checks#76495
fix(memory): load configured memory slot for runtime checks#76495jonathangu wants to merge 2 commits into
Conversation
|
Thanks for the context here. I did a careful shell check against current Current main already contains and ships the same narrow memory-runtime fix via the merged canonical implementation, so this PR no longer carries a unique change to land. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. So I’m closing this as already implemented rather than keeping a duplicate issue open. Review detailsBest possible solution: Close this branch and keep the shipped implementation from #76393; broader memory-role architecture work remains separate in #88504. Do we have a high-confidence way to reproduce the issue? Yes for the historical bug: before the merged fix, the helper only probed an already-loaded registry and could leave Is this the best way to solve the issue? Yes. The shipped solution is the narrow plugin-runtime boundary fix: load only the configured memory slot through the standalone registry loader instead of broad plugin activation or a new config workaround. Security review: Security review cleared: The diff touches memory runtime loading, tests, and changelog only; it does not change dependencies, workflows, secrets, package metadata, or other supply-chain surfaces. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against ad304e790d0c; fix evidence: release v2026.6.9, commit b6cbd9225c91. |
|
Hitting this in the field — |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Heads up: this PR needs to be updated against current |
|
I think the fix would involve adjusting config. Would that work for your use case? |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Thanks @jonathangu for the contribution. Closing as superseded by merged #76393, commit That fix is already on |
Summary\n- load the configured plugins.slots.memory plugin when memory runtime checks run before the full runtime registry is active\n- keep status/doctor/memory-search paths from reporting no active memory plugin when a memory plugin is installed in the configured slot\n- add regression coverage for slot-scoped loading\n\n## Test\n- pnpm test src/plugins/memory-runtime.test.ts\n