fix(cron): retry recurring wake-now jobs on temporary busy skips#76083
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Current main has a high-confidence source-level reproduction: run a recurring main-session Next step before merge Security Review findings
Review detailsBest possible solution: Land the narrow cron timer fix after adding changelog credit and letting exact-head CI complete, while leaving broader recurring retry policy work to the existing separate retry issues. Do we have a high-confidence way to reproduce the issue? Yes. Current main has a high-confidence source-level reproduction: run a recurring main-session Is this the best way to solve the issue? Yes for the runtime behavior. The PR uses the narrow maintainable boundary: retry temporary Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 61fc62ade70a. |
7f40c72 to
1c9ff48
Compare
obviyus
left a comment
There was a problem hiding this comment.
Verified the recurring wake-now main-session cron bug path: temporary heartbeat busy skips now retry through the existing bounded loop instead of recording an ok ghost run after one deferred wake.
Maintainer follow-up: added the required changelog attribution/PR reference and trimmed the cron-in-progress comment to the actual invariant.
Local gate: tests skipped by maintainer request; ran targeted oxfmt on the touched changelog and cron timer files.
Summary
Fixes #75964
Test plan