fix: wire agents.defaults.imageModel into media understanding#7607
Closed
PavDev3 wants to merge 4 commits intoopenclaw:mainfrom
Closed
fix: wire agents.defaults.imageModel into media understanding#7607PavDev3 wants to merge 4 commits intoopenclaw:mainfrom
PavDev3 wants to merge 4 commits intoopenclaw:mainfrom
Conversation
…scovery resolveAutoEntries only checked a hardcoded list of providers (openai, anthropic, google, minimax) when looking for an image model. agents.defaults.imageModel was never consulted by the media understanding pipeline — it was only wired into the explicit `image` tool. Add resolveImageModelFromAgentDefaults that reads the imageModel config (primary + fallbacks) and inserts it into the auto-discovery chain before the hardcoded provider list. runProviderEntry already falls back to describeImageWithModel (via pi-ai) for providers not in the media understanding registry, so no additional provider registration is needed. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Co-Authored-By: Warp <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
thewilloftheshadow
force-pushed
the
main
branch
from
bfc1ccb to
f92900f
Compare
Contributor
|
Backported to Closing as integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7564
This PR wires the agents.defaults.imageModel setting into media understanding auto-discovery.
Co-Authored-By: Warp [email protected]
Greptile Overview
Greptile Summary
This PR wires
agents.defaults.imageModelinto the media-understanding auto-discovery path by adding a resolver insrc/media-understanding/runner.tsthat parsesprimary/fallbacks(or a string) into provider/model entries and prefers those for theimagecapability before falling back to the existing Gemini CLI discovery.It also adds a committed Claude permissions config (
.claude/settings.local.json) and introducespackage-lock.json(npm lockfile) to pin dependency versions.Confidence Score: 3/5
(2/5) Greptile learns from your feedback when you react with thumbs up/down!