Skip to content

fix(whatsapp): remove exposeErrorText config#74642

Merged
mcaxtr merged 2 commits into
mainfrom
fix/remove-whatsapp-expose-error-text
Apr 29, 2026
Merged

fix(whatsapp): remove exposeErrorText config#74642
mcaxtr merged 2 commits into
mainfrom
fix/remove-whatsapp-expose-error-text

Conversation

@mcaxtr

@mcaxtr mcaxtr commented Apr 29, 2026

Copy link
Copy Markdown
Member

Summary

  • remove channels.whatsapp.exposeErrorText
  • suppress WhatsApp error payloads
  • update the related docs, schema, generated metadata, and targeted tests

Testing

  • pnpm config:docs:gen
  • pnpm config:channels:gen
  • pnpm test extensions/whatsapp/src/outbound-adapter.sendpayload.test.ts extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.test.ts extensions/whatsapp/src/config-schema.test.ts src/config/zod-schema.providers-whatsapp.test.ts
  • pnpm exec oxfmt --check --threads=1 CHANGELOG.md docs/channels/whatsapp.md docs/.generated/config-baseline.sha256 extensions/whatsapp/src/accounts.ts extensions/whatsapp/src/auto-reply/monitor.ts extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.test.ts extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.ts extensions/whatsapp/src/config-schema.test.ts extensions/whatsapp/src/config-ui-hints.ts extensions/whatsapp/src/outbound-adapter.sendpayload.test.ts extensions/whatsapp/src/outbound-base.ts src/config/bundled-channel-config-metadata.generated.ts src/config/types.whatsapp.ts src/config/zod-schema.providers-whatsapp.test.ts src/config/zod-schema.providers-whatsapp.ts

Notes

  • skipped Blacksmith/Testbox changed-gate for now per request

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: whatsapp-web Channel integration: whatsapp-web size: S maintainer Maintainer-authored PR labels Apr 29, 2026
@mcaxtr
mcaxtr force-pushed the fix/remove-whatsapp-expose-error-text branch from fb86cef to 11f9b42 Compare April 29, 2026 22:33
@clawsweeper

clawsweeper Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes:

The PR removes the WhatsApp exposeErrorText channel/account config surface, changes WhatsApp routed and inbound error payload handling to always suppress visible error text, marks WhatsApp monitor connection events as trusted, and updates related docs, tests, generated config metadata, and changelog text.

Maintainer follow-up before merge:

This is an active maintainer-labeled MEMBER PR; the remaining action is maintainer review plus changed-gate validation, not an automated replacement or repair branch.

Security review:

Security review cleared: The diff touches WhatsApp runtime/config/docs/tests/generated metadata only and does not add dependency, workflow, install, release, secret-handling, or third-party code execution changes.

Review details

Best possible solution:

Treat this as a normal maintainer-owned WhatsApp cleanup PR: if maintainers agree the main-only config should be retired before shipping, land it after changed-gate proof; otherwise keep or revise the config/docs behavior before release.

Acceptance criteria:

  • pnpm config:docs:gen
  • pnpm config:channels:gen
  • pnpm test extensions/whatsapp/src/outbound-adapter.sendpayload.test.ts extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.test.ts extensions/whatsapp/src/config-schema.test.ts src/config/zod-schema.providers-whatsapp.test.ts
  • pnpm check:changed in Testbox before merge

What I checked:

  • Protected maintainer scope: The provided GitHub context shows authorAssociation=MEMBER and labels include the protected maintainer label, so the item is not eligible for automatic close by this sweep even if the patch looks reasonable.
  • Current main still exposes the config schema: Current main still accepts exposeErrorText in the WhatsApp Zod schema, so the PR's intended removal is not already implemented on main. (src/config/zod-schema.providers-whatsapp.ts:86, 6acd588bddd9)
  • Current main still uses the config at runtime: WhatsApp outbound payload delivery currently suppresses error text only when the merged WhatsApp account config has exposeErrorText === false; the inbound buffered reply path similarly resolves and passes this flag. (extensions/whatsapp/src/outbound-base.ts:223, 6acd588bddd9)
  • Current docs still publish the key: The WhatsApp channel docs on current main still document channels.whatsapp.exposeErrorText and per-account overrides, matching the config surface the PR removes. Public docs: docs/channels/whatsapp.md. (docs/channels/whatsapp.md:403, 6acd588bddd9)
  • Provided PR diff is internally consistent: The provided pullFiles patch removes the field from runtime account resolution, schema/types, docs, UI hints, generated metadata, and tests, while changing both WhatsApp-visible error delivery paths to suppress isError payloads unconditionally. (extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.ts:97, 9a43c0f98960)
  • Latest shipped release does not contain the key: The latest release tag did not contain exposeErrorText in the WhatsApp schema/docs/changelog, and git merge-base --is-ancestor ec753607 v2026.4.27 returned 1, so this appears to be a main-only config cleanup rather than a shipped public-key removal. (src/config/zod-schema.providers-whatsapp.ts:86, cbc2ba093146)

Likely related people:

  • @steipete: Available local blame and log for the affected WhatsApp runtime/config/docs surfaces point current-main lines to recent maintainer commit ec7536078f2919b860c559c57076458f513cb0b4. (role: recent maintainer; confidence: medium; commits: ec7536078f29; files: extensions/whatsapp/src/outbound-base.ts, extensions/whatsapp/src/auto-reply/monitor/inbound-dispatch.ts, src/config/zod-schema.providers-whatsapp.ts)
  • @rubencu: The current changelog credits @rubencu on fix(whatsapp): sanitize tool XML and hide configured error text #71830 for the WhatsApp visible-error-text config behavior that this PR now removes before release. (role: related feature contributor; confidence: low; files: CHANGELOG.md, docs/channels/whatsapp.md, extensions/whatsapp/src/outbound-base.ts)

Remaining risk / open question:

  • The PR body says the Blacksmith/Testbox changed gate was skipped, so broad changed-lane validation remains unproven before merge.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 6acd588bddd9.

@mcaxtr
mcaxtr merged commit 4cba08d into main Apr 29, 2026
77 checks passed
@mcaxtr
mcaxtr deleted the fix/remove-whatsapp-expose-error-text branch April 29, 2026 23:04
lxe pushed a commit to lxe/openclaw that referenced this pull request May 6, 2026
* fix(whatsapp): remove exposeErrorText config

* fix(whatsapp): mark internal system events trusted
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
* fix(whatsapp): remove exposeErrorText config

* fix(whatsapp): mark internal system events trusted
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
* fix(whatsapp): remove exposeErrorText config

* fix(whatsapp): mark internal system events trusted
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
* fix(whatsapp): remove exposeErrorText config

* fix(whatsapp): mark internal system events trusted
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
* fix(whatsapp): remove exposeErrorText config

* fix(whatsapp): mark internal system events trusted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: whatsapp-web Channel integration: whatsapp-web docs Improvements or additions to documentation maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant