fix(active-memory): preserve setup grace for embedded recall#74480
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. Source inspection on current main shows the raw inner timeout handoff while the outer hook and watchdog use Next step before merge Security Review detailsBest possible solution: Land this PR after ordinary maintainer merge handling so Active Memory uses one setup-grace-aware timeout budget across the hook, watchdog, and embedded runner. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection on current main shows the raw inner timeout handoff while the outer hook and watchdog use Is this the best way to solve the issue? Yes. Passing the resolved What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 54a81e00807b. |
Co-authored-by: volcano303 <[email protected]>
b2e884b to
5305f9c
Compare
|
Rewrote this PR on current What changed:
Local proof:
|
Summary
timeoutMs + setupGraceTimeoutMs, butrunEmbeddedPiAgentstill received rawtimeoutMsand could self-timeout first.Scope
This is intentionally narrow. It does not change memory search behavior, provider routing, circuit breaker behavior, model selection, or timeout clamps.
Verification
pnpm exec oxfmt --check --threads=1 CHANGELOG.md docs/concepts/active-memory.md extensions/active-memory/index.ts extensions/active-memory/index.test.tspnpm test extensions/active-memory/index.test.ts extensions/active-memory/config.test.tspnpm check:docspnpm lint:extensions -- extensions/active-memory/index.ts extensions/active-memory/index.test.tsgit diff --checkNotes
Rewritten on current
mainas a single maintainer patch while preserving contributor credit.Closes #73306.