docs(security): clarify proxy SSRF reporting scope#74338
Conversation
Greptile SummaryThis PR adds documentation to Confidence Score: 5/5Safe to merge — docs-only change with no code impact. Purely documentation. The three added blocks (false-positive bullet, new section, out-of-scope bullet) are internally consistent and match verified codebase identifiers ( No files require special attention. Reviews (1): Last reviewed commit: "docs(security): clarify proxy SSRF repor..." | Re-trigger Greptile |
|
Codex review: needs maintainer review before merge. What this changes: This PR updates SECURITY.md with SSRF triage scope for operator-managed HTTP/WebSocket proxy routing, revises docs/security/network-proxy.md wording around proxy guardrails, and adds a CHANGELOG.md entry for the merged media decode triage-policy change in #74311. Maintainer follow-up before merge: Protected maintainer-labeled security-policy documentation PR needs human maintainer/security review and normal exact-head validation, not an automated replacement or repair PR. Best possible solution: The durable end state should be public SECURITY.md and Network proxy docs that give researchers a precise HTTP/WebSocket proxy-routing triage boundary while leaving non-HTTP egress and unrelated features assessed separately. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a972c9ec4547. |
bcb60c0 to
d4702a3
Compare
d4702a3 to
7dd9fcf
Compare
|
Merged via squash.
Thanks @jesse-merhi! |
Merged via squash. Prepared head SHA: 7dd9fcf Co-authored-by: jesse-merhi <[email protected]> Co-authored-by: jesse-merhi <[email protected]> Reviewed-by: @jesse-merhi
Merged via squash. Prepared head SHA: 7dd9fcf Co-authored-by: jesse-merhi <[email protected]> Co-authored-by: jesse-merhi <[email protected]> Reviewed-by: @jesse-merhi
Merged via squash. Prepared head SHA: 7dd9fcf Co-authored-by: jesse-merhi <[email protected]> Co-authored-by: jesse-merhi <[email protected]> Reviewed-by: @jesse-merhi
Merged via squash. Prepared head SHA: 7dd9fcf Co-authored-by: jesse-merhi <[email protected]> Co-authored-by: jesse-merhi <[email protected]> Reviewed-by: @jesse-merhi
Merged via squash. Prepared head SHA: 7dd9fcf Co-authored-by: jesse-merhi <[email protected]> Co-authored-by: jesse-merhi <[email protected]> Reviewed-by: @jesse-merhi
Summary
fetch, Node HTTP(S), WebSocket clients, and similar process-local HTTP egress without over-scoping non-HTTP features.docs/security/network-proxy.mdto avoid namingfetchWithSsrFGuardas a protection, and added the requested changelog entry for docs: classify media decode overhead as performance-only #74311 / abaa432.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause (if applicable)
N/A
Regression Test Plan (if applicable)
N/A
User-visible / Behavior Changes
Updates SECURITY.md triage policy for SSRF reports about the operator-managed HTTP/WebSocket proxy-routing feature, points readers to the Network proxy docs, and adds the missing #74311 changelog entry.
Diagram (if applicable)
N/A
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation: N/ARepro + Verification
Environment
Steps
docs/security/network-proxy.mdpolicy wording.CHANGELOG.mdentry for docs: classify media decode overhead as performance-only #74311.Expected
fetchWithSsrFGuardas a protection.Actual
Evidence
Validation runs:
Prepare gate note: after rebasing onto the latest
origin/main,scripts/pr-prepare gates 74338reranpnpm buildsuccessfully, thenpnpm checkhit an unrelated baseline lint error insrc/plugins/providers.test.ts(oxc(no-map-spread)). This PR changes onlyCHANGELOG.md,SECURITY.md, anddocs/security/network-proxy.md;git diff --quiet origin/main -- src/plugins/providers.test.tsconfirms the failing file is identical to latestorigin/main.Human Verification (required)
origin/main.Review Conversations
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations