docs: classify media decode overhead as performance-only#74311
Conversation
Greptile SummaryThis docs-only PR adds two new out-of-scope bullets to Confidence Score: 4/5Safe to merge — documentation-only change with no code impact and clear policy intent. Only a P2 style issue exists: the phrase "format-conversion order" in the second new bullet is slightly ambiguous compared to the clearer "other format conversion" in the parallel first bullet. No logic, security, or correctness concerns. No files require special attention; the single changed file is SECURITY.md. Prompt To Fix All With AIThis is a comment left during a code review.
Path: SECURITY.md
Line: 152
Comment:
**Ambiguous phrasing: "format-conversion order"**
The phrase `format-conversion order` is slightly ambiguous — it could be read as "the ordering/sequencing of format-conversion steps" rather than "format-conversion work/overhead." The parallel bullet at line 67 uses the clearer phrasing `other format conversion`, and the policy intent here is about resource overhead, not the sequence of operations.
```suggestion
- Reports whose only claim is resource overhead from decode/encode, base64 expansion, media transcoding, serialization, or other format conversion after input has already passed the applicable configured acceptance limits. We may fix these as performance/security hardening, but they are not GHSA-class vulnerabilities without demonstrated unauthenticated amplification, limit bypass, crash/process termination, persistent exhaustion, data exposure, or another documented boundary bypass.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "docs: classify media decode overhead as ..." | Re-trigger Greptile |
| - Reports whose only claim is that an ACP-exposed tool can indirectly execute commands, mutate host state, or reach another privileged tool/runtime without demonstrating a bypass of ACP prompt/approval, allowlist enforcement, sandboxing, or another documented trust boundary. These are hardening-only findings, not vulnerabilities. | ||
| - Reports whose only claim is that exec approvals do not semantically model every interpreter/runtime loader form, subcommand, flag combination, package script, or transitive module/config import. Exec approvals bind exact request context and best-effort direct local file operands; they are not a complete semantic model of everything a runtime may load. | ||
| - Reports whose only claim is parser reachability in an up-to-date maintained dependency without showing that the exact shipped dependency build is vulnerable. We keep native media dependencies current; dependency exposure alone is not a vulnerability. | ||
| - Reports whose only claim is resource overhead from decode/encode, base64 expansion, media transcoding, serialization, or format-conversion order after input has already passed the applicable configured acceptance limits. We may fix these as performance/security hardening, but they are not GHSA-class vulnerabilities without demonstrated unauthenticated amplification, limit bypass, crash/process termination, persistent exhaustion, data exposure, or another documented boundary bypass. |
There was a problem hiding this comment.
Ambiguous phrasing: "format-conversion order"
The phrase format-conversion order is slightly ambiguous — it could be read as "the ordering/sequencing of format-conversion steps" rather than "format-conversion work/overhead." The parallel bullet at line 67 uses the clearer phrasing other format conversion, and the policy intent here is about resource overhead, not the sequence of operations.
| - Reports whose only claim is resource overhead from decode/encode, base64 expansion, media transcoding, serialization, or format-conversion order after input has already passed the applicable configured acceptance limits. We may fix these as performance/security hardening, but they are not GHSA-class vulnerabilities without demonstrated unauthenticated amplification, limit bypass, crash/process termination, persistent exhaustion, data exposure, or another documented boundary bypass. | |
| - Reports whose only claim is resource overhead from decode/encode, base64 expansion, media transcoding, serialization, or other format conversion after input has already passed the applicable configured acceptance limits. We may fix these as performance/security hardening, but they are not GHSA-class vulnerabilities without demonstrated unauthenticated amplification, limit bypass, crash/process termination, persistent exhaustion, data exposure, or another documented boundary bypass. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: SECURITY.md
Line: 152
Comment:
**Ambiguous phrasing: "format-conversion order"**
The phrase `format-conversion order` is slightly ambiguous — it could be read as "the ordering/sequencing of format-conversion steps" rather than "format-conversion work/overhead." The parallel bullet at line 67 uses the clearer phrasing `other format conversion`, and the policy intent here is about resource overhead, not the sequence of operations.
```suggestion
- Reports whose only claim is resource overhead from decode/encode, base64 expansion, media transcoding, serialization, or other format conversion after input has already passed the applicable configured acceptance limits. We may fix these as performance/security hardening, but they are not GHSA-class vulnerabilities without demonstrated unauthenticated amplification, limit bypass, crash/process termination, persistent exhaustion, data exposure, or another documented boundary bypass.
```
How can I resolve this? If you propose a fix, please make it concise.|
Codex review: needs maintainer review before merge. What this changes: The PR adds two Maintainer follow-up before merge: Keep this PR open for maintainer/secops review. If accepted, resolve the wording consistency issue in Best possible solution: Keep this PR open for maintainer/secops review. If accepted, resolve the wording consistency issue in What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 75286ef83863. |
|
PR reached MERGED while I was running the local landing flow.
Thanks @steipete! |
) * docs: classify media decode overhead as hardening * docs: classify decode overhead as performance --------- Co-authored-by: jesse-merhi <[email protected]>
) * docs: classify media decode overhead as hardening * docs: classify decode overhead as performance --------- Co-authored-by: jesse-merhi <[email protected]>
) * docs: classify media decode overhead as hardening * docs: classify decode overhead as performance --------- Co-authored-by: jesse-merhi <[email protected]>
) * docs: classify media decode overhead as hardening * docs: classify decode overhead as performance --------- Co-authored-by: jesse-merhi <[email protected]>
) * docs: classify media decode overhead as hardening * docs: classify decode overhead as performance --------- Co-authored-by: jesse-merhi <[email protected]>
Summary
Verification