docs(skills): make coding-agent completion parent-owned#74308
docs(skills): make coding-agent completion parent-owned#74308Marvinthebored wants to merge 1 commit into
Conversation
Greptile SummaryThis PR updates Confidence Score: 4/5Documentation-only change; safe to merge with the minor template inconsistency addressed. Only P2 findings — a minor inconsistency in placeholder quoting between the canonical CODING_AGENT_RESULT block template and the embedded Quick Start example. No logic, security, or correctness issues. skills/coding-agent/SKILL.md — template quoting inconsistency in the CODING_AGENT_RESULT block. Prompt To Fix All With AIThis is a comment left during a code review.
Path: skills/coding-agent/SKILL.md
Line: 116-121
Comment:
**Template inconsistency between fenced block and embedded Quick Start**
The canonical template (lines 116–121) uses quoted placeholder values — `"not run: <reason>"` and `"none"` — but the embedded version in the Quick Start bash command (lines 143–148) drops the quotes: `not run: reason` / `none`. Workers that follow one variant will produce output in a different format from workers following the other, which could complicate log parsing with `CODING_AGENT_RESULT_START/END`.
Consider normalizing both locations to the simpler unquoted style used in the Quick Start.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "docs(skills): make coding-agent completi..." | Re-trigger Greptile |
| tests: <commands run and results, or "not run: <reason>"> | ||
| changed_files: | ||
| - <path>: <brief change> | ||
| blockers: | ||
| - <blocker or "none"> | ||
| CODING_AGENT_RESULT_END |
There was a problem hiding this comment.
Template inconsistency between fenced block and embedded Quick Start
The canonical template (lines 116–121) uses quoted placeholder values — "not run: <reason>" and "none" — but the embedded version in the Quick Start bash command (lines 143–148) drops the quotes: not run: reason / none. Workers that follow one variant will produce output in a different format from workers following the other, which could complicate log parsing with CODING_AGENT_RESULT_START/END.
Consider normalizing both locations to the simpler unquoted style used in the Quick Start.
Prompt To Fix With AI
This is a comment left during a code review.
Path: skills/coding-agent/SKILL.md
Line: 116-121
Comment:
**Template inconsistency between fenced block and embedded Quick Start**
The canonical template (lines 116–121) uses quoted placeholder values — `"not run: <reason>"` and `"none"` — but the embedded version in the Quick Start bash command (lines 143–148) drops the quotes: `not run: reason` / `none`. Workers that follow one variant will produce output in a different format from workers following the other, which could complicate log parsing with `CODING_AGENT_RESULT_START/END`.
Consider normalizing both locations to the simpler unquoted style used in the Quick Start.
How can I resolve this? If you propose a fix, please make it concise.|
Codex review: needs maintainer review before merge. What this changes: This PR rewrites Maintainer follow-up before merge: Review this as a focused maintainer docs/product-contract PR: either accept the parent-owned completion model in Best possible solution: Review this as a focused maintainer docs/product-contract PR: either accept the parent-owned completion model in What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against d30ba5351ed1. |
|
Thanks for the skill-docs update. Closing this as low-signal process-doc churn without a maintainer-owned workflow change; please resubmit with a concrete current workflow gap if this still needs to change. |
Summary
Update the
coding-agentskill so background CLI workers report completion through stdout and the parent assistant owns user-facing completion/failure reporting.The previous skill wording required delegated workers to call
openclaw message sendthemselves. That is fragile because workers may run in sandboxed or constrained environments, may not have channel/plugin runtime access, and can complete the coding task successfully while the external notification path hangs or fails.Changes
openclaw message send.background:truepty:true--print --permission-mode bypassPermissionswithout PTYsessionIdprocess log/pollCODING_AGENT_RESULT_START/CODING_AGENT_RESULT_ENDstdout result block template.Why
A CLI coding agent should behave like a background process with structured stdout, not like a messaging client. Parent-owned reporting avoids duplicating channel credentials/routing into worker prompts and prevents completed work from disappearing when worker-side external messaging fails.
Validation
git diff --checkopenclaw message sendreferences are only in “do not require/use” guidance.