fix(whatsapp): recover group inbound after reconnect churn#73732
Conversation
Greptile SummaryThis PR introduces a shared Confidence Score: 5/5Safe to merge — the change is well-scoped, consistent across all call sites, and backed by a targeted regression test. No logic bugs found. The shared cache is threaded correctly through monitorWebInbox, attachWebInboxToSocket, WhatsAppConnectionController, and auto-reply/monitor.ts. The stale-fallback TTL behaviour is consistent with the existing cache design. No security or data-integrity concerns were identified. No files require special attention. Reviews (1): Last reviewed commit: "fix(whatsapp): recover group inbound aft..." | Re-trigger Greptile |
|
Codex review: needs maintainer review before merge. Keep open. This is a maintainer-owned PR with the protected Maintainer follow-up before merge: Keep this PR open for explicit maintainer review. If the bounded-cache and stale-data tradeoff is acceptable and CI/Testbox proof remains current, land the WhatsApp plugin recovery patch with its focused regression coverage, then close the canonical WhatsApp group inbound issue after merge. Best possible solution: Keep this PR open for explicit maintainer review. If the bounded-cache and stale-data tradeoff is acceptable and CI/Testbox proof remains current, land the WhatsApp plugin recovery patch with its focused regression coverage, then close the canonical WhatsApp group inbound issue after merge. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 1c45592e620e. |
288c98d to
dc14579
Compare
dc14579 to
dabe0e7
Compare
dabe0e7 to
2b40dc3
Compare
|
Maintainer follow-up:
Testbox proof (
|
|
Maintainer follow-up after Aisle refresh:
Fresh Testbox proof on replacement box
Earlier box |
Summary
Context
Canonical issue: #66920. Related evidence: #7433, #63855, #70856.
This does not replace the separate QR-pairing report #46518, the QR retry PR #47710, the timeout-config PR #63939, or the broader gateway wedge report #67986.
Validation
Credit
Thanks to legonhilltech-jpg, octopuslabs-fl, Kanorin-chan, and stuswan for the reports and reproduction details.
ProjectClownfish replacement details: