Description

In dispatchAgentHook, the async hook runner catches errors, but then calls resolveMainSessionKeyFromConfig() inside the catch block as a fallback when hookEventSessionKey is undefined.

• resolveMainSessionKeyFromConfig() calls getRuntimeConfig().
• If the original failure was due to getRuntimeConfig() throwing (e.g., invalid/missing config/env), the fallback call will throw again.
• That second throw occurs inside the catch block and is not wrapped, which can result in an unhandled promise rejection in the void (async () => { ... })() fire-and-forget task.
• Depending on Node.js runtime settings (unhandledRejection handling), this can crash the gateway process, creating a denial-of-service condition triggered by a hook request during config-load failure.

Vulnerable code:

} catch (err) {
  logHooks.warn(`hook agent failed: ${String(err)}`);
  enqueueSystemEvent(`Hook ${safeName} (error): ${String(err)}` , {
    sessionKey: hookEventSessionKey ?? resolveMainSessionKeyFromConfig(),
    trusted: false,
  });
}

Recommendation

Avoid calling getRuntimeConfig() (directly or indirectly) from within the error handler. Compute a safe fallback session key without re-loading config, and/or wrap the fallback in its own try/catch.

Example fix:

const fallbackSessionKey = "global"; // or a safe constant / already-known session key

let hookEventSessionKey: string | undefined;
void (async () => {
  try {
    const cfg = getRuntimeConfig();
    hookEventSessionKey = resolveHookEventSessionKey({ cfg, agentId: value.agentId });
    ​// ...
  } catch (err) {
    const sessionKeyForError = hookEventSessionKey ?? fallbackSessionKey;
    enqueueSystemEvent(`Hook ${safeName} (error): ${String(err)}`, {
      sessionKey: sessionKeyForError,
      trusted: false,
    });
  }
})();

If you need the real main session key, resolve it once in a safe place where errors can be propagated/handled (e.g., before spawning the async task), and store it in a variable.