Greptile Summary

This PR changes sessions_spawn to silently ignore streamTo and resumeSessionId when runtime=\"subagent\" (or when runtime is omitted and defaults to subagent), rather than returning an error. ACP passthrough semantics are fully preserved, and the streamTo schema description was updated to reflect the ACP-only nature of the field. The test suite is updated accordingly with focused regression coverage.

Confidence Score: 4/5

Safe to merge; the logic change is intentional, well-tested, and limited to dropping ACP-only fields before a subagent dispatch.

Only P2 findings present. The implementation correctly strips the ACP-only fields in the subagent path and the tests verify both the stripping and the ACP passthrough. The one gap is a stale schema description for resumeSessionId that was not updated in parallel with streamTo.

src/agents/tools/sessions-spawn-tool.ts — resumeSessionId description update

This is a comment left during a code review.
Path: src/agents/tools/sessions-spawn-tool.ts
Line: 154-158

Comment:
**Stale `resumeSessionId` description still says "Requires runtime='acp'"**

The description for `resumeSessionId` still says `Requires runtime="acp"` but enforcement was removed in this PR — the field is now silently ignored for subagent runtime. `streamTo` was updated to say `"ACP-only stream target"` but `resumeSessionId` was not updated to match. An LLM following the schema description will infer an error will occur if it passes this field without `runtime="acp"`, which is now incorrect and may cause unnecessary call-site gymnastics.

```suggestion
          resumeSessionId: Type.Optional(
            Type.String({
              description:
                'ACP-only: resume an existing agent session by its ID (e.g. a Codex session UUID from ~/.codex/sessions/). Only meaningful for runtime="acp"; silently ignored for runtime="subagent". The agent replays conversation history via session/load instead of starting fresh.',
            }),
          ),
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(sessions_spawn): tolerate ACP-only f..." | Re-trigger Greptile}

ProjectClownfish pushed a narrow repair to this branch so the original contributor path can stay canonical.

Source PR: #72614
Validation: pnpm -s vitest run src/agents/tools/sessions-spawn-tool.test.ts; pnpm check:changed
Contributor credit is preserved in the branch history and PR context.

ProjectClownfish pushed a narrow repair to this branch so the original contributor path can stay canonical.

Source PR: #72614
Validation: pnpm -s vitest run src/agents/tools/sessions-spawn-tool.test.ts; pnpm check:changed
Contributor credit is preserved in the branch history and PR context.

🔒 Aisle Security Analysis

We found 1 potential security issue(s) in this PR:

function redactSessionsSpawnAcpArgs(value: unknown): unknown {
  if (!value || typeof value !== "object") {
    return value; // JSON-string arguments are not redacted
  }
  ...
}

function redactSessionsSpawnArgs(value: unknown): unknown {
  ​// First handle object payloads
  const direct = redactSessionsSpawnAcpArgs(redactSessionsSpawnAttachmentsArgs(value));
  if (direct !== value) return direct;

  ​// Then handle JSON-string payloads (OpenAI functionCall style)
  if (typeof value === "string") {
    try {
      const parsed = JSON.parse(value) as unknown;
      const redacted = redactSessionsSpawnAcpArgs(redactSessionsSpawnAttachmentsArgs(parsed));
      return redacted === parsed ? value : JSON.stringify(redacted);
    } catch {
      return value;
    }
  }

  return value;
}

Analyzed PR: #72614 at commit a4b865b

_{Last updated on: 2026-04-27T16:36:13Z}

ProjectClownfish follow-up: the Greptile note is addressed in the current head. resumeSessionId now describes the field as ACP-only and explicitly says it is ignored for runtime="subagent".

ProjectClownfish follow-up: addressed the Aisle transcript finding in the current head. sessions_spawn now redacts ACP-only resumeSessionId and streamTo fields in both persisted arguments and input payloads, with regression coverage for both shapes.

ProjectClownfish follow-up: addressed the latest Aisle edge case too. ACP-only sessions_spawn routing keys are now redacted by key presence, not by string type, so object/array/number payloads cannot persist through transcript repair. Remote Blacksmith validation: pnpm test:serial src/agents/session-transcript-repair.attachments.test.ts src/agents/session-transcript-repair.test.ts passed (38 tests).

ProjectClownfish follow-up: addressed the Aisle IDOR finding in the current head. runtime="acp" resumeSessionId now passes only when it matches an ACP identity already recorded in OpenClaw session state and owned by the requester session; otherwise it returns resume_forbidden before sessions.patch or ACP runtime initialization. Remote Blacksmith validation passed: pnpm test:serial src/agents/acp-spawn.test.ts src/agents/tools/sessions-spawn-tool.test.ts src/agents/session-transcript-repair.attachments.test.ts src/agents/session-transcript-repair.test.ts (115 tests).