Support SecretRef for voice-call credentials and bundled plugin SecretInputs#72607
Merged
Conversation
openclaw-barnacle
Bot
added
docs
Contributor
Greptile SummaryThis PR adds The implementation is well-structured and test coverage is thorough across the new hydration paths in Confidence Score: 5/5Safe to merge — no bugs found; logic is correct and tests cover the new hydration paths end-to-end. All changed code paths are well-tested (unit tests for the new contract hydration scenarios, an integration-style bundled test, and a target-registry test). The spread-order in the hydration merge is intentional and defensively explicit. No P0/P1 findings. No files require special attention. Reviews (1): Last reviewed commit: "fix: support voice-call secretrefs" | Re-trigger Greptile |
joshavant
force-pushed
the
feature/voice-call-secretref-credentials
branch
from
April 27, 2026 05:37
f712e5a to
f62b6a5
Compare
vincentkoc
added a commit
that referenced
this pull request
Apr 27, 2026
….providers.*.apiKey Trace to db09f68 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs #72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
….providers.*.apiKey Trace to ea2ebc6 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
….providers.*.apiKey Trace to 59f8186 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
globalcaos
pushed a commit
to globalcaos/tinkerclaw
that referenced
this pull request
May 13, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
globalcaos
pushed a commit
to globalcaos/tinkerclaw
that referenced
this pull request
May 13, 2026
….providers.*.apiKey Trace to f1e6555 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
….providers.*.apiKey Trace to c954977 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
….providers.*.apiKey Trace to 0414770 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
…tInputs (openclaw#72607) * fix: support voice-call secretrefs * test: classify plugin secretref targets * docs: credit voice-call secretref change * fix: keep plugin secret target discovery lightweight
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
….providers.*.apiKey Trace to 76fedb9 (Support SecretRef for voice-call credentials and bundled plugin SecretInputs openclaw#72607). The reference page docs/reference/secretref-credential-surface.md listed the new entries in the same SHA, but docs/plugins/voice-call.md showed only plain-string credentials without pointing to the SecretRef surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope note
This intentionally keeps the broader implementation: bundled plugins that declare
configContracts.secretInputsare now discovered from their manifests instead of requiring hardcoded registry entries. That includes the existing ACPXplugins.entries.acpx.config.mcpServers.*.env.*surface.Validation
pnpm check:changedpnpm test src/config/config.plugin-validation.test.ts -- --reporter=verboseRelated #68690