fix(sessions_spawn): tolerate ACP-only fields for subagent runtime#72331
Merged
Conversation
This was referenced Apr 26, 2026
openclaw-barnacle
Bot
added
docs
Contributor
Greptile SummaryThis PR changes the
Confidence Score: 4/5Safe to merge; the only finding is a non-blocking observability gap in the silent-drop path. All findings are P2. The implementation correctly strips ACP-only fields from the subagent path and preserves ACP passthrough. Tests cover the new tolerant behaviour and the schema description assertion. src/agents/tools/sessions-spawn-tool.ts — consider adding a warning when ACP-only fields are dropped for non-ACP runtime. Prompt To Fix All With AIThis is a comment left during a code review.
Path: src/agents/tools/sessions-spawn-tool.ts
Line: 267
Comment:
**No diagnostic when ACP-only fields are silently dropped**
When a caller supplies `resumeSessionId` or `streamTo` but `runtime` defaults to `"subagent"`, both fields are now silently discarded rather than producing an error. A caller that intends to resume an existing session (`resumeSessionId: "<uuid>"`) will instead get a fresh spawn with no indication that the resume request was ignored. Adding at least a `console.warn` (or including a `warnings` key in the result payload) when either field is present but runtime is not `"acp"` would help operators diagnose misconfiguration without reintroducing the blocking error behaviour.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(sessions_spawn): tolerate ACP-only f..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
vincentkoc
force-pushed
the
clownfish/ghcrawl-165995-agentic-merge
branch
2 times, most recently
from
April 26, 2026 20:34
7266af9 to
8ea9ed9
Compare
This was referenced Apr 26, 2026
sessions_spawn rejects subagent runtime when streamTo is auto-filled by strict-mode providers
#64714
Closed
vincentkoc
force-pushed
the
clownfish/ghcrawl-165995-agentic-merge
branch
from
April 27, 2026 06:07
8ea9ed9 to
9b65803
Compare
This was referenced Apr 27, 2026
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
globalcaos
pushed a commit
to globalcaos/tinkerclaw
that referenced
this pull request
May 13, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamToandresumeSessionIdas ACP-only values that are consumed only onruntime="acp".runtime="subagent", silently ignore those ACP-only fields so strict schema-following providers cannot brick subagent spawns.streamToschema description stating it requiresruntime="acp"and should be omitted for subagent spawns.Credit
This carries forward the focused implementation work from skernelx in #68397 and damselem in #65282, plus the schema-hint work from vvitovec in #69170 and Sanjays2402 in #69203.
Validation
pnpm -s vitest run src/agents/tools/sessions-spawn-tool.test.tspnpm check:changedCloses #43556. Covers #56326, #61724, #63120, #64714, and #67248 after the fix lands.
ProjectClownfish replacement details: