1. extensions/memory-core/src/dreaming-narrative.ts, line 671-692 (link)

   Variable shadowing for endIdx / startIdx

   The new outer const endIdx (from ensured.indexOf(...)) and, in the else if branch, the pre-existing inner const startIdx and const endIdx shadow each other inside the same closure. No runtime bug occurs because the early-return exits before the shadowing declarations are reached, but TypeScript's no-shadow lint rule (if enabled) will flag these. Consider renaming the outer variables to ensuredStartIdx / ensuredEndIdx to make the intent explicit and remove the shadow.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: extensions/memory-core/src/dreaming-narrative.ts
   Line: 671-692
   
   Comment:
   **Variable shadowing for `endIdx` / `startIdx`**
   
   The new outer `const endIdx` (from `ensured.indexOf(...)`) and, in the `else if` branch, the pre-existing inner `const startIdx` and `const endIdx` shadow each other inside the same closure. No runtime bug occurs because the early-return exits before the shadowing declarations are reached, but TypeScript's `no-shadow` lint rule (if enabled) will flag these. Consider renaming the outer variables to `ensuredStartIdx` / `ensuredEndIdx` to make the intent explicit and remove the shadow.
   
   How can I resolve this? If you propose a fix, please make it concise.

Best possible solution:

Close this stale PR. The latest review rated it F, the branch still lacks merge-ready proof, and there has been no human follow-up after the durable review.

Do we have a high-confidence way to reproduce the issue?

Yes for the review blockers: source inspection shows the PR builds fallback prose from staging fragments, drops all italic lines from diary fingerprints, and patches a stale SDK path. I did not run tests or a live dreaming flow because this review is read-only.

Is this the best way to solve the issue?

No. The nested-heading strip direction is useful, but this branch is not the best fix until it preserves fallback secrecy, keeps valid diary body text in fingerprints, targets the active runtime path, and supplies real behavior proof.

Security review:

Security review needs attention: The diff introduces a concrete fallback privacy regression by deriving user-readable DREAMS.md fallback text from raw staging snippets and promotions.

• [medium] Fallback prose can leak staging fragments — extensions/memory-core/src/dreaming-narrative.ts:146
  The new fallback builder consumes snippets/promotions and persists derived text to DREAMS.md, while current main deliberately writes a generic placeholder to avoid leaking session metadata, conversation summaries, or operational logs.
  Confidence: 0.9

AGENTS.md: found and applied where relevant.

What I checked:

• stale F-rated PR: PR was opened 2026-04-22T20:23:24Z, is older than 60 days, and the latest review rated it F.
• proof blocker: real behavior proof is mock_only and proof tier is F, so this branch is not merge-ready without contributor follow-up.
• no human follow-up: live comments and timeline hydrated by apply contain no non-automation activity after the ClawSweeper review.

Likely related people:

• vincentkoc: Recent history shows multiple memory-core dreaming changes, and current-main blame/review context is relevant to the fallback privacy, fingerprint, and session-ingestion boundaries. (role: recent area contributor and reviewer; confidence: high; commits: 8a4a63ca076e, 077cfca22972, b78713a36391; files: extensions/memory-core/src/dreaming-phases.ts, extensions/memory-core/src/dreaming-narrative.ts, packages/memory-host-sdk/src/host/session-files.ts)
• Ted Li: Commit 2373022 added stripManagedDailyDreamingLines and daily-ingestion stripping for managed Light/REM blocks, credited in the commit subject to @MonkeyLeeT. (role: introduced managed-block stripping behavior; confidence: high; commits: 23730229e151; files: extensions/memory-core/src/dreaming-phases.ts, extensions/memory-core/src/dreaming-phases.test.ts)
• Mariano: History search shows request-scoped dreaming fallback hardening and adjacent daily dreaming ingestion/chunking work in the affected memory-core files. (role: fallback and daily-ingestion contributor; confidence: medium; commits: 46f8c4dfd5f9, 4661bf66c4c4, 20cbc11f1a0a; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-phases.ts)
• Takhoffman: Merged broad dreaming replay, repair, diary cleanup, and session-ingestion work that this PR builds on and partially overlaps. (role: adjacent feature owner; confidence: medium; commits: 847739d82c60; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-phases.ts, packages/memory-host-sdk/src/host/session-files.ts)
• gumadeiras: The self-ingestion hardening commit added contamination heuristics and tests adjacent to this PR's short-term-promotion changes. (role: adjacent contamination-filter contributor; confidence: medium; commits: 0c4e0d703023; files: extensions/memory-core/src/short-term-promotion.ts, extensions/memory-core/src/short-term-promotion.test.ts, extensions/memory-core/src/dreaming-phases.ts)

Codex review notes: model internal, reasoning high; reviewed against c21dcfc7c272.

• The egg game starts only after the PR passes the real-behavior proof check.
• Before that, no creature or rarity is rolled. The treat waits for real proof.
• This is still just collectible flavor: proof affects review readiness, not creature quality.