fix(agent): document that sessions_spawn streamTo is ACP-only#69170
fix(agent): document that sessions_spawn streamTo is ACP-only#69170vvitovec wants to merge 1 commit into
Conversation
Greptile SummaryThis PR documents that the Confidence Score: 5/5Safe to merge — the changes are additive (documentation + guard + tests) with no risk to existing call paths. All findings are P2 or lower. The guard logic is correct, the schema description is accurate, and both new tests cover the intended behaviour. No regressions are introduced. No files require special attention. Reviews (1): Last reviewed commit: "fix(agent): hint streamTo is acp-only" | Re-trigger Greptile |
|
Related work from PRtags group Title: Open PR duplicate: sessions_spawn: streamTo schema lacks runtime=acp hint, causes 2x-token retry loop for subagent…
|
|
Closing this as duplicate or superseded after Codex automated review. PR #69170 is a focused, plausible schema-hint fix, but it is now superseded by maintainer PR #72331. Current main still lacks the Best possible solution: Close #69170 as superseded and continue review/landing through maintainer PR #72331, preserving credit for #69170 there. The best product direction is the broader #72331 fix: keep the schema hint and tolerate ACP-only fields on subagent runtime so strict schema-following providers do not brick spawns. What I checked:
So I’m closing this here and keeping the remaining discussion on the canonical linked item. Codex Review notes: model gpt-5.5, reasoning high; reviewed against edf40ab6c944. |
Summary
sessions_spawn.streamTorequiresruntime="acp"streamTo: "parent"and paying for a guaranteed retryTesting
corepack pnpm exec vitest run src/agents/tools/sessions-spawn-tool.test.ts -t 'documents that streamTo requires runtime="acp"|rejects streamTo when runtime is not "acp"'Closes #69166