Skip to content

fix(agent): document that sessions_spawn streamTo is ACP-only#69170

Closed
vvitovec wants to merge 1 commit into
openclaw:mainfrom
vvitovec:fix/sessions-spawn-streamto-acp-hint
Closed

fix(agent): document that sessions_spawn streamTo is ACP-only#69170
vvitovec wants to merge 1 commit into
openclaw:mainfrom
vvitovec:fix/sessions-spawn-streamto-acp-hint

Conversation

@vvitovec

@vvitovec vvitovec commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • document that sessions_spawn.streamTo requires runtime="acp"
  • stop subagent callers from guessing streamTo: "parent" and paying for a guaranteed retry
  • add a schema regression test for the runtime hint

Testing

  • corepack pnpm exec vitest run src/agents/tools/sessions-spawn-tool.test.ts -t 'documents that streamTo requires runtime="acp"|rejects streamTo when runtime is not "acp"'

Closes #69166

@openclaw-barnacle openclaw-barnacle Bot added agents Agent runtime and tooling size: XS labels Apr 20, 2026
@greptile-apps

greptile-apps Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR documents that the streamTo parameter on sessions_spawn requires runtime="acp", adds a runtime guard that returns an error instead of silently ignoring streamTo for non-ACP callers, and backs it with two new tests: one for the guard behaviour and one as a schema regression test. The changes are narrow and well-targeted.

Confidence Score: 5/5

Safe to merge — the changes are additive (documentation + guard + tests) with no risk to existing call paths.

All findings are P2 or lower. The guard logic is correct, the schema description is accurate, and both new tests cover the intended behaviour. No regressions are introduced.

No files require special attention.

Reviews (1): Last reviewed commit: "fix(agent): hint streamTo is acp-only" | Re-trigger Greptile

@prtags

prtags Bot commented Apr 23, 2026

Copy link
Copy Markdown

Related work from PRtags group living-dingo-54mf

Title: Open PR duplicate: sessions_spawn: streamTo schema lacks runtime=acp hint, causes 2x-token retry loop for subagent…

Number Title
#69170* fix(agent): document that sessions_spawn streamTo is ACP-only
#69203 fix(sessions-spawn): document runtime="acp" requirement on streamTo schema

* This PR

@clawsweeper

clawsweeper Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Closing this as duplicate or superseded after Codex automated review.

PR #69170 is a focused, plausible schema-hint fix, but it is now superseded by maintainer PR #72331. Current main still lacks the streamTo schema description and still rejects runtime="subagent" plus streamTo, so this is not implemented-on-main. The remaining work is already carried forward in #72331, which explicitly credits #69170 and broadens the fix to tolerate ACP-only fields for subagent runtime.

Best possible solution:

Close #69170 as superseded and continue review/landing through maintainer PR #72331, preserving credit for #69170 there. The best product direction is the broader #72331 fix: keep the schema hint and tolerate ACP-only fields on subagent runtime so strict schema-following providers do not brick spawns.

What I checked:

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against edf40ab6c944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sessions_spawn: streamTo schema lacks runtime=acp hint, causes 2x-token retry loop for subagent callers

1 participant