fix(memory-core): downgrade narrative cleanup WARN to debug for missing-scope errors#68312
fix(memory-core): downgrade narrative cleanup WARN to debug for missing-scope errors#683121aifanatic wants to merge 1 commit into
Conversation
deleteSession during dreaming cleanup fails with "missing scope: operator.admin" when the cron session lacks admin permissions. This is expected best-effort behavior, but logged at WARN, which floods logs after every dreaming cycle. Downgrade to debug when the error matches /missing scopes?:/i. Also add optional debug field to the Logger type so callers without a debug method (like dreaming-phases) compile cleanly.
Greptile SummaryThis PR narrows the log level for Confidence Score: 5/5Safe to merge — all remaining findings are P2 or lower, no correctness or reliability concerns. The change is narrow and correct: regex matches the specific error format, optional chaining on No files require special attention. Reviews (1): Last reviewed commit: "fix(memory-core): suppress WARN for narr..." | Re-trigger Greptile |
|
Related work from PRtags group Title: Open PR duplicate: [Bug]: memory-core: narrative session cleanup fails with "missing scope: operator.admin"
|
|
Closing this as duplicate or superseded after Codex automated review. PR #68312 is a duplicate of the open maintainer-tracked PR #68020. Both target the same memory-core dreaming cleanup warning: suppress expected Best possible solution: Close #68312 as a duplicate and keep the remaining product/code review on #68020, the open MEMBER-authored, maintainer-labeled canonical PR for this memory-core cleanup-warning behavior. What I checked:
So I’m closing this here and keeping the remaining discussion on the canonical linked item. Codex Review notes: model gpt-5.5, reasoning high; reviewed against d54d2d6b9b8a. |
Summary
deleteSessionduring dreaming narrative cleanup fails withmissing scope: operator.adminwhen the cron session lacks admin permissionswarnlog fires on every dreaming cycle, flooding the logs/missing scopes?:/iin the error message and log atdebuglevel instead ofwarndebugfield to the localLoggertype so callers without a debug method compile cleanlyTest plan
missing scope: operator.adminerror →logger.debugcalled,logger.warnnot called for cleanup"still active") →logger.warnstill called as beforeoperator.adminscope is absent