Gateway: avoid spurious Windows restart on unknown listener stale (#52044)#66627
Gateway: avoid spurious Windows restart on unknown listener stale (#52044)#66627ly85206559 wants to merge 1 commit into
Conversation
Greptile SummaryThis PR splits Confidence Score: 5/5
Reviews (1): Last reviewed commit: "Gateway: avoid spurious restart on Windo..." | Re-trigger Greptile |
4b63b8a to
49367ed
Compare
Rebase onto
|
090262a to
5783172
Compare
…enclaw#52044) - Split staleGatewayPids (diagnostics) from verifiedStaleGatewayPids (gateway-classified, actionable listeners); gate kill/retry and post-restart early-exit on verified stale PIDs only to avoid a third service.restart on Windows when only the unknown-listener fallback matches. - Align update-cli restart follow-up with the same rule; add regression tests for diagnostic-only vs verified stale PID handling. - Pin process.platform to linux in stopped-free and unhealthy-timeout restart tests so elapsed/sleep expectations stay stable on Windows hosts.
5783172 to
fa4a397
Compare
Summary
staleGatewayPids(diagnostics, includes Windows unknown-listener fallback) vsverifiedStaleGatewayPids(gateway-classified, actionable listeners)service.restart()frompostRestartCheckon Windows (Bug: gateway restart spawns duplicate processes on Windows (3 windows) #52044)update-clirestart follow-up with the same rule and add regression coverage for diagnostic-only vs verified stale PID handlingTest plan
pnpm test src/cli/update-cli.test.ts -t "does not re-restart after update|cleans verified stale pids after update"pnpm test src/cli/daemon-cli/restart-health.test.ts src/cli/daemon-cli/lifecycle.test.ts src/cli/daemon-cli/status.gather.test.tsNotes
src/cli/update-cli.test.tsfile still has an unrelated Windows portable-Git PATH test that is noisy on this host; the new restart-follow-up coverage passes.