Greptile Summary

This PR fixes three reliability gaps in the memory-core watcher: registers an error handler on the chokidar watcher to prevent silent crashes, forces dirty = true in the interval callback so syncMemoryFiles isn't skipped when the watcher has died, and raises the default intervalMinutes from 0 to 15 so periodic sync is active out of the box.

• dirty = true is set unconditionally in the interval callback, but this.dirty = false is only executed inside if (shouldSyncMemory), which requires sources.has(\"memory\"). For session-only configs (sessions but no memory), dirty is never cleared and stays permanently true, causing misleading dirty status and spurious sync-on-search invocations.

Confidence Score: 4/5

Safe to merge after addressing the dirty flag leak in session-only configs; all other changes are correct and well-tested.

One P2 logic issue: dirty = true is set unconditionally in the interval callback but is only cleared on the memory-sync path, leaving it permanently true for session-only configs. No P0/P1 issues. Core fixes (watcher error handler, default intervalMinutes: 15, readonly-recovery serialization) are correct and covered by tests.

extensions/memory-core/src/memory/manager-sync-ops.ts — interval callback in ensureIntervalSync

This is a comment left during a code review.
Path: extensions/memory-core/src/memory/manager-sync-ops.ts
Line: 629-634

Comment:
**`dirty` permanently stuck `true` for session-only configs**

`dirty` is the memory-files dirty flag — it's only cleared at `this.dirty = false` inside `if (shouldSyncMemory)`, which requires `this.sources.has("memory")`. For a config where `sources` has `"sessions"` but not `"memory"`, the interval sets `dirty = true` on every tick but nothing ever clears it, so `dirty` stays `true` for the lifetime of the manager. Downstream effects: `status()` always reports `dirty: true`, and search-triggered syncs (via `startAsyncSearchSync`) see `dirty: true` and invoke `sync()` on every query, even though those calls are no-ops for memory.

Guard the flag assignment with a sources check:

```suggestion
      if (this.sources.has("memory")) {
        this.dirty = true;
      }
      runDetachedMemorySync(() => this.sync({ reason: "interval" }), "interval");
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (2): Last reviewed commit: "fix: preserve interval sync for sessions..." | Re-trigger Greptile}

Fixed both P2 suggestions in 5ba3fa7:

✅ Removed dead fallback code in extractMemoryErrorReason after formatErrorMessage
✅ Removed redundant sources.has('memory') guard in interval callback

Both suggestions were valid - formatErrorMessage never returns an empty string for any real error input, and the outer guard ensures sources.has('memory') is always true in the callback.

@chatgpt-codex-connector Fixed in afaf869. You're right that sessions-only configs should retain interval sync for retry purposes. Changed the condition to allow interval sync when either memory files OR sessions are enabled, so session sync failures can be retried via the interval fallback mechanism.

To use Codex here, create a Codex account and connect to github.

@greptile-apps Fixed the redundant sources.has('memory') guard in 5ba3fa7 — removed the inner check as suggested since the outer guard already ensures only memory-enabled configs create intervals.

@chatgpt-codex-connector Fixed the sessions-only config issue in afaf869 — changed condition to !this.sources.has('memory') && !this.sources.has('sessions') to preserve interval sync for sessions when memory files are disabled. This maintains retry behavior for session sync failures as noted.

To use Codex here, create a Codex account and connect to github.