docs(parity): (GPT 5.4 Parity vs. Opus Agentic) catch up 10-PR program state with architecture diagrams#64837
docs(parity): (GPT 5.4 Parity vs. Opus Agentic) catch up 10-PR program state with architecture diagrams#64837100yenadmin wants to merge 10 commits into
Conversation
Greptile SummaryThis docs-only PR expands Confidence Score: 5/5Safe to merge; all remaining findings are P2 documentation-completeness or clarity suggestions with no runtime impact. No code changes, no logic errors, and no broken invariants. The only items are a stale table column header that undersells the full 10-PR program, a diagram cycle whose intent is inferrable, and a missing "Does not own" block in one PR section. docs/help/gpt54-codex-agentic-parity.md (stale "After PR A-D" summary table; diagram cycle in Dual-provider mock), docs/help/gpt54-codex-agentic-parity-maintainers.md (PR M section missing "Does not own" block)
|
There was a problem hiding this comment.
Pull request overview
Updates the GPT-5.4/Codex agentic parity documentation to reflect the expanded parity program state (beyond the original A–D slices), adding additional PR coverage, new architecture diagrams, an end-to-end runbook, and an updated goal-to-evidence mapping.
Changes:
- Expands parity program coverage from the initial PRs (A–D) to include follow-up slices (E/F/H/J/K/L) and updates scenario descriptions/matrix accordingly.
- Adds new mermaid diagrams describing mock routing, parity orchestration, and tool-call assertion seams.
- Adds an end-to-end parity gate runbook and updates release-gate / goal-to-evidence matrices.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/help/gpt54-codex-agentic-parity.md | Expands parity narrative, adds diagrams, adds end-to-end runbook, updates scenario/matrix and release-gate mapping. |
| docs/help/gpt54-codex-agentic-parity-maintainers.md | Updates maintainer review guidance to the expanded program and adds a documentation (PR M) merge-unit section. |
Comments suppressed due to low confidence (1)
docs/help/gpt54-codex-agentic-parity.md:223
- This section says the parity pack is now 10 scenarios, but the current
QA_AGENTIC_PARITY_SCENARIOSconstant still enumerates 5 scenario IDs. Unless the code is updated elsewhere in this PR/branch, the docs will mislead readers about what--parity-pack agenticactually runs and what the parity gate covers. Either update the docs to reflect the current 5-scenario pack or land the scenario-pack expansion first and then update the docs.
## Scenario pack
The parity pack covers ten scenarios after the second-wave expansion:
### `approval-turn-tool-followthrough`
Checks that the model does not stop at “I’ll do that” after a short approval. It should take the first concrete action in the same turn.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94e76728c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3c0f63d2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b46c51fded
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b46c51f to
60e5ee3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60e5ee3d9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc30b85de6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cc30b85 to
8a81016
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a810160ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Current head What changed on this head:
Local validation passed:
If any remaining GitHub red is still the shared current-main type/lint churn outside this docs/workflow diff, please treat that as shared CI debt rather than a PR-M-specific failure. |
…nd three architecture diagrams
…lag, diagram cycles, PR M Does-not-own)
…nd-to-end against the qa-lab mock
c284723 to
2c01bdd
Compare
|
Current head Local validation after the rebase:
The workflow/runbook changes remain intentionally |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c01bddfc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Current head: Maintainer update after the docs/workflow cleanup:
From a branch-owned perspective this is ready for review/merge. |
|
@steipete remaining GPT 5.4 fixes are ready for review. Built and completed live harness test (see PR for it + you can test as well if you like or use in future for tuning for models to openclaw by provider/model). Passes 10/10 parity scenario test side by side vs Opus 4.6 in Openclaw. |
|
Superseded by #65216. The code, tests, and proof work from this slice were carried forward into the parity proof rollup so maintainers only need to review one proof/release-certification PR. Closing this preserves the discussion history while avoiding review sprawl. |
Summary
Documentation-only catch-up. Brings
docs/help/gpt54-codex-agentic-parity.mdanddocs/help/gpt54-codex-agentic-parity-maintainers.mdup to the full ten-PR state of the parity program, adds three new architecture diagrams, an end-to-end runbook, and an updated goal-to-evidence matrix.Zero runtime, test, scenario registry, CLI, or architecture changes. Part of #64227.
Why this exists
The earlier parity docs were written for the first-wave 4-PR plan (A, B, C, D). Once the refinement wave started landing on branches (E, H, J, K, L), the docs were stuck describing a much smaller program than what was actually in flight. Reviewers couldn't tell from a single page what was merged, what was open, or how the pieces fit together — so I'm treating "the full story is legible from the docs" as part of the criterion 5 deliverable and splitting it out here so it doesn't have to wait on whichever wave-2 PR is the last to merge.
What changed
docs/help/gpt54-codex-agentic-parity.mdWhere things standtable listing the full program with per-PR merge status.What changedaround "the runtime contract" (PRs A, B, C, H), "the parity harness" (PRs D, E, K, L), and "tool-call enforcement" (PR J) instead of a flat list of ten subsections.Running the harness end-to-endsection with the three-step flow using the real CLI flags (--model/--alt-modelonqa suite,--candidate-summary/--baseline-summaryonqa parity-report), plus a clear note that the baseline lane only runs fully offline after PR K lands.Release gateandGoal-to-evidence matrixso the five criteria map across all ten PRs.mainyet.docs/help/gpt54-codex-agentic-parity-maintainers.mdOwns/Does not ownsubsections for E, F, H, J, K, L, and M.Mapping back to the original six contractsso "Same-turn execution" is PR A + PR H, "Replay/continuation/liveness correctness" is PR C + PR H, and "Benchmark/release gate" spans PR D + PR E + PR J + PR K + PR L + PR M.Review orderaround the real dependency graph (H independent; E depends on D; K independent; J depends on E; L independent; M last) instead of a flat enumerated list.What to look forsubsections for each new PR.Release gateto require PR H merged, PR D + PR E clean on both providers, PR J tool-call assertions passing, PR K's dual-provider mock exercised in CI, and PR L's run metadata present on both summaries.Test plan
wc -l docs/help/gpt54-codex-agentic-parity.md— consolidated from the earlier 401-line draft into a tighter rewritewc -l docs/help/gpt54-codex-agentic-parity-maintainers.md— similar consolidationrg 'flowchart' docs/help/gpt54-codex-agentic-parity.md— 5 flowcharts (2 original architecture/release diagrams + 3 new)/(for example/v1/responses,/debug/requests) is wrapped in quotes so it doesn't collide with mermaid's parallelogram shape--model/--alt-model), not the earlier draft's--primary-modelScope the way a reviewer should see it
maintoday (--model), not a speculative future flag.