fix: preserve commands.list metadata#64147
Conversation
openclaw-barnacle
Bot
added
gateway
Greptile SummaryThis PR fixes two metadata gaps in the Confidence Score: 5/5Safe to merge; changes are narrow, well-tested, and correct. Both fixes are targeted and clearly correct — category: tools on skill commands and the cmd.scope === text guard in mapCommand align exactly with the intent described in the PR. New regression tests cover both paths. The only finding is a P2 changelog placement style issue (entry inserted at the top of ### Fixes instead of appended to the end), which does not affect correctness or behavior. No files require special attention. Prompt To Fix All With AIThis is a comment left during a code review.
Path: CHANGELOG.md
Line: 20
Comment:
**Changelog entry inserted at top of section**
Per the repo guideline, new entries should be appended to the **end** of the target section, not inserted at the top. This entry currently sits as the first item under `### Fixes`; it should follow all existing entries in that block.
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=fd949e91-5c3a-4ab5-90a1-cbe184fd6ce8))
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix: preserve commands list metadata" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| ### Fixes | ||
|
|
||
| - Gateway: keep `commands.list` skill entries categorized under tools and include provider-aware plugin `nativeName` metadata even when `scope=text`, so remote clients can group skills correctly and map text-surface plugin commands back to native aliases. |
There was a problem hiding this comment.
Per the repo guideline, new entries should be appended to the end of the target section, not inserted at the top. This entry currently sits as the first item under ### Fixes; it should follow all existing entries in that block.
Context Used: CLAUDE.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 20
Comment:
**Changelog entry inserted at top of section**
Per the repo guideline, new entries should be appended to the **end** of the target section, not inserted at the top. This entry currently sits as the first item under `### Fixes`; it should follow all existing entries in that block.
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=fd949e91-5c3a-4ab5-90a1-cbe184fd6ce8))
How can I resolve this? If you propose a fix, please make it concise.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
24c4d70 to
46b6695
Compare
Merged via squash. Reviewed-by: @frankekn
Merged via squash. Reviewed-by: @frankekn
Merged via squash. Reviewed-by: @frankekn
Merged via squash. Reviewed-by: @frankekn
Merged via squash. Reviewed-by: @frankekn
Merged via squash. Reviewed-by: @frankekn
1 participant
Summary
toolsincommands.listnativeNamemetadata even whenscope=textValidation
pnpm exec vitest run src/auto-reply/commands-registry.test.ts src/gateway/server-methods/commands.test.ts2files,42tests)OPENCLAW_LOCAL_CHECK=0 pnpm tsgoorigin/mainbaseline issues insrc/agents/provider-request-config.ts,src/media-understanding/runner.entries.ts, and unrelated pre-existing test typing lanesContext
Follow-up to #62656 after post-merge review comments identified two missing metadata cases.