fix(browser): re-check interaction-driven navigations by eleqtrizit · Pull Request #63226 · openclaw/openclaw

eleqtrizit · 2026-04-08T15:34:14Z

Summary

re-check browser tab safety after navigation-capable interaction actions
carry the resolved browser SSRF policy through click, evaluate, and batch interaction flows

Changes

run assertPageNavigationCompletedSafely(...) after Playwright click and evaluate calls so interaction-driven main-frame navigations are quarantined when they land on blocked URLs
thread ssrfPolicy through act route handling, hook-triggered clicks, and batched browser actions so interaction paths use the same policy as guarded navigation paths
add regression coverage for click, evaluate, and batch interaction flows, and update the batch test mock to match the guarded session contract

Validation

Ran corepack pnpm test extensions/browser/src/browser/pw-tools-core.interactions.navigation-guard.test.ts extensions/browser/src/browser/pw-tools-core.interactions.evaluate.abort.test.ts extensions/browser/src/browser/pw-tools-core.interactions.batch.test.ts extensions/browser/src/browser/pw-tools-core.clamps-timeoutms-scrollintoview.test.ts
Ran corepack pnpm tsgo and observed unrelated pre-existing repo-wide type errors outside the touched browser files
Attempted local agentic review with claude -p "/review", but the tool requested an existing PR context/number before it would proceed

Notes

An earlier closed branch explored the same follow-up action-gating direction; this PR reapplies the scoped interaction-path portion against current main
Residual gap: repo-wide tsgo is currently red on unrelated files, so validation here is scoped to the touched browser interaction surface

greptile-apps · 2026-04-08T15:38:17Z

Greptile Summary

This PR extends the browser SSRF policy guard to cover interaction-driven navigations: clicks, evaluate calls, and batch sequences. It introduces assertInteractionNavigationCompletedSafely which tracks framenavigated events during the action and checks the URL after, and scheduleDelayedInteractionNavigationGuard for late-firing navigations. ssrfPolicy is now correctly threaded from the route handlers through clickViaPlaywright, evaluateViaPlaywright, batchViaPlaywright, and the file-chooser hook click.

Confidence Score: 5/5

Safe to merge — the navigation guard logic is sound, ssrfPolicy threading is complete, and regression tests cover the key paths.

All remaining observations are cosmetic P2 (minor style inconsistency in how ssrfPolicy is read inside agent.act.ts). No correctness, security, or data-integrity issues found.

No files require special attention.

Vulnerabilities

This PR is a security improvement: it closes an SSRF bypass where a click or evaluate call could trigger a main-frame navigation to a blocked URL without the policy check running. The delayed-navigation guard (scheduleDelayedInteractionNavigationGuard) is intentionally fire-and-forget (response already sent), which is a documented tradeoff for the non-blocking path. No new security regressions identified.

_{Reviews (2): Last reviewed commit: "fix(browser): tighten interaction naviga..." | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 188313d006

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

eleqtrizit · 2026-04-08T17:07:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 188313d006

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

eleqtrizit · 2026-04-08T17:21:55Z

@codex review

chatgpt-codex-connector · 2026-04-08T17:28:12Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ration

…n guard

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0a668cf06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

drobison00 · 2026-04-08T19:35:06Z

@greptile review
@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 995a729937

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T19:40:20Z

+  if (actionError) {
+    throw actionError;


Re-throw falsy interaction errors

assertInteractionNavigationCompletedSafely records failures in actionError, but later branches on truthiness (if (actionError)), so a rejected action with a falsy reason (for example Promise.reject() / throw undefined from evaluate) is treated as success and returned as undefined. This is a behavior regression from the previous direct await path and can silently mark failed act:evaluate calls as successful, which breaks caller error handling and can let later steps run on invalid assumptions.

Useful? React with 👍 / 👎.

* main: (522 commits) fix(browser): re-check interaction-driven navigations (openclaw#63226) test: reuse verbose directive reply imports test: reuse exec directive reply imports fix(browser): harden browser control override loading (openclaw#62663) Matrix: report startup failures as errors auth: persist explicit profile upserts directly test(doctor): mock memory-core runtime seam auth: avoid external cli sync on profile upsert feat: parallelize character eval runs fix: load QA live provider overrides build: stage nostr runtime dependencies fix(dotenv): block workspace runtime env vars (openclaw#62660) build: narrow plugin SDK declaration build test: harden Parallels macOS smoke fallback fix(memory): accept embedded dreaming heartbeat tokens test: harden provider mock isolation docs(config): tighten wording in reference test: reuse followup runner imports test: reuse image generate tool imports Align remote node exec event system messages with untrusted handling (openclaw#62659) ...

* fix(browser): guard interaction-driven navigations * fix(browser): avoid rechecking unchanged interaction urls * fix(browser): guard delayed interaction navigations * fix(browser): guard interaction-driven navigations for full action duration * fix(browser): avoid waiting on interaction grace timer * fix(browser): ignore same-document hash-only URL changes in navigation guard * fix(browser): dedupe interaction nav guards * fix(browser): guard same-URL reloads in interaction navigation listeners * docs(changelog): add interaction navigation guard entry * fix(browser): drop duplicate ssrfPolicy props * fix(browser): tighten interaction navigation guards --------- Co-authored-by: Devin Robison <[email protected]>

eleqtrizit mentioned this pull request Apr 8, 2026

fix(browser): re-check interaction-driven navigations #62005

Closed

openclaw-barnacle Bot added size: L maintainer Maintainer-authored PR labels Apr 8, 2026

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread extensions/browser/src/browser/pw-tools-core.interactions.ts

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread extensions/browser/src/browser/pw-tools-core.interactions.ts Outdated

eleqtrizit and others added 9 commits April 8, 2026 13:12

fix(browser): guard interaction-driven navigations

aaf31e0

fix(browser): avoid rechecking unchanged interaction urls

4abdbf9

fix(browser): guard delayed interaction navigations

9380cd4

fix(browser): guard interaction-driven navigations for full action du…

a968c79

…ration

fix(browser): avoid waiting on interaction grace timer

80b223c

fix(browser): ignore same-document hash-only URL changes in navigatio…

b7948e7

…n guard

fix(browser): dedupe interaction nav guards

994f8db

fix(browser): guard same-URL reloads in interaction navigation listeners

de5e4b0

docs(changelog): add interaction navigation guard entry

cc9edf7

drobison00 force-pushed the fix/browser-interaction-guard branch from 188313d to cc9edf7 Compare April 8, 2026 19:16

fix(browser): drop duplicate ssrfPolicy props

d0a668c

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread extensions/browser/src/browser/pw-tools-core.interactions.ts

fix(browser): tighten interaction navigation guards

995a729

drobison00 merged commit 5f5b3d7 into openclaw:main Apr 8, 2026
9 checks passed

chatgpt-codex-connector Bot reviewed Apr 8, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 8, 2026

📡 Upstream Digest — 2026-04-08 20:35 UTC curtismercier/openclaw-mods#513

Open

github-actions Bot mentioned this pull request Apr 13, 2026

Update ghcr.io/openclaw/openclaw Docker tag to v2026.5.7 - autoclosed claytono/infra#1977

Closed

1 task

clawsweeper Bot mentioned this pull request May 24, 2026

Feature: browser tool evaluate should support statements (var/let/const) #51393

Closed

This was referenced Jul 9, 2026

fix(browser): bind wait predicates to allowed documents #101852

Merged

fix(browser): block interaction-triggered navigation SSRF #104254

Merged

Uh oh!

Uh oh!

Conversation

eleqtrizit commented Apr 8, 2026

Summary

Changes

Validation

Notes

Uh oh!

greptile-apps Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Vulnerabilities

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

eleqtrizit commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

eleqtrizit commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

drobison00 commented Apr 8, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Apr 8, 2026 •

edited

Loading