Align remote node exec event system messages with untrusted handling#62659
Conversation
openclaw-barnacle
Bot
added
gateway
Greptile SummaryThis PR hardens the remote node exec event pipeline by marking Confidence Score: 5/5Safe to merge — narrow security hardening with no regressions and full test coverage of the new behavior. All remaining concerns are P2 or lower. The trusted: false flag and sanitization of node-supplied fields close the injection risk, and the test suite explicitly asserts both the flag and the sanitized output. The previously flagged runId issue is tracked in a prior thread and is mitigated by trusted: false. No files require special attention.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@codex review |
|
@greptile review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
* main: (522 commits) fix(browser): re-check interaction-driven navigations (openclaw#63226) test: reuse verbose directive reply imports test: reuse exec directive reply imports fix(browser): harden browser control override loading (openclaw#62663) Matrix: report startup failures as errors auth: persist explicit profile upserts directly test(doctor): mock memory-core runtime seam auth: avoid external cli sync on profile upsert feat: parallelize character eval runs fix: load QA live provider overrides build: stage nostr runtime dependencies fix(dotenv): block workspace runtime env vars (openclaw#62660) build: narrow plugin SDK declaration build test: harden Parallels macOS smoke fallback fix(memory): accept embedded dreaming heartbeat tokens test: harden provider mock isolation docs(config): tighten wording in reference test: reuse followup runner imports test: reuse image generate tool imports Align remote node exec event system messages with untrusted handling (openclaw#62659) ...
…62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <[email protected]>
…penclaw#62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <[email protected]>
…penclaw#62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <[email protected]>
…penclaw#62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <[email protected]>
…penclaw#62659) * fix(nodes): downgrade remote exec system events * docs(changelog): add remote node exec event entry --------- Co-authored-by: Devin Robison <[email protected]>
2 participants
Summary
Changes
exec.started,exec.finished, andexec.deniednode events astrusted: falsecommand,output, andreasontext before enqueueing system eventssrc/gateway/server-node-events.test.tsValidation
pnpm test src/gateway/server-node-events.test.tspnpm tsgo --pretty falsepnpm checkvia the commit hookNotes
claude -p "/review"could not complete in this environment because it requested an approval step forgh pr list