fix(memory): respect selected slot in dreaming config by SnowSky1 · Pull Request #62275 · openclaw/openclaw

SnowSky1 · 2026-04-07T03:37:31Z

Summary

make the dreaming toggle patch the selected memory slot plugin instead of hardcoding memory-core
make doctor.memory.status read dreaming config from plugins.slots.memory when present
add focused regression coverage for the selected-slot UI patch path and doctor status path

Related #62098

SnowSky1 · 2026-04-07T03:37:52Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09d76e12cf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T03:41:52Z

+export function resolveMemoryDreamingPluginConfig(
  cfg: OpenClawConfig | Record<string, unknown> | undefined,
 ): Record<string, unknown> | undefined {


Re-export resolveMemoryCorePluginConfig for compatibility

This change removes the resolveMemoryCorePluginConfig export from the host dreaming module by renaming it to resolveMemoryDreamingPluginConfig, but existing callers still import the old symbol (for example via src/plugin-sdk/memory-core.ts and extension imports from openclaw/plugin-sdk/memory-core-host-status). That makes the commit break type-check/build (and can produce missing-export module load failures) for current consumers. Keep a backward-compatible export alias for the old function name before migrating all call sites.

Useful? React with 👍 / 👎.

greptile-apps · 2026-04-07T03:44:30Z

Greptile Summary

This PR correctly makes dreaming config and UI toggle slot-aware by reading plugins.slots.memory to resolve the active memory plugin ID instead of hardcoding memory-core. The new resolveMemoryDreamingPluginId/resolveMemoryDreamingPluginConfig helpers in src/memory-host-sdk/dreaming.ts and the parallel resolveDreamingPluginId in ui/src/ui/controllers/dreaming.ts are consistent and correct.

The first test in src/gateway/server-methods/doctor.test.ts asserts dreaming.enabled: true with an empty mock config ({}), but DEFAULT_MEMORY_DREAMING_ENABLED = false means resolveMemoryDreamingConfig will produce enabled: false, causing the test to fail.

Confidence Score: 4/5

Safe to merge after correcting the incorrect enabled: true assertion in the first doctor.test.ts smoke test.

The slot-aware logic is correct and well-exercised by the new regression tests. A single wrong assertion in the smoke test (enabled: true vs actual enabled: false) would cause a test failure.

src/gateway/server-methods/doctor.test.ts line 121

Comments Outside Diff (1)

src/gateway/server-methods/doctor.test.ts, line 119-122 (link)

Incorrect enabled: true assertion with empty config

The test never calls loadConfig.mockReturnValue(...), so loadConfig() returns the hoisted default {}. With an empty config, resolveMemoryDreamingPluginConfig({}) returns undefined, and resolveMemoryDreamingConfig({ pluginConfig: undefined }) normalizes dreaming.enabled against DEFAULT_MEMORY_DREAMING_ENABLED = false, yielding enabled: false. The assertion enabled: true will cause this test to fail.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/gateway/server-methods/doctor.test.ts
Line: 119-122

Comment:
**Incorrect `enabled: true` assertion with empty config**

The test never calls `loadConfig.mockReturnValue(...)`, so `loadConfig()` returns the hoisted default `{}`. With an empty config, `resolveMemoryDreamingPluginConfig({})` returns `undefined`, and `resolveMemoryDreamingConfig({ pluginConfig: undefined })` normalizes `dreaming.enabled` against `DEFAULT_MEMORY_DREAMING_ENABLED = false`, yielding `enabled: false`. The assertion `enabled: true` will cause this test to fail.



How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: src/gateway/server-methods/doctor.test.ts
Line: 119-122

Comment:
**Incorrect `enabled: true` assertion with empty config**

The test never calls `loadConfig.mockReturnValue(...)`, so `loadConfig()` returns the hoisted default `{}`. With an empty config, `resolveMemoryDreamingPluginConfig({})` returns `undefined`, and `resolveMemoryDreamingConfig({ pluginConfig: undefined })` normalizes `dreaming.enabled` against `DEFAULT_MEMORY_DREAMING_ENABLED = false`, yielding `enabled: false`. The assertion `enabled: true` will cause this test to fail.

```suggestion
        dreaming: expect.objectContaining({
          enabled: false,
          shortTermCount: 0,
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(memory): respect memory slot in drea..." | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7fd52fe16

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T03:52:08Z

+  return DEFAULT_MEMORY_DREAMING_PLUGIN_ID;
+}
+
+export function resolveMemoryDreamingPluginConfig(


Re-export resolveMemoryCorePluginConfig alias

Renaming resolveMemoryCorePluginConfig to resolveMemoryDreamingPluginConfig here removes a previously exported symbol and breaks existing imports that still consume the old API (for example src/plugin-sdk/memory-core.ts re-exports resolveMemoryCorePluginConfig, and extension code imports it). That introduces a compile/runtime compatibility break for current plugin-sdk consumers; keep a backward-compatible alias export so downstream modules continue to load while call sites migrate.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84a54e8561

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T06:25:32Z

 }

+// Keep the legacy helper name exported until downstream memory plugins migrate.
+export const resolveMemoryCorePluginConfig = resolveMemoryDreamingPluginConfig;


Preserve memory-core semantics on legacy config helper

resolveMemoryCorePluginConfig previously read only plugins.entries["memory-core"].config, but this alias now points to the slot-aware resolver, so the legacy name silently changes behavior based on plugins.slots.memory. Existing consumers that intentionally target memory-core (for example extensions/memory-wiki/src/bridge.ts when bridge.readMemoryCore is enabled) will now read whichever plugin is selected in the slot and can run memory-core-specific paths against the wrong plugin config. Keep the old export name bound to the memory-core entry and use the new slot-aware helper only where that behavior is intended.

Useful? React with 👍 / 👎.

)

vignesh07 · 2026-04-07T09:48:33Z

Landed via temp rebase onto latest origin/main.

Targeted gate run:

pnpm format -- CHANGELOG.md ui/src/ui/app-render.ts ui/src/ui/controllers/dreaming.test.ts src/memory-host-sdk/dreaming.test.ts src/gateway/server-methods/doctor.test.ts
pnpm test src/gateway/server-methods/doctor.test.ts -t "reads lowercase dreams.md when present"
pnpm test src/gateway/server-methods/doctor.test.ts -t "reads dreaming config from the selected memory slot plugin"
pnpm test src/memory-host-sdk/dreaming.test.ts ui/src/ui/controllers/dreaming.test.ts

Land commit: 9e68ce1
Merge commit: b21dd9c

Thanks @SnowSky1!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e68ce1260

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T09:53:10Z

+  const { pluginId } = resolveConfiguredDreaming(asRecord(state.configSnapshot?.config) ?? null);
  const ok = await writeDreamingPatch(state, {
    plugins: {
      entries: {
-        "memory-core": {
+        [pluginId]: {


Skip dreaming patch for unsupported memory slot plugins

updateDreamingEnabled now writes plugins.entries[slotPluginId].config.dreaming.enabled for whichever plugin owns plugins.slots.memory, but not all built-in memory plugins accept a dreaming block (for example extensions/memory-lancedb/openclaw.plugin.json has additionalProperties: false and requires an embedding object). In that valid configuration, toggling Dreams from Control UI sends an invalid patch and config.patch fails validation, so the toggle becomes a persistent runtime error for users on non-dreaming memory providers.

Useful? React with 👍 / 👎.

)

openclaw-barnacle Bot added app: web-ui App: web-ui gateway Gateway runtime extensions: memory-core Extension: memory-core size: M labels Apr 7, 2026

SnowSky1 mentioned this pull request Apr 7, 2026

[Bug]: Control UI dreaming toggle creates orphaned top-level memory-core config triggering 'not in allowlist' warning #62098

Closed

chatgpt-codex-connector Bot reviewed Apr 7, 2026

View reviewed changes

SnowSky1 force-pushed the codex/62098-dreaming-memory-slot branch from 09d76e1 to c13c73b Compare April 7, 2026 03:47

openclaw-barnacle Bot removed the extensions: memory-core Extension: memory-core label Apr 7, 2026

SnowSky1 force-pushed the codex/62098-dreaming-memory-slot branch from c13c73b to f7fd52f Compare April 7, 2026 03:48

chatgpt-codex-connector Bot reviewed Apr 7, 2026

View reviewed changes

SnowSky1 force-pushed the codex/62098-dreaming-memory-slot branch from f7fd52f to 84a54e8 Compare April 7, 2026 06:19

chatgpt-codex-connector Bot reviewed Apr 7, 2026

View reviewed changes

vignesh07 mentioned this pull request Apr 7, 2026

fix(memory): respect selected memory slot in dreaming config #62394

Closed

SnowSky1 and others added 4 commits April 7, 2026 02:44

fix(memory): respect memory slot in dreaming config

15b0e8b

Dreaming UI: use slot-aware configured state

ac2ca96

fix: slot-aware dreaming config paths (openclaw#62275) (thanks @SnowSky1

bac7f49

)

Tests: stabilize dream diary case assertion (openclaw#62275)

9e68ce1

vignesh07 force-pushed the codex/62098-dreaming-memory-slot branch from f8d411d to 9e68ce1 Compare April 7, 2026 09:47

vignesh07 merged commit b21dd9c into openclaw:main Apr 7, 2026
6 checks passed

vignesh07 added a commit that referenced this pull request Apr 7, 2026

fix: slot-aware dreaming config paths (#62275) (thanks @SnowSky1)

733063e

chatgpt-codex-connector Bot reviewed Apr 7, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 7, 2026

📡 Upstream Digest — 2026-04-07 10:49 UTC curtismercier/openclaw-mods#497

Open

fabioscarsi mentioned this pull request Apr 8, 2026

Allow memory-core dreaming runtime to coexist with third-party memory slot plugins #63067

Closed

lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026

fix: slot-aware dreaming config paths (openclaw#62275) (thanks @SnowSky1

e7d37da

)

lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026

Tests: stabilize dream diary case assertion (openclaw#62275)

2cbc1f4

ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026

fix: slot-aware dreaming config paths (openclaw#62275) (thanks @SnowSky1

d57ffe7

)

ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026

Tests: stabilize dream diary case assertion (openclaw#62275)

95bd511

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026

fix: slot-aware dreaming config paths (openclaw#62275) (thanks @SnowSky1

e6311c8

)

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026

Tests: stabilize dream diary case assertion (openclaw#62275)

71cc032

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026

fix: slot-aware dreaming config paths (openclaw#62275) (thanks @SnowSky1

93890b5

)

github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026

Tests: stabilize dream diary case assertion (openclaw#62275)

ca925fb

This was referenced May 24, 2026

feat(memory): add multi-slot memory role architecture #86210

Closed

feat(memory): add multi-slot memory role architecture #88504

Open

clawsweeper Bot mentioned this pull request Jun 15, 2026

docs: note LanceDB dreaming v0.2.3 via memory-lancedb-dreaming plugin #87535

Closed

Uh oh!

Uh oh!

Conversation

SnowSky1 commented Apr 7, 2026

Summary

Uh oh!

SnowSky1 commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vignesh07 commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Apr 7, 2026 •

edited

Loading