Greptile Summary

Adds a minimal Plan Mode runtime with a mutation gate, session-persistent plan state, and resume support. The implementation is well-structured and backed by solid test coverage across 7 test files. All findings are P2.

Confidence Score: 5/5

Safe to merge; all findings are P2 style/cleanup items with no blocking correctness issues.

No P0 or P1 issues found. The mutation gate, session persistence, and system-prompt injection are all correct. The three findings are a misleading debug-log count, a potential store-path mismatch under a non-default session.store config, and a silent plan-state reset when re-entering plan mode — none blocking.

src/agents/pi-embedded-runner/run/attempt.ts (store path derivation at line 718) and src/plugins/hook-runner-global.ts (hook count log at line 50)

This is a comment left during a code review.
Path: src/plugins/hook-runner-global.ts
Line: 50-53

Comment:
**`registry.hooks` does not count `typedHooks`**

The plan-mode hook is registered via `registry.typedHooks.push(...)`, but the debug-log counter reads `registry.hooks.length`, which is a separate array the `HookRunner` does not use (it reads `typedHooks` exclusively). After this PR, `initializeGlobalHookRunner` will always log "0 hooks" even when the mutation gate is active.

```suggestion
  const hookCount = registry.typedHooks.length + registry.hooks.length;
  if (hookCount > 0) {
    log.debug(`hook runner initialized with ${hookCount} registered hooks`);
  }
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/agents/pi-embedded-runner/run/attempt.ts
Line: 715-720

Comment:
**Hardcoded store path may miss custom `session.store` config**

The store path is derived from the transcript file's parent directory rather than from `resolveStorePath`. For users with a custom `session.store` config the two paths can diverge, so `planModeActive` will always be `false` on resume and the `## Plan Mode` system-prompt section will never be injected. `params.config` and `sessionAgentId` are both in scope here:

```
// add import: import { resolveStorePath } from "../../../config/sessions/paths.js";

const planModeState = params.sessionKey
  ? readSessionRuntimeStateFromStorePath({
      sessionKey: params.sessionKey,
      storePath: resolveStorePath(params.config?.session?.store, {
        agentId: sessionAgentId,
      }),
    })
  : null;
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/agents/tools/plan-mode-tools.ts
Line: 194-214

Comment:
**Re-entering plan mode silently clears existing plan state**

`enter_plan_mode` is not in the mutation blocklist, so it can be called while plan mode is already active. The `mutate` callback returns only `{ enteredAt, updatedAt }` — `updateSessionPlanState` replaces the entire `planState` field with this object, discarding any previously written `content` and `todos`. If the reset is intentional a short comment or an early-return guard (when `runtimeMode === "plan"` already) would make the behavior explicit.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat(plan-mode): surface persisted plan ..." | Re-trigger Greptile}

Closing this as duplicate or superseded after Codex automated review.

Close #61845 as superseded. Current main does not ship this PR's minimal plan-mode runtime; the broader Plan Mode direction moved through later plan-mode rollout attempts and is now represented by the active #71731 plugin-host RFC path plus #71732-#71737 decision threads. #61845 is no longer the right merge vehicle because it is stale, dirty, and has unresolved review concerns.

Best possible solution:

Close #61845 and keep remaining Plan Mode design on #71731 and #71732-#71737. If the feature moves forward, it should land as a fresh clean implementation after the plugin-host seams are settled, or through an explicit maintainer-approved core PR.

What I checked:

• Current main only exposes update_plan, not plan-mode runtime tools: createUpdatePlanTool defines the current structured planning tool as name: "update_plan"; it is a run-local planning helper, not the persisted enter_plan_mode/exit_plan_mode mutation-gated workflow proposed by feat(plan-mode): minimal plan mode with mutation gate and resume #61845. (src/agents/tools/update-plan-tool.ts:76, 06d409dc2738)
• Plan tool registration is limited to update_plan gating: Current main gates only the existing update_plan tool through tools.experimental.planTool or strict-agentic activation; it does not register the five feat(plan-mode): minimal plan mode with mutation gate and resume #61845 plan-mode tools. (src/agents/openclaw-tools.registration.ts:11, 06d409dc2738)
• ACP runtime mode remains backend-defined on main: Current main keeps AcpSessionRuntimeOptions.runtimeMode?: string, preserving backend-defined ACP mode tokens rather than adopting feat(plan-mode): minimal plan mode with mutation gate and resume #61845's SessionRuntimeMode = "plan" | "normal" | "auto" enum. This aligns with the review concern that the PR's enum allowlist would regress custom ACP modes. (src/config/sessions/types.ts:54, 06d409dc2738)
• Concrete feat(plan-mode): minimal plan mode with mutation gate and resume #61845 runtime surfaces are absent from current main: A targeted search for enter_plan_mode, exit_plan_mode, todo_write, task_create, task_update, plan_mode_status, SessionPlanState, SessionRuntimeMode, planState, planApproval, and agents.defaults.planMode found no current implementation hits for the feat(plan-mode): minimal plan mode with mutation gate and resume #61845 surface. Matches were unrelated ACP runtime-model or generic plan references. (06d409dc2738)
• Later canonical Plan Mode path supersedes this PR: The later Plan Mode tracker [Plan Mode] Master tracker for the 9-PR upstream rollout #70101 was closed as superseded, explicitly pointing remaining work to [plugin sdk] docs: plugin host hook RFC #71731, an open Plan Mode plugin-host RFC, with [RFC] Plugin session extensions and patch actions #71732-[RFC] Agent events, run context, scheduler lifecycle, and heartbeat contributions #71737 open as the decision threads for the missing host seams.
• PR branch is not a clean current implementation vehicle: feat(plan-mode): minimal plan mode with mutation gate and resume #61845 is labeled triage: dirty-candidate; its file list includes unrelated help-fast-path artifacts (PR_DESCRIPTION.md, scripts/bench-help-fast-path.sh), and review comments flagged unresolved compatibility/safety issues such as ACP runtime-mode narrowing and missing cron mutation blocking.

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against 06d409dc2738.