Skip to content

fix(i18n): add device/node pairing terms to zh-CN glossary#61396

Merged
steipete merged 1 commit into
openclaw:mainfrom
zeuming:fix/i18n-glossary-device-node-pairing
Jul 9, 2026
Merged

fix(i18n): add device/node pairing terms to zh-CN glossary#61396
steipete merged 1 commit into
openclaw:mainfrom
zeuming:fix/i18n-glossary-device-node-pairing

Conversation

@zeuming

@zeuming zeuming commented Apr 5, 2026 •
edited by steipete
Loading

Copy link
Copy Markdown

Summary

  • The zh-CN translation pipeline confused openclaw devices list/approve with openclaw nodes pending/approve when translating the node-host pairing section because the glossary had no entries distinguishing the two pairing subsystems.
  • Add glossary entries for device pairing, node pairing, and the key CLI commands so the translation model has explicit guidance to keep them distinct.

What Problem This Solves

OpenClaw has separate device-pairing and node-pairing stores and commands. Without explicit zh-CN glossary terms, translated docs can conflate openclaw devices list/approve with openclaw nodes pending/approve, leading readers to use the wrong approval workflow.

Evidence

  • Parsed docs/.i18n/glossary.zh-CN.json successfully and verified all 359 source terms are unique.
  • pnpm docs:check-i18n-glossary
  • pnpm format:docs:check — 689 docs files clean.
  • pnpm check:docs — formatting, lint, MDX, glossary, 5,783 internal links, and docs map all pass.
  • Structured autoreview: clean, no accepted/actionable findings (0.99 confidence).

Change Type

  • Docs

User-visible / Behavior Changes

None at runtime. The glossary affects future zh-CN translation runs.

Security Impact

None.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation size: XS labels Apr 5, 2026
@greptile-apps

greptile-apps Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds nine zh-CN glossary entries to distinguish device pairing (设备配对) from node pairing (节点配对) and keep the four CLI commands (openclaw devices list/approve, openclaw nodes pending/approve) untranslated, preventing the translation model from conflating the two pairing subsystems. All entries are well-formed and follow the existing JSON array conventions.

Confidence Score: 5/5

Safe to merge — glossary-only change with no logic or behavior impact.

All entries are well-formed, follow existing conventions, CLI commands correctly preserve source==target, and no P0/P1 issues were found.

No files require special attention.

Reviews (1): Last reviewed commit: "fix(i18n): add device/node pairing terms..." | Re-trigger Greptile

@zeuming

zeuming commented Apr 5, 2026

Copy link
Copy Markdown
Author

This CI failure is unrelated to this PR. The ERR_PNPM_OUTDATED_LOCKFILE error is caused by a mismatch between extensions/acpx/package.json and
pnpm-lock.yaml on main ([email protected] was replaced by @agentclientprotocol/sdk@^0.9.4 but the lockfile wasn't updated). This PR only touches
docs/.i18n/glossary.zh-CN.json.

@vincentkoc vincentkoc added the triage: low-signal-docs Candidate: docs-only change looks low signal; maintainer review needed. label Apr 26, 2026
@clawsweeper

clawsweeper Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codex review: needs changes before merge. Reviewed July 9, 2026, 10:40 AM ET / 14:40 UTC.

Summary
The PR adds Simplified Chinese docs glossary entries for device/node pairing terms and related openclaw devices and openclaw nodes commands.

PR surface: Docs +34. Total +34 across 1 file.

Reproducibility: yes. for the PR-head defect: the live PR patch shows the added openclaw nodes approve object missing its delimiter before the next glossary entry, while current main parses successfully.

Review metrics: 1 noteworthy metric.

  • Glossary parseability: 1 malformed object; 9 proposed source terms. The terms are useful, but one missing delimiter prevents JSON.parse consumers from loading the zh-CN glossary.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🌊 off-meta tidepool
Patch quality: 🧂 unranked krab
Result: blocked by patch quality or review findings.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Add the missing delimiter after the openclaw nodes approve glossary entry.
  • Run a JSON parse check, git diff --check -- docs/.i18n/glossary.zh-CN.json, and pnpm docs:check-i18n-glossary if dependencies are available.

Risk before merge

  • [P1] Merging this head would leave docs/.i18n/glossary.zh-CN.json malformed, which can break docs i18n checks or translation automation after merge.

Maintainer options:

  1. Repair delimiter and validate glossary (recommended)
    Insert the missing }, after the openclaw nodes approve entry and rerun focused JSON/glossary validation before merge.
  2. Wait for contributor refresh
    Leave the PR open for the contributor to update the branch and provide the same focused validation after the delimiter repair.
Copy recommended automerge instruction 
@clawsweeper automerge

Special instructions:
Preserve the added zh-CN glossary entries, insert the missing object close/comma after the `openclaw nodes approve` target, then validate with a JSON.parse check, `git diff --check -- docs/.i18n/glossary.zh-CN.json`, and `pnpm docs:check-i18n-glossary` if dependencies are available.

Next step before merge

  • [P2] Queue a narrow repair because the only blocker is a missing JSON object delimiter in the changed glossary entry.

Security
Cleared: The diff is limited to a docs glossary JSON file and does not touch executable, dependency, workflow, package, or secret-handling surfaces.

Review findings

  • [P2] Close the glossary object before the next entry — docs/.i18n/glossary.zh-CN.json:896
Review details

Best possible solution:

Preserve the proposed glossary terms, add the missing object close/comma after openclaw nodes approve, and rerun focused JSON and docs i18n glossary validation before merge.

Do we have a high-confidence way to reproduce the issue?

Yes for the PR-head defect: the live PR patch shows the added openclaw nodes approve object missing its delimiter before the next glossary entry, while current main parses successfully.

Is this the best way to solve the issue?

No as submitted. The glossary file is the right source boundary for these fixed translation terms, but the JSON delimiter must be repaired before merge.

Full review comments:

  • [P2] Close the glossary object before the next entry — docs/.i18n/glossary.zh-CN.json:896
    This is still the same blocker from the previous cycle: the openclaw nodes approve entry's target line is followed by another source key without the required },, so JSON parsing and docs i18n glossary tooling cannot load the zh-CN glossary after merge.
    Confidence: 0.99

Overall correctness: patch is incorrect
Overall confidence: 0.98

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against aca96d2dcfc4.

Label changes

Label justifications:

  • P2: This is a limited docs i18n improvement with a concrete merge-blocking parse defect, not a runtime emergency.
  • merge-risk: 🚨 automation: The malformed glossary JSON can break docs i18n checks or translation automation after merge.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🌊 off-meta tidepool and patch quality is 🧂 unranked krab.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: Real behavior proof is not required because this PR only changes files under docs/.
Evidence reviewed

PR surface:

Docs +34. Total +34 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 0 0 0 0
Docs 1 34 0 +34
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 1 34 0 +34

Acceptance criteria:

  • [P1] node -e 'const fs=require("fs"); JSON.parse(fs.readFileSync("docs/.i18n/glossary.zh-CN.json","utf8")); console.log("ok")'.
  • [P1] git diff --check -- docs/.i18n/glossary.zh-CN.json.
  • [P1] pnpm docs:check-i18n-glossary.

What I checked:

Likely related people:

  • masatohoshino: Current blame on the surrounding glossary entries points to the recent commit that rewrote the checked-out glossary content, though the PR itself is a docs i18n delimiter repair. (role: recent area contributor; confidence: medium; commits: a49567cdfdb4; files: docs/.i18n/glossary.zh-CN.json, scripts/check-docs-i18n-glossary.mjs)
  • vincentkoc: Merged the recent current-main commit affecting the glossary/checker surface and authored release-stabilization history that touched the same docs i18n files. (role: recent adjacent contributor and merger; confidence: medium; commits: a49567cdfdb4, e085fa1a3ffd; files: docs/.i18n/glossary.zh-CN.json, scripts/check-docs-i18n-glossary.mjs, package.json)
  • osolmaz: Authored the docs:check-i18n-glossary checker path that parses this glossary file. (role: docs i18n guard author; confidence: medium; commits: a2080421a115; files: scripts/check-docs-i18n-glossary.mjs, package.json)
  • Peter Steinberger: Git history shows repeated docs i18n and zh-CN translation-flow work around the glossary and publish pipeline. (role: heavy docs i18n contributor; confidence: medium; commits: f2dc241e9db7, 1ad5695aa483, 98bac6a0e474; files: docs/.i18n/README.md, docs/.i18n/glossary.zh-CN.json)
  • Josh Palmer: Earlier history introduced and tuned the zh-CN docs glossary and translation pipeline assets. (role: original zh-CN glossary contributor; confidence: medium; commits: 0e0e395b9ebb, 2b1f68c92863; files: docs/.i18n/glossary.zh-CN.json)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (1 earlier review cycle)
  • reviewed 2026-07-04T01:55:46.883Z sha 93f4f1c :: needs changes before merge. :: [P2] Close the glossary object before the next entry

@openclaw-barnacle openclaw-barnacle Bot added the triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. label May 7, 2026
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. labels May 19, 2026
@clawsweeper

clawsweeper Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper PR egg

🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress.

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

  • Merged PRs are hatchable.
  • Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
  • Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.
What is this egg doing here?
  • Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
  • The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
  • Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
  • The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
  • Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

@RomneyDa

RomneyDa commented May 29, 2026

Copy link
Copy Markdown
Member

Heads up: this PR needs to be updated against current main before the new required Dependency Guard check can pass.

@openclaw-barnacle

openclaw-barnacle Bot commented Jun 13, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Jun 13, 2026
@clawsweeper clawsweeper Bot mentioned this pull request Jun 23, 2026
Closed
20 tasks
@steipete steipete self-assigned this Jul 9, 2026
@steipete
steipete force-pushed the fix/i18n-glossary-device-node-pairing branch from 93f4f1c to 44698f6 Compare July 9, 2026 15:06
@steipete steipete added the proof: override Maintainer override for the external PR real behavior proof gate. label Jul 9, 2026
@openclaw-barnacle openclaw-barnacle Bot added the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jul 9, 2026
@steipete steipete removed the proof: override Maintainer override for the external PR real behavior proof gate. label Jul 9, 2026
@openclaw-barnacle openclaw-barnacle Bot removed the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jul 9, 2026
@steipete
steipete merged commit 12ceefc into openclaw:main Jul 9, 2026
62 of 69 checks passed
@steipete

steipete commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Landed after rebasing onto current main and repairing the merge-created JSON delimiter defect.

  • Source head: zeuming@44698f6
  • Landed commit: 12ceefc
  • Local proof: JSON parse plus 359 unique source terms; pnpm docs:list; pnpm docs:check-i18n-glossary; pnpm format:docs:check (689 files); pnpm check:docs (including 5,783 internal links); git diff --check.
  • Structured review: ./.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --parallel-tests "pnpm check:docs" --stream-engine-output — clean, no accepted/actionable findings.
  • Exact-head CI: CI, Workflow Sanity, Dependency Guard, Security Sensitive Guard, and Real behavior proof all succeeded on 44698f68fc30769959891c71880adb51a361b32c.

Thanks @zeuming!

@github-actions github-actions Bot mentioned this pull request Jul 9, 2026
Open
@clawsweeper clawsweeper Bot mentioned this pull request Jul 9, 2026
Merged
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jul 10, 2026
@zeuming
fix(i18n): add device/node pairing terms to zh-CN glossary (openclaw#…
595a5dc 
…61396)

Add explicit Simplified Chinese glossary terms for the separate device- and node-pairing workflows and preserve the four CLI commands verbatim during translation.

Thanks @zeuming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steipete steipete

Labels

docs Improvements or additions to documentation merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: XS stale Marked as stale due to inactivity status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. triage: low-signal-docs Candidate: docs-only change looks low signal; maintainer review needed. triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeuming @RomneyDa @steipete @vincentkoc