Skip to content

Revert "[codex] Reproduce session stall and restart drain bugs"#61265

Merged
onutc merged 1 commit into
mainfrom
revert-61225-codex/repro-session-stall-and-drain-bugs
Apr 5, 2026
Merged

Revert "[codex] Reproduce session stall and restart drain bugs"#61265
onutc merged 1 commit into
mainfrom
revert-61225-codex/repro-session-stall-and-drain-bugs

Conversation

@onutc

@onutc onutc commented Apr 5, 2026

Copy link
Copy Markdown

Reverts #61225

@onutc
onutc merged commit d4e06d1 into main Apr 5, 2026
11 checks passed
@onutc
onutc deleted the revert-61225-codex/repro-session-stall-and-drain-bugs branch April 5, 2026 09:10
@openclaw-barnacle openclaw-barnacle Bot added size: M maintainer Maintainer-authored PR labels Apr 5, 2026
@greptile-apps

greptile-apps Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR is a pure revert of #61225, which was a codex-generated PR that added test cases to reproduce session stall and restart drain bugs. No production code is changed — only three test files are affected.

  • All three files (agent-runner-execution.test.ts, agent-runner.misc.runreplyagent.test.ts, get-reply-run.media-only.test.ts) are test-only; the revert removes test coverage that was introduced by [codex] Reproduce session stall and restart drain bugs #61225.
  • The remaining tests in each file are well-structured, with proper mock isolation, appropriate beforeEach/afterEach cleanup (vi.useRealTimers(), resetSystemEventsForTest(), clearMemoryPluginState()), and consistent use of vi.hoisted().
  • The PR description does not explain the motivation for the revert (e.g., flaky behavior, incorrect assertions, or conflicts with in-flight work). A brief rationale would help reviewers and future maintainers understand whether the removed tests should be re-landed once the underlying issues are addressed.

Confidence Score: 4/5

Safe to merge — only test files are reverted, no production code is affected.

Score is 4 rather than 5 because reverting tests explicitly written to reproduce identified bugs (session stall, restart drain) removes regression coverage without any stated justification. The remaining test suite is solid and no functional code changes are involved, but the missing rationale leaves open whether the removed tests had correctness problems or were reverted for other reasons.

No files require special attention. All changed files are test-only. The motivation for the revert is the only open question.

Reviews (1): Last reviewed commit: "Revert "[codex] Reproduce session stall ..." | Re-trigger Greptile

@vincentkoc vincentkoc self-assigned this Apr 5, 2026
lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
Nachx639 pushed a commit to Nachx639/clawdbot that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants