UI: localize Overview and login gate labels by rubensfox20 · Pull Request #61054 · openclaw/openclaw

rubensfox20 · 2026-04-04T22:30:45Z

Summary

Problem: the Overview screen still had several hardcoded English labels in buttons, placeholders, and docs-link metadata even when a non-English locale was selected.
Why it matters: users saw mixed-language UI on the first screen of the Control UI, which weakens the value of existing locale support.
What changed: moved those Overview-only hardcoded labels into locale keys and wired overview.ts to read them through t(...).
What did NOT change (scope boundary): no routing, no behavior changes, and no i18n work outside the Overview screen.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related UI: complete pt-BR control locale #61036
This PR fixes a bug or regression

Root Cause (if applicable)

Root cause: some Overview strings were still embedded directly in ui/src/ui/views/overview.ts instead of going through locale files.
Missing detection / guardrail: locale coverage exists, but there was no guardrail preventing these labels from staying hardcoded in the view.
Contributing context (if known): this PR intentionally keeps the scope to one screen so the i18n cleanup stays reviewable.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file:
- ui/src/i18n/test/translate.test.ts
Scenario the test should lock in:
- locale lookups for the newly added Overview keys resolve correctly.
Why this is the smallest reliable guardrail:
- the change is isolated to locale keys plus one Overview view.
Existing test that already covers this (if any):
- ui/src/i18n/test/translate.test.ts
If no new test is added, why not:
- existing i18n coverage plus successful UI build were sufficient for this scoped change.

User-visible / Behavior Changes

The Overview screen no longer shows those hardcoded English labels when pt-BR is selected.

Diagram (if applicable)

N/A

Security Impact (required)

New permissions/capabilities? (Yes/No): No
Secrets/tokens handling changed? (Yes/No): No
New/changed network calls? (Yes/No): No
Command/tool execution surface changed? (Yes/No): No
Data access scope changed? (Yes/No): No
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: Windows 10
Runtime/container: local Node/pnpm dev environment
Model/provider: N/A
Integration/channel (if any): Control UI Overview screen
Relevant config (redacted): N/A

Steps

Switch the Control UI locale away from English.
Open the Overview screen.
Inspect docs-link labels, token/password visibility labels, and the password placeholder.

Expected

Those Overview labels should come from locale files instead of staying hardcoded in English.

Actual

The Overview screen now uses locale-backed strings for those labels.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Validation:

pnpm --dir ui build
pnpm test ui/src/i18n/test/translate.test.ts -- --project ui

Human Verification (required)

Verified scenarios:
- reviewed the Overview diff to ensure only hardcoded labels were moved to locale keys
- confirmed local build passes
- confirmed targeted UI translation test passes
Edge cases checked:
- preserved existing docs URLs and behavior
- preserved token/password visibility behavior while localizing only labels
What you did not verify:
- full browser walkthrough of every locale on the Overview screen

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? (Yes/No): Yes
Config/env changes? (Yes/No): No
Migration needed? (Yes/No): No
If yes, exact upgrade steps:

Risks and Mitigations

Risk: other screens may still contain hardcoded strings.
- Mitigation: this PR intentionally scopes the cleanup to the Overview screen only.

greptile-apps · 2026-04-04T22:32:58Z

Greptile Summary

This PR moves hardcoded English labels from the Overview screen into locale keys and wires overview.ts to use t(...) — a clean, well-scoped i18n fix.

The auth failed branch (authHintKind === \"failed\") at lines 143–146 in ui/src/ui/views/overview.ts still renders hardcoded English strings for the docs link title and visible text, even though the corresponding overview.connection.authDocsTitle / authDocsLink keys were added to both locale files in this same PR and are correctly used in the nearby \"required\" branch.

Confidence Score: 4/5

Safe to merge after fixing the one missed hardcoded string in the auth-failed branch.

One P1 finding: the auth-failed docs link title and text remain hardcoded in English despite the matching locale keys being added in this PR and correctly used in the parallel auth-required branch, directly contradicting the PR's stated goal.

ui/src/ui/views/overview.ts — auth-failed branch (lines 143–146)

Comments Outside Diff (1)

ui/src/ui/views/overview.ts, line 143-146 (link)

Hardcoded strings survive in the auth-failed branch

The authHintKind === "failed" branch still renders hardcoded English for the docs link title and visible text, so non-English locales (including the pt-BR locale this PR targets) will always see English here. The keys overview.connection.authDocsTitle and overview.connection.authDocsLink were added to both locale files in this PR and are already used correctly in the "required" branch at lines 128–129.

Prompt To Fix With AI

This is a comment left during a code review.
Path: ui/src/ui/views/overview.ts
Line: 143-146

Comment:
**Hardcoded strings survive in the auth-failed branch**

The `authHintKind === "failed"` branch still renders hardcoded English for the docs link `title` and visible text, so non-English locales (including the pt-BR locale this PR targets) will always see English here. The keys `overview.connection.authDocsTitle` and `overview.connection.authDocsLink` were added to both locale files in this PR and are already used correctly in the `"required"` branch at lines 128–129.



How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: ui/src/ui/views/overview.ts
Line: 143-146

Comment:
**Hardcoded strings survive in the auth-failed branch**

The `authHintKind === "failed"` branch still renders hardcoded English for the docs link `title` and visible text, so non-English locales (including the pt-BR locale this PR targets) will always see English here. The keys `overview.connection.authDocsTitle` and `overview.connection.authDocsLink` were added to both locale files in this PR and are already used correctly in the `"required"` branch at lines 128–129.

```suggestion
            title=${t("overview.connection.authDocsTitle")}
            >${t("overview.connection.authDocsLink")}</a
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "UI: localize Overview hardcoded labels" | Re-trigger Greptile}

rubensfox20 · 2026-04-04T22:39:38Z

Good catch — fixed the remaining hardcoded auth-failed docs link in ui/src/ui/views/overview.ts to use the same locale keys as the required-auth branch. Revalidated with:\n\n- pnpm --dir ui build ✅\n- pnpm test ui/src/i18n/test/translate.test.ts -- --project ui ✅

Signed-off-by: sallyom <[email protected]>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c75904ade4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-20T04:54:47Z

+      showToken: "Show token",
+      hideToken: "Hide token",
+      toggleTokenVisibility: "Toggle token visibility",
+      showPassword: "Show password",
+      hidePassword: "Hide password",


Regenerate all locale outputs after adding new i18n keys

These new overview keys are only added in en.ts (and manually in pt-BR.ts), but the repo’s locale pipeline expects every shipped locale plus .i18n metadata to stay in sync with English (scripts/control-ui-i18n.ts, enforced in .github/workflows/ci.yml via pnpm ui:i18n:check). As committed, locales like de/es/fr/... are missing these keys, so the i18n drift check will fail and non-pt locales will fall back to English for the new Overview labels.

Useful? React with 👍 / 👎.

Signed-off-by: sallyom <[email protected]>

sallyom · 2026-04-20T06:37:36Z

Combined #61062 into this PR because the i18n sync is shared.

sallyom · 2026-04-20T06:46:27Z

Merged via squash.

Prepared head SHA: 807c79cc5f6a567df18c0394b5ed50c7f250c406
Merge commit: 54d7728e74b6dabfd4cb4aba1be2840704a67609

Thanks @rubensfox20!

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

@sallyom

Merged via squash. Prepared head SHA: 807c79c Co-authored-by: rubensfox20 <[email protected]> Co-authored-by: sallyom <[email protected]> Reviewed-by: @sallyom

openclaw-barnacle Bot added app: web-ui App: web-ui size: S labels Apr 4, 2026

rubensfox20 force-pushed the fix/overview-i18n-hardcoded-links branch from 2d493f6 to cc03a43 Compare April 4, 2026 22:44

rubensfox20 added 2 commits April 20, 2026 00:33

UI: localize Overview hardcoded labels

b02a7a0

Signed-off-by: sallyom <[email protected]>

UI: fix Overview auth-failed i18n link

c75904a

Signed-off-by: sallyom <[email protected]>

sallyom force-pushed the fix/overview-i18n-hardcoded-links branch from cc03a43 to c75904a Compare April 20, 2026 04:50

chatgpt-codex-connector Bot reviewed Apr 20, 2026

View reviewed changes

openclaw-barnacle Bot added size: M and removed size: S labels Apr 20, 2026

sallyom force-pushed the fix/overview-i18n-hardcoded-links branch from 64d01e5 to c75904a Compare April 20, 2026 05:50

openclaw-barnacle Bot added size: S and removed size: M labels Apr 20, 2026

sallyom added 2 commits April 20, 2026 02:27

UI: sync overview locale labels

dacc329

Signed-off-by: sallyom <[email protected]>

UI: localize login gate visibility labels

807c79c

Signed-off-by: sallyom <[email protected]>

sallyom changed the title ~~UI: localize Overview hardcoded labels~~ UI: localize Overview and login gate labels Apr 20, 2026

openclaw-barnacle Bot added size: L and removed size: S labels Apr 20, 2026

sallyom merged commit 54d7728 into openclaw:main Apr 20, 2026
50 of 51 checks passed

github-actions Bot mentioned this pull request Apr 20, 2026

📡 Upstream Digest — 2026-04-20 07:54 UTC curtismercier/openclaw-mods#622

Open

clawsweeper Bot mentioned this pull request Jun 21, 2026

[Feature]: Interface is German, I hate it. I am German. The translations will always feel akward. #90608

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

UI: localize Overview and login gate labels#61054

UI: localize Overview and login gate labels#61054
sallyom merged 4 commits into
openclaw:mainfrom
rubensfox20:fix/overview-i18n-hardcoded-links

rubensfox20 commented Apr 4, 2026

Uh oh!

greptile-apps Bot commented Apr 4, 2026 •

edited

Loading

Comments Outside Diff (1)

Uh oh!

rubensfox20 commented Apr 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Uh oh!

sallyom commented Apr 20, 2026

Uh oh!

Uh oh!

sallyom commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

rubensfox20 commented Apr 4, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Root Cause (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Risks and Mitigations

Uh oh!

greptile-apps Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

rubensfox20 commented Apr 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

sallyom commented Apr 20, 2026

Uh oh!

Uh oh!

sallyom commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Apr 4, 2026 •

edited

Loading