fix(telegram): enable voice-note transcription in DMs#61008
Conversation
Greptile SummaryThis PR fixes DM voice-note transcription that was accidentally dropped during the Confidence Score: 5/5Safe to merge — precise two-line logic change with a matching test, no regressions in existing group cases. The fix is minimal and well-targeted: it restores a documented regression, the condition restructuring is logically equivalent for groups and correct for DMs, and the new test exercises the exact broken path. All remaining findings are P2 or lower. No files require special attention. Reviews (1): Last reviewed commit: "fix(telegram): enable voice-note transcr..." | Re-trigger Greptile |
0147b8d to
59aa0a7
Compare
|
CI failures are unrelated to this change -- all stem from The |
The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from c15385f. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts.
990cc24 to
b83de68
Compare
obviyus
left a comment
There was a problem hiding this comment.
Reviewed latest changes; landing now.
|
Landed on main. Thanks @manueltarouca. |
…hanks @manueltarouca) * fix(telegram): enable voice-note transcription in DMs The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from eb56ced. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts. * fix: restore Telegram DM voice-note transcription (openclaw#61008) (thanks @manueltarouca) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…hanks @manueltarouca) * fix(telegram): enable voice-note transcription in DMs The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from a9137f9. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts. * fix: restore Telegram DM voice-note transcription (openclaw#61008) (thanks @manueltarouca) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…hanks @manueltarouca) * fix(telegram): enable voice-note transcription in DMs The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from cbe04c0. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts. * fix: restore Telegram DM voice-note transcription (openclaw#61008) (thanks @manueltarouca) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…hanks @manueltarouca) * fix(telegram): enable voice-note transcription in DMs The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from cbe04c0. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts. * fix: restore Telegram DM voice-note transcription (openclaw#61008) (thanks @manueltarouca) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…hanks @manueltarouca) * fix(telegram): enable voice-note transcription in DMs The preflight transcription condition only triggered for group chats (isGroup && requireMention), so voice notes sent in direct messages were never transcribed -- they arrived as raw <media:audio> placeholders. This regression was introduced when the Telegram channel was moved from src/telegram/ to extensions/telegram/, losing the fix from 38d8c93. Widen the condition to fire whenever there is audio and no accompanying text, regardless of chat type. Group-specific guards (requireMention, disableAudioPreflight, senderAllowedForAudioPreflight) still apply only in group contexts. * fix: restore Telegram DM voice-note transcription (openclaw#61008) (thanks @manueltarouca) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
Summary
src/telegram/toextensions/telegram/migrationisGroup && requireMention, so voice notes in direct messages were never transcribed and arrived as raw<media:audio>placeholdersrequireMention,disableAudioPreflight,senderAllowedForAudioPreflight)Original fix: c15385f, regression introduced during extension refactor.
Test plan
pnpm tsgopasses<media:audio>