Greptile Summary

This PR adds per-agent compaction configuration overrides by extracting a shared CompactionConfigSchema, adding an optional compaction field to AgentEntrySchema and AgentConfig, and wiring a resolveAgentCompaction shallow-merge through all relevant call sites (timeout, hooks, extensions, settings manager). The approach is clean and consistent with how other per-agent overrides work, but one field falls through the gap.

• reserveTokensFloor per-agent override is silently ignored: resolveCompactionReserveTokensFloor in pi-settings.ts reads directly from cfg?.agents?.defaults?.compaction?.reserveTokensFloor and accepts no agentId, so per-agent floor values are never applied even though the schema accepts them. The downstream call in applyPiCompactionSettingsFromConfig (line 81) correctly passes params.agentId to resolveEffectiveCompaction for other fields but omits it here, meaning the safety floor always comes from global defaults.

Confidence Score: 4/5

Safe to merge after fixing the reserveTokensFloor gap; all other per-agent compaction fields are correctly threaded.

One P1 defect: per-agent reserveTokensFloor is accepted by the schema but silently bypassed at runtime because resolveCompactionReserveTokensFloor does not take an agentId. The rest of the PR — shallow merge, timeout, mode/safeguard, postIndexSync, hooks, settings manager threading — is implemented correctly and consistently.

src/agents/pi-settings.ts — resolveCompactionReserveTokensFloor needs an agentId parameter and should delegate to resolveAgentCompaction rather than reading agents.defaults directly.

This is a comment left during a code review.
Path: src/agents/pi-settings.ts
Line: 37-43

Comment:
**Per-agent `reserveTokensFloor` silently ignored**

`resolveCompactionReserveTokensFloor` reads directly from `cfg?.agents?.defaults?.compaction?.reserveTokensFloor` and has no `agentId` parameter, so any per-agent `compaction.reserveTokensFloor` override is silently discarded. The caller in `applyPiCompactionSettingsFromConfig` passes `params.agentId` to `resolveEffectiveCompaction` (for `reserveTokens` and `keepRecentTokens`) but calls this function without the agent id, so the safety floor is always resolved from global defaults — defeating per-agent floor configuration even though the schema accepts it.

```ts
export function resolveCompactionReserveTokensFloor(cfg?: OpenClawConfig, agentId?: string): number {
  const compaction = agentId ? resolveAgentCompaction(cfg, agentId) : cfg?.agents?.defaults?.compaction;
  const raw = compaction?.reserveTokensFloor;
  if (typeof raw === "number" && Number.isFinite(raw) && raw >= 0) {
    return Math.floor(raw);
  }
  return DEFAULT_PI_COMPACTION_RESERVE_TOKENS_FLOOR;
}
```

And update the call site at line 81:

```ts
const reserveTokensFloor = resolveCompactionReserveTokensFloor(params.cfg, params.agentId);
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat: per-agent compaction configuration..." | Re-trigger Greptile}

Codex P1 Review — Addressed in 8aa3a2a

P1: Agent ID normalization ✅
resolveAgentCompaction now normalizes both the lookup ID and config entry IDs via normalizeAgentId() before comparison, ensuring case-insensitive matching (e.g., Main-Agent vs main-agent).

P1: Consistent compaction timeout in attempt.ts ✅
Both resolveCompactionTimeoutMs calls in run/attempt.ts (lines 693 and 1293) now pass sessionAgentId, ensuring the session lock budget and abort/grace timer use the same agent-specific timeout value.

Closing this as duplicate or superseded after Codex automated review.

Close #60807 as superseded by the newer active PR #69988. Current main still does not implement per-agent compaction overrides, but #69988 is now the canonical open implementation path for the same core config/runtime feature. #60807 is older, unmerged, based on an older main, and includes unrelated doctor/watch, agent-step, and cron test-harness changes alongside the compaction work.

Best possible solution:

Close #60807 as superseded by #69988. Keep the canonical per-agent compaction work concentrated in #69988 and land a focused implementation that adds agents.list[].compaction, merges it over agents.defaults.compaction, threads agent identity through Pi compaction/runtime/hook paths, updates generated schema/help/docs, and includes targeted config/runtime tests. Preserve the useful #57174 context and #60807 review findings, but avoid carrying the unrelated doctor/watch, agent-step, and cron test-harness changes from this older branch.

What I checked:

• Current main rejects per-agent compaction config: AgentEntrySchema is a strict per-agent schema and currently lists fields such as model, memorySearch, tts, contextLimits, heartbeat, identity, groupChat, and subagents, but no compaction field. That means agents.list[].compaction is not accepted on current main. (src/config/zod-schema.agent-runtime.ts:822, e29d3516bf05)
• Current type surface lacks AgentConfig.compaction: AgentConfig exposes per-agent overrides for model, skills, memorySearch, tts, contextLimits, heartbeat, sandbox, params, tools, and runtime, but no compaction property. (src/config/types.agents.ts:76, e29d3516bf05)
• Runtime still resolves defaults-only compaction: applyPiCompactionSettingsFromConfig reads params.cfg?.agents?.defaults?.compaction, and resolveCompactionReserveTokensFloor reads cfg?.agents?.defaults?.compaction?.reserveTokensFloor; neither accepts or resolves an agent id on current main. (src/agents/pi-settings.ts:43, e29d3516bf05)
• Other compaction runtime paths are also defaults-only: The embedded extension setup resolves compaction mode and safeguard config from cfg?.agents?.defaults?.compaction; post-compaction index sync and timeout resolution likewise read only defaults. (src/agents/pi-embedded-runner/extensions.ts:131, e29d3516bf05)
• Docs only document defaults compaction: The public agent config docs section is agents.defaults.compaction; I found no docs entry for agents.list[].compaction on current main. Public docs: docs/gateway/config-agents.md. (docs/gateway/config-agents.md:540, e29d3516bf05)
• Newer canonical PR tracks the same work: PR feat(config): support per-agent compaction overrides #69988, feat(config): support per-agent compaction overrides, is open and unmerged. Its body says it adds optional agents.list[].compaction, merges it over defaults, and threads effective per-agent compaction through embedded runtime paths. Its file list includes schema/types, agent-scope-config, pi-settings, embedded runner wiring, generated schema, and targeted tests. (eadf56e7c978)

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against e29d3516bf05.

Acknowledged — the assessment is fair. #60807 did pick up some unrelated doctor/watch and cron test-harness changes from an older branch state, and #69988 is a cleaner focused implementation of the same agents.list[].compaction feature.

Closing was the right call. I'll move support and any production validation context over to #69988.