docs: correct overstated prompt-cache comments from #58036 #58037 #58038#60633
Merged
Conversation
Contributor
Greptile SummaryThis is a comment-only cleanup PR that corrects overstatements about prompt-cache benefits introduced in #58036, #58037, and #58038 across four files. No behavior is changed.
Confidence Score: 5/5Safe to merge — comment-only changes with no behavior impact and all corrections are factually accurate. All four changed files receive comment-only edits. The technical claims in the revised comments are accurate: compacting newest-first preserves more (not all) of the cached prefix; sort order cannot retroactively fix iteration-order-dependent collision suffixes; and prefix stability has an additional dependency on replay-sanitizer idempotency. No logic, types, or tests are touched. No files require special attention. Reviews (1): Last reviewed commit: "docs: restore purpose context in MCP too..." | Re-trigger Greptile |
MonkeyLeeT
force-pushed
the
docs/fix-cache-pr-comments
branch
from
April 4, 2026 01:46
951b236 to
9ea6254
Compare
MonkeyLeeT
force-pushed
the
docs/fix-cache-pr-comments
branch
from
April 4, 2026 23:27
15ddf1e to
96d4076
Compare
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…enclaw#58037 openclaw#58038 (openclaw#60633) * docs: correct overstated prompt-cache comments from openclaw#58036 openclaw#58037 openclaw#58038 * docs: restore purpose context in MCP tool sort comment * docs: drop misleading 'legacy' framing from image-prune comments * docs: restore useful context stripped from image-prune comments * docs: restore 'deterministically' in MCP tool sort comment * docs: restore 'idempotent' at attempt.ts callsite * docs: restore 'provider prompt cache' in context-guard comment
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
…enclaw#58037 openclaw#58038 (openclaw#60633) * docs: correct overstated prompt-cache comments from openclaw#58036 openclaw#58037 openclaw#58038 * docs: restore purpose context in MCP tool sort comment * docs: drop misleading 'legacy' framing from image-prune comments * docs: restore useful context stripped from image-prune comments * docs: restore 'deterministically' in MCP tool sort comment * docs: restore 'idempotent' at attempt.ts callsite * docs: restore 'provider prompt cache' in context-guard comment
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…enclaw#58037 openclaw#58038 (openclaw#60633) * docs: correct overstated prompt-cache comments from openclaw#58036 openclaw#58037 openclaw#58038 * docs: restore purpose context in MCP tool sort comment * docs: drop misleading 'legacy' framing from image-prune comments * docs: restore useful context stripped from image-prune comments * docs: restore 'deterministically' in MCP tool sort comment * docs: restore 'idempotent' at attempt.ts callsite * docs: restore 'provider prompt cache' in context-guard comment
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
…enclaw#58037 openclaw#58038 (openclaw#60633) * docs: correct overstated prompt-cache comments from openclaw#58036 openclaw#58037 openclaw#58038 * docs: restore purpose context in MCP tool sort comment * docs: drop misleading 'legacy' framing from image-prune comments * docs: restore useful context stripped from image-prune comments * docs: restore 'deterministically' in MCP tool sort comment * docs: restore 'idempotent' at attempt.ts callsite * docs: restore 'provider prompt cache' in context-guard comment
Nachx639
pushed a commit
to Nachx639/clawdbot
that referenced
this pull request
Jun 17, 2026
…enclaw#58037 openclaw#58038 (openclaw#60633) * docs: correct overstated prompt-cache comments from openclaw#58036 openclaw#58037 openclaw#58038 * docs: restore purpose context in MCP tool sort comment * docs: drop misleading 'legacy' framing from image-prune comments * docs: restore useful context stripped from image-prune comments * docs: restore 'deterministically' in MCP tool sort comment * docs: restore 'idempotent' at attempt.ts callsite * docs: restore 'provider prompt cache' in context-guard comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct comments that overstated the prompt-cache benefits of #58036, #58037, and #58038. No behavior changes — only comments.
tool-result-context-guard.ts: "prefix stays intact" → "more of the prefix survives"; note the model-quality tradeoff (loses recent tool output instead of old).pi-bundle-mcp-materialize.ts: add "usually stable but not guaranteed" context; note that collision suffixes are iteration-order-dependent and the sort cannot fix name collisions.history-image-prune.ts: drop misleading "legacy sessions" framing (this runs on all sessions); replace overstated "byte-identical" cache claim with accurate "reduces churn" + note dependency on replay sanitizer idempotency; document that text-only turns consume the window; fix "user turns" → "user/toolResult turns".attempt.ts: matching callsite comment update.Test plan
pnpm checkpasses.🤖 Generated with Claude Code