Skip to content

Fix model fallback error message handling#604

Merged
steipete merged 2 commits intomainfrom
fix/model-fallback-error-message
Jan 9, 2026
Merged

Fix model fallback error message handling#604
steipete merged 2 commits intomainfrom
fix/model-fallback-error-message

Conversation

@steipete
Copy link
Copy Markdown
Contributor

@steipete steipete commented Jan 9, 2026

  • Avoid base-to-string lint by narrowing error types.\n\nTests: pnpm lint && pnpm build && pnpm test

@cursor
Copy link
Copy Markdown

cursor bot commented Jan 9, 2026

PR Summary

Improves error extraction used by model fallback decisions to prevent misleading stringification of non-string errors.

  • Refactors getErrorMessage to handle Error, strings, primitives, symbols, and object.message, otherwise return empty string (no implicit String(err))
  • Updates CHANGELOG.md with the agents note for this fix

Written by Cursor Bugbot for commit 9ecef09. This will update automatically on new commits. Configure here.

@steipete steipete merged commit 0a4cb0d into main Jan 9, 2026
35 of 36 checks passed
@steipete steipete deleted the fix/model-fallback-error-message branch January 9, 2026 19:24
@steipete
Copy link
Copy Markdown
Contributor Author

steipete commented Jan 9, 2026

Landed via merge.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Commits: 6481806, 9ecef09\n- Merge commit: 0a4cb0d\n\nThanks @steipete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant