fix(channels): emit passive hooks for mention-skipped group messages#60018
fix(channels): emit passive hooks for mention-skipped group messages#60018
Conversation
Greptile SummaryThis PR adds passive
Confidence Score: 3/5Mostly safe, but the Signal ingest precedence bug means a group-specific The Telegram and schema changes are clean. The Signal implementation has a logic bug in how group-specific vs. wildcard config precedence is handled — it uses extensions/signal/src/monitor/event-handler.ts — the ingest condition on lines 733-736 needs the Prompt To Fix All With AIThis is a comment left during a code review.
Path: extensions/signal/src/monitor/event-handler.ts
Line: 733-736
Comment:
**Group-specific `ingest: false` cannot override wildcard `ingest: true`**
The `||` condition means: if the specific group has `ingest: false` but the wildcard `*` entry has `ingest: true`, the hook still fires — the group-specific opt-out is silently ignored.
For example:
```yaml
channels:
signal:
groups:
"group-abc":
requireMention: true
ingest: false # explicit opt-out for this group
"*":
requireMention: true
ingest: true # default for other groups
```
With the current code `false === true || true === true` evaluates to `true` and the hook fires for `group-abc`.
The Telegram counterpart correctly uses `??` (nullish-coalescing) to give the specific group config priority over the wildcard, and `resolveChannelGroupRequireMention` in `group-policy.ts` applies the same precedence rule for `requireMention`. The ingest flag should follow the same pattern:
```suggestion
if (
(signalGroupPolicy.groupConfig?.ingest ?? signalGroupPolicy.defaultConfig?.ingest) === true
) {
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: extensions/telegram/src/bot-message-context.silent-ingest.test.ts
Line: 51-53
Comment:
**Test model constant doesn't match project preference**
The project guidelines (CLAUDE.md) ask to prefer `sonnet-4.6` for example Anthropic model constants in tests. This placeholder uses `anthropic/claude-opus-4-5`.
```suggestion
model: "anthropic/sonnet-4.6",
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(channels): emit passive hooks for me..." | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 150151dead
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 346634ca90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1df588d to
69571b6
Compare
* fix(channels): emit passive hooks for mention-skipped group messages * fix(channels): honor signal ingest overrides * fix(channels): honor telegram ingest fallback * fix: emit passive hooks for mention-skipped group messages (#60018)
…60018) * fix(channels): emit passive hooks for mention-skipped group messages * fix(channels): honor signal ingest overrides * fix(channels): honor telegram ingest fallback * fix: emit passive hooks for mention-skipped group messages (openclaw#60018)
Summary
Testing