fix: add enabledByDefault to groq and deepgram media plugin manifests#59982
Conversation
Greptile SummaryAdds Confidence Score: 5/5This PR is safe to merge — it is a two-line targeted manifest fix with no logic changes. The change is minimal (one field added to two JSON manifests), matches the established pattern used by all other bundled provider plugins, and directly addresses the documented failure path in config-state.ts. No logic, interface, or schema changes were introduced. No files require special attention. Reviews (1): Last reviewed commit: "fix: add enabledByDefault to groq and de..." | Re-trigger Greptile |
|
Hey @vincentkoc — this is a small 2-line fix for the Groq/Deepgram STT regression (#59875). Both plugin manifests were missing All tests pass (1213 plugin + 117 media-understanding). Would appreciate a review when you have a moment! |
|
Hi @vincentkoc — gentle ping on this one when you have a moment! 🙏 All CI checks are green and Greptile reviewed it at 5/5 confidence (safe to merge). It's a two-line targeted fix for the Groq/Deepgram bundled plugin regression (#59875) — no logic changes, just adding the missing Would really appreciate a quick review! |
The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875
d2b2bd8 to
e96121f
Compare
obviyus
left a comment
There was a problem hiding this comment.
Reviewed latest changes; landing now.
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
…nclaw#59982) (thanks @yxjsxy) * fix: add enabledByDefault to groq and deepgram media plugin manifests The groq and deepgram plugin manifests were missing the enabledByDefault: true flag. Without this flag, both plugins are treated as bundled-but-disabled-by-default, so resolveRuntimePluginRegistry loads without them. When buildProviderRegistry later needs to resolve audio providers, the active registry is used first (short-circuits the compat path in resolvePluginCapabilityProviders), leaving groq and deepgram absent from the registry. This caused 'Media provider not available: groq' errors when users configured tools.media.audio.models with groq or deepgram, even with GROQ_API_KEY / DEEPGRAM_API_KEY set correctly. The fix mirrors the pattern used by other audio/media-only providers such as mistral, which already has enabledByDefault: true. Fixes openclaw#59875 * fix: enable groq and deepgram bundled media providers by default (openclaw#59982) (thanks @yxjsxy) --------- Co-authored-by: Ayaan Zaidi <[email protected]>
Problem
The
groqanddeepgramplugin manifests were missing"enabledByDefault": true. Without this flag, both plugins are treated as bundled-but-disabled-by-default during gateway startup.resolveRuntimePluginRegistry()loads without them. WhenbuildProviderRegistrylater needs to resolve audio providers,resolvePluginCapabilityProvidersshort-circuits to the active registry (skipping the compat path), so groq and deepgram are absent from the registry.This caused the error in #59875:
Even with
GROQ_API_KEY/DEEPGRAM_API_KEYcorrectly configured, the plugin never loaded.Root cause
resolvePluginActivationStateinsrc/plugins/config-state.tsreaches this branch for groq/deepgram:Because
params.enabledByDefaultisundefined(missing from manifest).Fix
Add
"enabledByDefault": trueto bothextensions/groq/openclaw.plugin.jsonandextensions/deepgram/openclaw.plugin.json, matching the pattern used bymistraland other audio/media providers.Testing
pnpm exec vitest run src/plugins/)pnpm exec vitest run src/media-understanding/)Fixes #59875