[codex] improve parallels windows smoke logging#59705
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Windows helper phases could be healthy while the outer wrapper showed only
waiting for first log line, and a transport flake before guest files materialized produced weak diagnostics.Impact
Parallels smoke runs are easier to monitor and earlier Windows helper failures are easier to diagnose without changing the happy-path test flow.
Root cause
The wrapper only drained guest helper logs after completion or timeout, and the initial
prlctl execlauncher path was not retried or surfaced clearly in the outer log.Validation
bash -n scripts/e2e/parallels-npm-update-smoke.shbash -n scripts/e2e/parallels-windows-smoke.shpnpm test:parallels:npm-update -- --json