🔒 Aisle Security Analysis

We found 1 potential security issue(s) in this PR:

const QUICK_TAG_RE = /<\s*\/?\s*(?:(?:antml:)?(?:think(?:ing)?|thought)|antthinking|final)\b/i;
const FINAL_TAG_RE = /<\s*\/?\s*final\b[^<>]*>/gi;

const QUICK_TAG_RE =
  ​/<\s*\/?\s*(?:(?:antml:)?(?:think(?:ing)?|thought|final)|antthinking)\b/i;

const FINAL_TAG_RE = /<\s*\/?\s*(?:antml:)?final\b[^<>]*>/gi;

Analyzed PR: #59550 at commit b554177

_{Last updated on: 2026-04-02T09:04:03Z}

Landed in c27b45f

Greptile Summary

This PR extends the shared reasoning-tag sanitizer to recognise Anthropic's namespace-prefixed antml:thinking (and related antml:think / antml:thought) variants, preventing those internal-monologue tags from leaking into user-visible replies. The regex changes are minimal and targeted, and matching test coverage is added in both reasoning-tags.test.ts and pi-embedded-utils.test.ts. The CHANGELOG.md change also cleans up leftover git conflict markers from a previous merge that had landed unresolved conflict lines in the file (the Exec approvals/config entry removed from the conflict region is already present earlier in the file at line 30, so no changelog content is lost).

Key changes:

• QUICK_TAG_RE and THINKING_TAG_RE are updated with an optional (?:antml:)? prefix so <thinking>, <think>, and <thought> are stripped alongside their non-namespaced counterparts
• New test cases in the shared sanitizer suite and the embedded-utils suite exercise the new tag shape
• Merge conflict artefacts in CHANGELOG.md are removed; the displaced duplicate changelog entry was already present in the ## Unreleased section

Confidence Score: 5/5

• Safe to merge — the change is a narrow, well-tested regex extension with no impact on existing behaviour
• The regex modification is correct: \b is placed after the full tag-name group (including the optional antml: prefix), so word-boundary detection remains accurate. Closing tags are captured correctly via match[1]. The QUICK_TAG_RE fast-path correctly detects namespaced tags so the heavier THINKING_TAG_RE only runs when needed. All removed CHANGELOG content is either duplicate or unwanted conflict-marker noise. The only minor note is that final is not given the same antml: treatment, but no such tag is known to be emitted today.
• No files require special attention

This is a comment left during a code review.
Path: src/shared/text/reasoning-tags.ts
Line: 5-8

Comment:
**`final` tag missing `antml:` variant in `THINKING_TAG_RE`**

`QUICK_TAG_RE` still includes `final` in its optional-namespace group, but `THINKING_TAG_RE` (and `FINAL_TAG_RE`) do not have a corresponding `antml:final` variant. If Anthropic ever emits `<final>…</final>`, `QUICK_TAG_RE` would fire but `FINAL_TAG_RE` and `THINKING_TAG_RE` would both miss it, and the tag would leak through. This is a minor consistency nit rather than a current crash, but worth noting if the same namespace treatment needs to be applied uniformly.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: strip antml thinking tags (#59550)" | Re-trigger Greptile}