Greptile Summary

This PR improves memory_search error messaging by adding a specific detection path for node:sqlite availability failures, producing an actionable message that points users to the Node.js version requirement and openclaw doctor --memory. The production code change in tools.shared.ts is clean and correct.

However, the accompanying test in tools.test.ts has a structural defect: the new it block was appended after the closing }); of the describe block, placing it at the top level of the file. This means the beforeEach fixture reset (resetMemoryToolMockState) will not execute before the test, which can cause state leakage and potentially flaky behaviour. The test needs to be moved inside the describe block.

Confidence Score: 3/5

• Safe to merge after fixing the test placement bug — the production code change is correct but the new test won't run with proper fixture setup as-is.
• The tools.shared.ts change is straightforward and correct. The score is reduced because the new test in tools.test.ts is placed outside the describe block, meaning it runs without the beforeEach reset. This is a real structural defect that makes the test suite unreliable for this case.
• extensions/memory-core/src/tools.test.ts — the new it block must be moved inside the describe block.

This is a comment left during a code review.
Path: extensions/memory-core/src/tools.test.ts
Line: 45-63

Comment:
**New test placed outside `describe` block — `beforeEach` reset won't run**

The new `it` block (lines 45–62) is placed after the closing `});` of the `describe("memory_search unavailable payloads")` block on line 43. This means:

1. The `beforeEach(() => resetMemoryToolMockState(...))` hook **will not** execute before this test, so any state left over from a prior test run could leak into it.
2. The test is effectively a dangling top-level `it`, which is visually misleading given its indentation.

Move the test inside the `describe` block to ensure proper fixture setup:

```suggestion
describe("memory_search unavailable payloads", () => {
  beforeEach(() => {
    resetMemoryToolMockState({ searchImpl: async () => [] });
  });

  it("returns explicit unavailable metadata for quota failures", async () => {
    // … existing test …
  });

  it("returns explicit unavailable metadata for non-quota failures", async () => {
    // … existing test …
  });

  it("returns actionable error for node:sqlite missing (runtime compatibility)", async () => {
    setMemorySearchImpl(async () => {
      throw new Error(
        "SQLite support is unavailable in this Node runtime (missing node:sqlite). No such built-in module: node:sqlite",
      );
    });

    const tool = createMemorySearchToolOrThrow();
    const result = await tool.execute("sqlite", { query: "hello" });
    expectUnavailableMemorySearchDetails(result.details, {
      error: "SQLite support is unavailable in this Node runtime (missing node:sqlite). No such built-in module: node:sqlite",
      warning:
        "Memory search is unavailable because node:sqlite is not available in this Node.js runtime.",
      action:
        "node:sqlite requires Node.js 22.5+ compiled with SQLite support. " +
        "Check your Node.js build or run: openclaw doctor --memory to see remediation options.",
    });
  });
});
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(memory): improve error message when ..." | Re-trigger Greptile}

CI Failures Note

The failing checks in this PR (checks-node-test-4, checks-windows-node-test-1, checks-windows-node-test-2) are pre-existing failures on main — they fail on the base branch itself and are unrelated to the changes in this PR.

• checks-node-test-4: model-overrides.test.ts / Feishu channel model override test fails on main (verified via main branch CI)
• checks-windows-node-test-1/2: Windows path separator flake in browser-maintenance.test.ts

No regressions were introduced by this PR.

Addressed all review feedback in latest commits:

• e6c8979: Changed openclaw doctor --memory to openclaw doctor in the actionable error message (tools.shared.ts). The --memory flag does not exist and would cause a confusing "unknown option" error for users following the remediation guidance.
• 6d45807: Moved the new it block inside the describe("memory_search unavailable payloads") block so that beforeEach fixture resets run correctly. Also updated the expected action string in the test to match the corrected message.

All bot review comments have been resolved.

Relationship with PR #59637

PR #59637 addresses the same issue (#59457) with a more focused change (only adds the isSqliteMissing detection branch, +18/−6 lines). This PR additionally fixes quota error detection (insufficient_quota path), which is not covered by #59637.

Suggested merge strategy for maintainers:

1. Merge fix(memory): improve error message when node:sqlite is unavailable #59637 first (minimal, focused sqlite fix)
2. Consider this PR (fix(cli): improve memory_search error message with actionable guidance #59488) for the quota error improvement as a follow-up, or I can split the quota-only change into a separate PR after fix(memory): improve error message when node:sqlite is unavailable #59637 lands.

I will rebase this PR on top of #59637 once it is merged to avoid conflicts.

CI failures are pre-existing and unrelated to this PR.

All failing checks fail on the same pre-existing test in src/channels/model-overrides.test.ts (keeps bundled Feishu parent fallback matching before registry bootstrap). This failure exists on the PR base commit and is not introduced by the changes in this PR.

Closing in favour of #59637 which addresses the same issue (#59457) with a cleaner scope and no outstanding review issues. The it block placement bug and incorrect openclaw doctor --memory action text in this PR were not fixed; #59637 does not have these problems.