fix: clarify --tz help text to mention --at support (#59456) by lawrence3699 · Pull Request #59480 · openclaw/openclaw

lawrence3699 · 2026-04-02T06:06:33Z

Summary

The --tz help text in both openclaw cron add and openclaw cron edit says "Timezone for cron expressions" — implying it only applies to --cron. Updated to "Timezone for cron and --at expressions" so users know --tz also applies to --at datetime strings.

Fixes #59456

🤖 AI-assisted (Claude Code). I understand what the code does.

Changes

File	Change
`src/cli/cron-cli/register.cron-add.ts`	`"Timezone for cron expressions (IANA)"` → `"Timezone for cron and --at expressions (IANA)"`
`src/cli/cron-cli/register.cron-edit.ts`	Same

Test plan

Run openclaw cron add --help and verify updated help text
Run openclaw cron edit --help and verify updated help text

greptile-apps · 2026-04-02T06:08:22Z

Greptile Summary

This PR updates the --tz flag help text in openclaw cron add and openclaw cron edit to clarify it applies to both --cron and --at expressions. The change is correct and matches the actual runtime behavior.

However, the PR also bundles unrelated changes to extensions/memory-core/src/tools.shared.ts and its test file that are not mentioned in the PR title, description, or changelog table. Those changes add a new isSqliteError detection path (regex: /node:sqlite|missing.*sqlite|sqlite.*unavailable/) to buildMemorySearchUnavailableResult, giving users a specific, actionable message when node:sqlite is unavailable instead of the generic embedding-provider error. The logic and test coverage for this new branch look correct.

Key points:

The --tz help text fix is a trivial, accurate one-liner in two files.
The memory-core error-handling improvement is small, well-tested, and logically sound — but it belongs in a separate PR or at least should be called out in the description.
The lowerReason extraction is a minor cleanup that avoids calling .toLowerCase() twice.
Priority ordering in the if-else chain (isQuotaError checked before isSqliteError) is correct; a message containing both "quota" and "sqlite" will resolve to the quota path.

Confidence Score: 4/5

Safe to merge — all code changes are correct and well-tested; the only concern is that the memory-core changes are undocumented in the PR description.
Both sets of changes are small and low-risk. The cron help-text edits are trivially correct. The memory-core addition is backed by a dedicated test that passes against the exact regex. No existing behavior is altered; only a new else-if branch is added. Score is 4 rather than 5 solely because the PR bundles unrelated, undescribed changes, making the review surface slightly larger than advertised.
extensions/memory-core/src/tools.shared.ts — contains changes not mentioned in the PR description.

_{Reviews (1): Last reviewed commit: "fix: clarify --tz help text to mention -..." | Re-trigger Greptile}

Copilot

Pull request overview

This PR updates CLI help text for the --tz option to clarify that it applies to both cron schedules and --at one-shot schedules, and also improves the memory_search tool’s “unavailable” payload to provide more actionable guidance when node:sqlite is missing.

Changes:

Update openclaw cron add/edit --tz help text to mention --at usage.
Classify missing node:sqlite failures in memory_search and return a targeted warning/action.
Add a unit test covering the new node:sqlite-missing unavailable payload.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/cli/cron-cli/register.cron-add.ts	Adjusts `--tz` help text to mention `--at` schedules.
src/cli/cron-cli/register.cron-edit.ts	Adjusts `--tz` help text to mention `--at` schedules (and sits next to `--at` help).
extensions/memory-core/src/tools.shared.ts	Adds `node:sqlite`-missing detection and specialized unavailable warning/action messaging.
extensions/memory-core/src/tools.test.ts	Adds a test asserting the new `node:sqlite`-missing unavailable metadata.

Copilot · 2026-04-02T06:09:43Z

 export function buildMemorySearchUnavailableResult(error: string | undefined) {
  const reason = (error ?? "memory search unavailable").trim() || "memory search unavailable";
-  const isQuotaError = /insufficient_quota|quota|429/.test(reason.toLowerCase());
-  const warning = isQuotaError
-    ? "Memory search is unavailable because the embedding provider quota is exhausted."
-    : "Memory search is unavailable due to an embedding/provider error.";
-  const action = isQuotaError
-    ? "Top up or switch embedding provider, then retry memory_search."
-    : "Check embedding provider configuration and retry memory_search.";
+  const lowerReason = reason.toLowerCase();
+  const isQuotaError = /insufficient_quota|quota|429/.test(lowerReason);
+  const isSqliteError = /node:sqlite|missing.*sqlite|sqlite.*unavailable/.test(lowerReason);
+
+  let warning: string;
+  let action: string;
+  if (isQuotaError) {
+    warning = "Memory search is unavailable because the embedding provider quota is exhausted.";
+    action = "Top up or switch embedding provider, then retry memory_search.";
+  } else if (isSqliteError) {
+    warning = "Memory search is unavailable because the Node.js runtime is missing node:sqlite support.";
+    action = "Upgrade to Node.js 22.5.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";
+  } else {
+    warning = "Memory search is unavailable due to an embedding/provider error.";
+    action = "Check embedding provider configuration and retry memory_search.";
+  }


The PR title/description focus on --tz CLI help text, but this hunk also changes memory_search unavailable-result behavior for missing node:sqlite (and adds tests). Please update the PR description/title to reflect this additional scope, or split the memory-core change into a separate PR for easier review/revertability.

Copilot · 2026-04-02T06:09:43Z

+    action = "Top up or switch embedding provider, then retry memory_search.";
+  } else if (isSqliteError) {
+    warning = "Memory search is unavailable because the Node.js runtime is missing node:sqlite support.";
+    action = "Upgrade to Node.js 22.5.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";


The suggested remediation says to "Upgrade to Node.js 22.5.0+", but this repo declares engines.node >=22.14.0 (package.json). Recommending a lower version is confusing; consider aligning the message with the supported minimum (or phrasing it without a specific version) and update the corresponding test expectation.

Suggested change

action = "Upgrade to Node.js 22.5.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";

action = "Upgrade to Node.js 22.14.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";

Copilot · 2026-04-02T06:09:43Z

@@ -42,7 +42,7 @@ export function registerCronEditCommand(cron: Command) {
      .option("--at <when>", "Set one-shot time (ISO) or duration like 20m")


cron add's --at help text explicitly hints that --tz is used for offset-less datetimes, but cron edit's --at help does not. Since --tz now claims to apply to --at, consider updating the --at help here as well for consistent discoverability.

Suggested change

.option("--at <when>", "Set one-shot time (ISO) or duration like 20m")

.option(

"--at <when>",

"Set one-shot time (ISO, offset-less uses --tz) or duration like 20m",

)

The --tz help text said 'Timezone for cron expressions' implying it only applies to --cron. Updated to mention --at too. Closes openclaw#59456

prtags · 2026-04-23T18:43:48Z

Related work from PRtags group tidy-squirrel-pxzl

Title: Open PR duplicate: cron --tz help text clarification for offset-less --at

Number	Title
#59480*	fix: clarify --tz help text to mention --at support (#59456)
#59487	fix(cli): clarify --tz help text to cover --at time-only format
#69975	fix(cli): clarify --tz help text for offset-less --at values

* This PR

Copilot AI review requested due to automatic review settings April 2, 2026 06:06

openclaw-barnacle Bot added extensions: memory-core Extension: memory-core cli CLI command changes size: XS labels Apr 2, 2026

Copilot started reviewing on behalf of lawrence3699 April 2, 2026 06:07 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

fix: clarify --tz help text to mention --at support (openclaw#59456)

8ba618b

The --tz help text said 'Timezone for cron expressions' implying it only applies to --cron. Updated to mention --at too. Closes openclaw#59456

lawrence3699 force-pushed the fix/59456-tz-help-text branch from 4a0cf27 to 8ba618b Compare April 2, 2026 06:50

openclaw-barnacle Bot removed the extensions: memory-core Extension: memory-core label Apr 2, 2026

rrrrrredy mentioned this pull request Apr 2, 2026

fix(cli): clarify --tz help text to cover --at time-only format #59487

Closed

21 tasks

lawrence3699 closed this Apr 3, 2026

lawrence3699 deleted the fix/59456-tz-help-text branch April 3, 2026 22:51

prtags Bot mentioned this pull request Apr 23, 2026

fix(cli): clarify --tz help text for offset-less --at values #69975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: clarify --tz help text to mention --at support (#59456)#59480

fix: clarify --tz help text to mention --at support (#59456)#59480
lawrence3699 wants to merge 1 commit into
openclaw:mainfrom
lawrence3699:fix/59456-tz-help-text

lawrence3699 commented Apr 2, 2026

Uh oh!

greptile-apps Bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

prtags Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	action = "Upgrade to Node.js 22.5.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";
	action = "Upgrade to Node.js 22.14.0+ (which includes node:sqlite) or use a Node build with SQLite enabled, then restart OpenClaw.";

		@@ -42,7 +42,7 @@ export function registerCronEditCommand(cron: Command) {
		.option("--at <when>", "Set one-shot time (ISO) or duration like 20m")

Uh oh!

Uh oh!

Conversation

lawrence3699 commented Apr 2, 2026

Summary

Changes

Test plan

Uh oh!

greptile-apps Bot commented Apr 2, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

prtags Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants