fix(providers): centralize media request shaping#59469
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ada6567c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Greptile SummaryThis PR centralizes media/audio/image/video HTTP request shaping across OpenAI-compatible audio, Deepgram, Gemini, and Moonshot providers by introducing Key changes:
Confidence Score: 5/5
Reviews (2): Last reviewed commit: "fix(google): preserve private network gu..." | Re-trigger Greptile |
|
@greptileai review |
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
* fix(providers): centralize media request shaping * style(providers): normalize shared request imports * fix(changelog): add media request shaping entry * fix(google): preserve private network guard
Summary
baseUrl, private-network allowance, default auth headers, and attribution/header precedence independently.resolveProviderHttpRequestConfigto the provider HTTP seam and migrated OpenAI-compatible audio, Deepgram audio, Gemini media-understanding, Gemini image generation, and Moonshot video to use it.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
git blame, prior PR, issue, or refactor if known): this is the next phase after refactor(providers): add internal request config seam #59454, which introduced the internal request-config seam for model resolution.Regression Test Plan (if applicable)
src/media-understanding/shared.test.tsplus existing provider tests for OpenAI audio, Deepgram, Moonshot, and Gemini media/image paths.User-visible / Behavior Changes
baseUrlhandling through one path instead of per-provider merge logic.Diagram (if applicable)
Security Impact (required)
Yes, explain risk + mitigation:Repro + Verification
Environment
baseUrlin scoped testsSteps
Expected
Actual
Evidence
Human Verification (required)
pnpm testand live provider credentials.Review Conversations
Compatibility / Migration
Risks and Mitigations
openclaw/plugin-sdk/provider-http, so future changes to it become SDK-surface changes.