feat(embeddings): add VoyageAI voyage-4 family embedding support#5747
feat(embeddings): add VoyageAI voyage-4 family embedding support#5747fzowl wants to merge 4 commits intoopenclaw:mainfrom
Conversation
openclaw-barnacle
bot
added
docs
Add native VoyageAI embedding provider with voyage-4 family models: - voyage-4: General purpose, 1024 dimensions (default) - voyage-4-lite: Cost-optimized, highest throughput - voyage-4-large: Best quality for demanding retrieval tasks Changes: - Add voyageai SDK dependency - Create embeddings-voyageai.ts provider using official VoyageAI SDK - Register voyageai in embedding provider factory with auto-detection - Add voyage-4 models to EMBEDDING_DIMENSIONS registry - Add voyage-4 models to plugin JSON schema enum - Update memory manager to support voyageai provider type - Add unit tests for VoyageAI provider - Add live integration tests for all voyage-4 models - Update memory documentation with VoyageAI configuration examples
fzowl
force-pushed
the
feat/embedding-model-voyage-4-family
branch
from
23af9fc to
f6e5204
Compare
- Add curly braces to single-line if statements - Remove unused DEFAULT_VOYAGEAI_EMBEDDING_MODEL import from manager.ts Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Additional Comments (2)
Also appears in Prompt To Fix With AIThis is a comment left during a code review.
Path: extensions/memory-lancedb/config.ts
Line: 5:12
Comment:
[P0] Memory plugin schema still hard-codes provider as `openai`
`MemoryConfig.embedding.provider` is typed as `"openai"` and `memoryConfigSchema.parse` always returns `provider: "openai"`, but this PR now accepts `voyage-4*` models (and docs imply VoyageAI usage). If a user selects a voyage model, the plugin will still treat it as OpenAI, which is likely to break runtime provider selection.
Also appears in `extensions/memory-lancedb/openclaw.plugin.json` (no `provider` field for embedding config, UI hints still say OpenAI).
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/memory/manager.ts
Line: 1406:1422
Comment:
[P0] `activateFallbackProvider` type cast excludes `voyageai`
`fallbackFrom` is computed via `const fallbackFrom = this.provider.id as "openai" | "gemini" | "local";`, but `this.provider.id` can now be `"voyageai"`. If the primary provider is VoyageAI and embeddings fail, this cast will record an incorrect `fallbackFrom` value (or mask the new provider entirely), which can misreport status/fallback metadata and complicate debugging.
How can I resolve this? If you propose a fix, please make it concise. |
Address PR review comments: - Update MemoryConfig type to support "openai" | "voyageai" provider - Add resolveEmbeddingProvider() to detect provider from model prefix - Fix activateFallbackProvider type cast to include "voyageai" - Update UI hints to be provider-agnostic (support both OpenAI and VoyageAI) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
CLAWDINATOR FIELD REPORT // PR Closure I am CLAWDINATOR — cybernetic crustacean, maintainer triage bot for OpenClaw. I was sent from the future to keep this repo shipping clean code. TARGET ACQUIRED. I have reviewed your PR. Your effort is br00tal. Situation briefing: OpenClaw receives ~25 PRs every hour. The maintainers cannot pump iron that hard without collapsing. This PR is unlikely to merge in the near term, so I'm closing it to keep the pipeline moving. Consider that a deprecation — not a termination of your spirit. Think your change should ship? Come with me if you want to ship. Report to #pr-thunderdome-dangerzone on Discord — READ THE TOPIC or risk immediate termination. Give the maintainers a clear briefing — what it fixes, who it helps, why it's br00tal. I'll be back. Stay br00tal. 🤖 This is an automated message from CLAWDINATOR, the OpenClaw maintainer bot. |
1 participant
Add native VoyageAI embedding provider with voyage-4 family models:
Changes:
Greptile Overview
Greptile Summary
This PR adds a native VoyageAI embedding provider using the official
voyageaiSDK, registers it in the embeddings provider factory (including auto-detection), expands the embedding model/dimension registry to include the voyage-4 family, and updates memory-related docs and tests (unit + live).The changes integrate with the existing memory search pipeline by extending
src/memory/embeddings.tsto construct the new provider and by threading the new provider type throughsrc/memory/manager.tsso memory indexing/search can use VoyageAI embeddings similarly to OpenAI/Gemini/local.Main issues to address are around the memory LanceDB extension config/schema still being OpenAI-only despite adding Voyage models, and a type cast in the memory manager fallback path that doesn’t include the new
voyageaiprovider id.Confidence Score: 3/5
(4/5) You can add custom instructions or style guidelines for the agent here!
Context used:
dashboard- CLAUDE.md (source)dashboard- AGENTS.md (source)