Greptile Summary

This PR fixes a bug where resolveCronPayloadOutcome() collapsed all deliverable payloads down to the last one, causing multi-chunk cron reports to deliver only the final chunk. The fix introduces pickDeliverablePayloads() — which preserves all successful (non-error) deliverable payloads — and falls back to the last error payload when no successful payload exists. The deliveryPayload field (used for deliveryPayloadHasStructuredContent routing) is deliberately kept scoped to the last payload to preserve existing downstream safeguards in delivery-dispatch.ts.

• Extracts shared isDeliverablePayload() helper from the inline lambda in pickLastDeliverablePayload
• Adds pickDeliverablePayloads() returning all successful deliverable payloads, with error-only fallback to a single last-error payload
• Updates resolveCronPayloadOutcome() to populate deliveryPayloads via the new helper while keeping deliveryPayload (and deliveryPayloadHasStructuredContent) scoped to the last payload
• Comprehensive regression tests added at the unit, helper, and integration levels
• Test helper assertExplicitTelegramTargetDelivery correctly updated from single expectedText to expectedTexts[]

Confidence Score: 5/5

Safe to merge — the fix is well-scoped, correctly handles all identified edge cases, and is backed by thorough regression tests covering multi-payload success, mixed success/error, and all-error fallback scenarios.

All remaining observations are P2 or lower. The core logic in pickDeliverablePayloads is correct: successful non-error deliverables are preserved in order; when none exist, the single last-error fallback prevents notification spam. The deliveryPayloadHasStructuredContent scoping is explicitly intentional per the PR description and tested. No logic bugs, data-loss paths, or security concerns were identified.

No files require special attention.

_{Reviews (1): Last reviewed commit: "fix(cron): deliver full announce output ..." | Re-trigger Greptile}

Merged via squash.

• Merge SHA: bdd9bc9
• Added pickDeliverablePayloads() to preserve all successful text payloads for announce delivery
• Error-only runs fall back to last error payload only
• Extracted shared isDeliverablePayload() helper
• deliveryPayloadHasStructuredContent stays scoped to last payload
• CHANGELOG entry added
• 557 cron tests passing, typecheck clean

🔒 Aisle Security Analysis

We found 1 potential security issue(s) in this PR:

export function pickDeliverablePayloads(payloads: DeliveryPayload[]): DeliveryPayload[] {
  const successfulDeliverablePayloads = payloads.filter(
    (payload) => payload != null && payload.isError !== true && isDeliverablePayload(payload),
  );
  if (successfulDeliverablePayloads.length > 0) {
    return successfulDeliverablePayloads;
  }
  const lastDeliverablePayload = pickLastDeliverablePayload(payloads);
  return lastDeliverablePayload ? [lastDeliverablePayload] : [];
}

const deliveryPayload = pickLastDeliverablePayload(payloads);
const deliveryPayloads = deliveryPayload ? [deliveryPayload] : [];

const MAX_ANNOUNCE_PAYLOADS = 3;
const selected = pickDeliverablePayloads(payloads).slice(-MAX_ANNOUNCE_PAYLOADS);

​// Optionally merge text-only payloads
const mergedText = selected.map(p => (p.text ?? "").trim()).filter(Boolean).join("\n\n");
const deliveryPayloads = mergedText ? [{ text: mergedText }] : selected;

Analyzed PR: #57322 at commit 779d2ce

_{Last updated on: 2026-03-30T09:44:35Z}