fix(ios): mark activitykit import as preconcurrency#57180
Conversation
|
🤖 We're reviewing this PR with Aisle We're running a security check on the changes in this PR now. This usually takes a few minutes. ⌛ Progress:
Latest run failed. Keeping previous successful results. Trace ID: Last updated on: 2026-03-30T09:05:38Z |
Greptile SummaryThis PR fixes a Swift 6 strict concurrency compilation failure in
Confidence Score: 5/5Safe to merge — minimal, correct compiler-compatibility fix with no runtime impact. The change is a single-line, well-understood Swift 6 compatibility fix. The class is @mainactor throughout and no concurrency contracts are weakened. No logic, data flow, or behavior is changed. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/ios/Sources/LiveActivity/LiveActivityManager.swift | Single-line fix: import ActivityKit → @preconcurrency import ActivityKit to resolve Swift 6 strict concurrency build errors. No logic changes. |
Reviews (1): Last reviewed commit: "fix(ios): mark activitykit import as pre..." | Re-trigger Greptile
dea369b to
d96ad85
Compare
|
Landed via temp rebase onto main.
Thanks @ngutman! |
* fix(ios): mark activitykit import as preconcurrency * fix: note iOS ActivityKit preconcurrency build fix (openclaw#57180) (thanks @ngutman)
* fix(ios): mark activitykit import as preconcurrency * fix: note iOS ActivityKit preconcurrency build fix (openclaw#57180) (thanks @ngutman)
* fix(ios): mark activitykit import as preconcurrency * fix: note iOS ActivityKit preconcurrency build fix (openclaw#57180) (thanks @ngutman)
* fix(ios): mark activitykit import as preconcurrency * fix: note iOS ActivityKit preconcurrency build fix (openclaw#57180) (thanks @ngutman)
Summary
apps/ios/Sources/LiveActivity/LiveActivityManager.swiftfailed to compile under Xcode 26.4 / Swift 6 strict concurrency because the plainActivityKitimport triggered concurrency diagnostics in this file.@preconcurrency import ActivityKitinapps/ios/Sources/LiveActivity/LiveActivityManager.swift.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
apps/ios/Sources/LiveActivity/LiveActivityManager.swift.git blame, prior PR, issue, or refactor if known): Unknown.Regression Test Plan (if applicable)
apps/iossimulator build with theOpenClawscheme on current Xcode.xcodebuild -project OpenClaw.xcodeproj -scheme OpenClaw ... build.User-visible / Behavior Changes
None at runtime. This unblocks building and running the latest iOS app from source.
Diagram (if applicable)
N/A.
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
wss://<tailnet-host>Steps
apps/ioswithxcodebuild -project OpenClaw.xcodeproj -scheme OpenClaw -configuration Debug -destination 'id=1D348285-707A-49DD-96D6-63F204DC5798' -derivedDataPath build/SimDerivedData build.Expected
Actual
LiveActivityManager.swiftunder Swift 6 concurrency checks.Evidence
Before:
After:
Human Verification (required)
origin/mainpnpm checkremains red due unrelated TypeScript errors in untouchedsrc/agents/skills*files against current@mariozechner/pi-coding-agenttypesReview Conversations
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations
@preconcurrency import ActivityKitcould hide future ActivityKit concurrency issues in this file.