fix(agents): ignore ACP-only streamTo on subagent sessions_spawn by Mintalix · Pull Request #55483 · openclaw/openclaw

Mintalix · 2026-03-27T02:14:03Z

Summary

Problem: some sessions_spawn callers retain streamTo: "parent" even when the effective runtime is subagent, so the tool rejects an otherwise valid subagent spawn at the entrypoint.
Why it matters: this makes sessions_spawn fail for upstream callers that automatically attach ACP-only fields, even though subagent runtime never consumes streamTo.
What changed: sessions_spawn now treats streamTo as ACP-only, forwards it only for runtime="acp", and ignores it for subagent requests. Added regression tests for explicit and implicit subagent runtime.
What did NOT change (scope boundary): ACP streamTo="parent" behavior is unchanged, and resumeSessionId / ACP-only validation still stays strict.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes Bug: streamTo in sessions_spawn breaks subagent runtime #43556
Related sessions_spawn(subagent) can fail with ACP-only streamTo validation despite documented subagent semantics #53016
This PR fixes a bug or regression

Root Cause / Regression History (if applicable)

Root cause: src/agents/tools/sessions-spawn-tool.ts validated streamTo before dispatch and rejected any non-ACP runtime, even though only ACP runtime consumes streamTo.
Missing detection / guardrail: there was no regression test for callers that carry ACP-only params into subagent requests.
Prior context (git blame, prior PR, issue, or refactor if known): streamTo is ACP-only and is only used in src/agents/acp-spawn.ts.
Why this regressed now: upstream callers can retain streamTo while switching or defaulting to subagent runtime, which turns a recoverable extra param into a hard failure.
If unknown, what was ruled out: ruled out changes in acp-spawn.ts; ACP handling remains unchanged.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file: src/agents/tools/sessions-spawn-tool.test.ts
Scenario the test should lock in: subagent spawns ignore streamTo when runtime is explicitly subagent and when runtime is omitted and defaults to subagent.
Why this is the smallest reliable guardrail: the regression is at the tool entrypoint before ACP/subagent dispatch, so the tool unit test is the narrowest place that proves the contract.
Existing test that already covers this (if any): ACP streamTo="parent" behavior is already covered in src/agents/acp-spawn.test.ts.
If no new test is added, why not: N/A

User-visible / Behavior Changes

Previously, sessions_spawn returned an error when a subagent request included streamTo. Now it ignores streamTo for subagent requests and continues the spawn.

Diagram (if applicable)

Before:
[sessions_spawn runtime=subagent + streamTo=parent] -> [entry validation] -> [error]

After:
[sessions_spawn runtime=subagent + streamTo=parent] -> [drop ACP-only field] -> [subagent spawn succeeds]

greptile-apps · 2026-03-27T02:15:45Z

Greptile Summary

This PR fixes a correctness bug in sessions_spawn where callers that retain ACP-only fields (specifically streamTo: "parent") while targeting subagent runtime would receive a hard error instead of a successful spawn. The fix is minimal and well-scoped: streamTo is now parsed into a requestedStreamTo intermediate and then conditionally forwarded only when runtime === "acp", making it silently dropped for subagent requests. The resumeSessionId guard (which is semantically different — resuming a session without ACP is genuinely invalid) is left untouched, preserving existing strict validation where it matters.\n\n- Two regression tests lock in the new contract: one for runtime="subagent" explicit and one for omitted runtime (defaulting to subagent).\n- ACP streamTo forwarding is unaffected; the existing ACP test at line 116 still passes streamTo: "parent" and expects it through to spawnAcpDirect.\n- spawnSubagentDirect never accepted streamTo in its parameter object, so the field was already not forwarded; the real improvement is that the tool no longer short-circuits with an error before reaching the dispatch.

Confidence Score: 5/5

Safe to merge — targeted one-line logic change with full regression test coverage and no impact on ACP behavior.

The change is minimal (one conditional assignment replaces a rejection guard), the old behavior for ACP is provably unchanged (the ternary forwards requestedStreamTo when runtime === "acp"), the subagent path never consumed streamTo anyway, and two new tests directly lock in the fixed contract. No other call sites are affected.

No files require special attention.

Important Files Changed

Filename	Overview
src/agents/tools/sessions-spawn-tool.ts	Replaces the hard rejection of streamTo on non-ACP runtimes with a silent drop: streamTo is now conditionally forwarded only when runtime === "acp". The removed guard and the new two-step parse are both correct.
src/agents/tools/sessions-spawn-tool.test.ts	Old error-expectation test replaced with two new passing tests: explicit runtime="subagent" and omitted runtime both succeed when streamTo is present, and verify spawnSubagentDirect is called without the field.

_{Reviews (1): Last reviewed commit: "agents: ignore ACP-only streamTo on suba..." | Re-trigger Greptile}

Copilot

Pull request overview

This PR fixes sessions_spawn entrypoint validation so ACP-only streamTo does not cause otherwise-valid subagent spawns to fail, improving compatibility with upstream callers that may carry ACP-only fields.

Changes:

Treat streamTo as ACP-only: forward it only when runtime="acp", otherwise ignore it.
Remove the prior rejection of streamTo when runtime is not ACP.
Add regression tests covering explicit and default (omitted) subagent runtime with streamTo present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/agents/tools/sessions-spawn-tool.ts	Drops `streamTo` for subagent runtime and preserves ACP forwarding behavior.
src/agents/tools/sessions-spawn-tool.test.ts	Adds tests ensuring subagent spawns ignore `streamTo` while ACP behavior remains covered elsewhere.

Copilot · 2026-03-27T02:16:20Z

+      const requestedStreamTo = params.streamTo === "parent" ? "parent" : undefined;
+      // Some callers retain ACP-only fields when they fall back to subagent runtime.
+      // Treat streamTo as ACP-only and drop it for subagent requests.
+      const streamTo = runtime === "acp" ? requestedStreamTo : undefined;


streamTo is now treated as ACP-only in the implementation, but the tool schema doesn’t communicate that to callers (unlike resumeSessionId, which has a description noting runtime="acp"). Consider adding a description to the streamTo schema property stating it’s only used for runtime="acp" and ignored for subagent spawns to prevent API confusion.

vincentkoc · 2026-03-29T07:59:53Z

Re-checked against current origin/main on 2026-03-29. This still looks clean and mergeable. sessions-spawn-tool.ts continues to reject ACP-only streamTo when the effective runtime is subagent, so the original regression remains present on current main.

Remove memory_search and memory_get from SUBAGENT_TOOL_DENY_ALWAYS. These are read-only tools with no side effects that are essential for multi-agent setups relying on shared memory for context retrieval. Rationale: - Read-only tools (memory_search, memory_get) have no side effects and cannot modify state, send messages, or affect external systems - Other read-only tools (read, web_search, web_fetch) are already available to sub-agents by default - Multi-agent deployments with shared knowledge depend on memory tools for context retrieval - The workaround (tools.subagents.tools.alsoAllow) works but requires manual configuration that contradicts memorySearch.enabled: true Fixes openclaw#55385

openclaw-barnacle · 2026-03-29T08:32:54Z

Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch.

chosen67one-source

@

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1911129201

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-29T08:40:28Z

+export const definePluginEntry: FacadeModule["definePluginEntry"] = createLazyFacadeObjectValue(
+  () => loadFacadeModule()["definePluginEntry"] as object,
+) as FacadeModule["definePluginEntry"];


Export definePluginEntry as callable facade

definePluginEntry is wrapped with createLazyFacadeObjectValue, which always returns a proxy over {} (src/plugin-sdk/facade-runtime.ts), so this export is no longer callable. Any consumer importing openclaw/plugin-sdk/browser-runtime and invoking definePluginEntry(...) will hit a runtime TypeError because the value is an object proxy instead of a function.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-29T08:40:28Z

+export const MemoryIndexManager: FacadeModule["MemoryIndexManager"] = createLazyFacadeObjectValue(
+  () => loadFacadeModule()["MemoryIndexManager"] as object,
+) as FacadeModule["MemoryIndexManager"];


Preserve class-valued MemoryIndexManager export

MemoryIndexManager is also wrapped via createLazyFacadeObjectValue, which changes the export from a class/function value into a plain object proxy. This breaks class semantics for SDK consumers (for example new, instanceof, or prototype-based checks) compared to the prior direct re-export from memory-core/runtime-api.

Useful? React with 👍 / 👎.

Some callers retain ACP-only fields (streamTo) when falling back to subagent runtime. Silently drop streamTo for non-ACP requests instead of returning an error. Closes openclaw#43556 Ref: PR openclaw#55483 (correct fix, closed due to unrelated scope creep)

agents: ignore ACP-only streamTo on subagent spawns

3a6a351

Copilot AI review requested due to automatic review settings March 27, 2026 02:14

openclaw-barnacle Bot added agents Agent runtime and tooling size: S labels Mar 27, 2026

Copilot started reviewing on behalf of Mintalix March 27, 2026 02:14 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

Mintalix added 3 commits March 27, 2026 10:18

Merge branch 'main' into codex/fix-sessions-tool-validation

4a697f1

Merge branch 'main' into codex/fix-sessions-tool-validation

3d4c488

Merge branch 'main' into codex/fix-sessions-tool-validation

ba68506

vincentkoc self-assigned this Mar 27, 2026

vincentkoc and others added 8 commits March 29, 2026 01:11

Merge branch 'main' into codex/fix-sessions-tool-validation

5fba4c3

refactor(plugins): decouple bundled plugin runtime loading

efeebfd

refactor(test): centralize bundled channel test roots

882fa06

docs(plugins): refresh bundled plugin runtime docs

62295e7

Agents: cover subagent memory tool policy

5dc1ff7

Tests: stabilize shard-2 queue and channel state

c6bc506

fix(agents): document acp-only streamTo contract

1911129

vincentkoc requested a review from a team as a code owner March 29, 2026 08:32

openclaw-barnacle Bot added docs Improvements or additions to documentation channel: bluebubbles Channel integration: bluebubbles channel: discord Channel integration: discord channel: googlechat Channel integration: googlechat channel: line Channel integration: line labels Mar 29, 2026

openclaw-barnacle Bot closed this Mar 29, 2026

chosen67one-source reviewed Mar 29, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Mar 29, 2026

View reviewed changes

vincentkoc mentioned this pull request Mar 29, 2026

fix(agents): ignore acp-only streamTo on subagent sessions_spawn #56906

Closed

This was referenced Apr 1, 2026

fix(agents): drop streamTo silently for non-ACP spawn requests #58663

Closed

fix(agents): drop streamTo silently for non-ACP spawn requests #58686

Closed

Mintalix deleted the codex/fix-sessions-tool-validation branch April 3, 2026 17:51

This was referenced Apr 12, 2026

fix(agents): ignore ACP-only streamTo on subagent sessions_spawn damselem/openclaw#1

Open

fix(agents): ignore ACP-only streamTo on subagent sessions_spawn #65282

Closed

This was referenced Apr 26, 2026

fix(sessions_spawn): tolerate ACP-only fields for subagent runtime #72331

Merged

fix(sessions_spawn): tolerate ACP-only fields for subagent runtime #72614

Merged

clawsweeper Bot mentioned this pull request Jul 8, 2026

fix(sessions-spawn): reject streamTo with runtime="subagent" instead of silent ignore #102184

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(agents): ignore ACP-only streamTo on subagent sessions_spawn#55483

fix(agents): ignore ACP-only streamTo on subagent sessions_spawn#55483
Mintalix wants to merge 12 commits into
openclaw:mainfrom
Mintalix:codex/fix-sessions-tool-validation

Mintalix commented Mar 27, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Mar 27, 2026

Important Files Changed

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

vincentkoc commented Mar 29, 2026

Uh oh!

openclaw-barnacle Bot commented Mar 29, 2026

Uh oh!

chosen67one-source left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 29, 2026

Uh oh!

chatgpt-codex-connector Bot Mar 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

Mintalix commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Root Cause / Regression History (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Diagram (if applicable)

Uh oh!

greptile-apps Bot commented Mar 27, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

vincentkoc commented Mar 29, 2026

Uh oh!

openclaw-barnacle Bot commented Mar 29, 2026

Uh oh!

chosen67one-source left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Mintalix commented Mar 27, 2026 •

edited

Loading