fix(gateway): ignore transient pre-hello close in one-shot calls by ruanrrn · Pull Request #54774 · openclaw/openclaw

ruanrrn · 2026-03-26T00:39:21Z

Summary

Problem: callGateway() (one-shot CLI gateway calls) can fail early when the underlying GatewayClient emits a transient pre-hello-ok WebSocket close (1000, "").
Why it matters: This shows up as user-visible false negatives like gateway closed (1000 normal closure): no close reason for commands that should succeed after a quick reconnect.
What changed: Treat a normal close with an empty reason as a transient pre-hello close; keep waiting for hello-ok (or timeout). Also suppress the matching connect-error noise in GatewayClient when reconnect continues.
What did NOT change (scope boundary): No protocol/auth changes, no retry/backoff behavior changes beyond ignoring this specific close shape while reconnect succeeds.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #
This PR fixes a bug or regression

Root Cause / Regression History (if applicable)

Root cause: callGateway() treated any onClose callback as terminal, even though GatewayClient auto-reconnects; a (1000, "") close can occur during the initial handshake and immediately recover.
Missing detection / guardrail: No regression test for “close before hello-ok, then hello-ok later”.
Prior context (git blame, prior PR, issue, or refactor if known): Unknown.
Why this regressed now: Likely increased frequency of short handshake interruptions (gateway restart / WS churn), exposing the mismatch between one-shot callers and reconnecting client semantics.
If unknown, what was ruled out: Not an auth failure (code 1000, empty reason), and reconnect succeeds in the simulated scenario.

Regression Test Plan (if applicable)

Coverage level that should have caught this:
- Unit test
- Seam / integration test
- End-to-end test
- Existing coverage already sufficient
Target test or file:
- src/gateway/call.test.ts (new case: close-then-hello)
- src/gateway/client.test.ts (new case: transient close + reconnect success)
Scenario the test should lock in: A transient pre-hello (1000, "") close must not fail one-shot calls when hello-ok arrives after reconnect.
Why this is the smallest reliable guardrail: It isolates the race at the call wrapper boundary without requiring a live gateway.
Existing test that already covers this (if any): None found.
If no new test is added, why not: N/A

User-visible / Behavior Changes

One-shot gateway calls (e.g. CLI commands using callGateway) no longer fail immediately on a transient pre-hello-ok (1000, "") close; they keep waiting until hello-ok or timeout.

Security Impact (required)

New permissions/capabilities? (Yes/No) No
Secrets/tokens handling changed? (Yes/No) No
New/changed network calls? (Yes/No) No
Command/tool execution surface changed? (Yes/No) No
Data access scope changed? (Yes/No) No
If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

OS: Linux (CI/unit-test)
Runtime/container: Node.js
Model/provider: N/A
Integration/channel (if any): N/A
Relevant config (redacted): N/A

Steps

Start a GatewayClient / callGateway invocation.
Emit onClose(1000, "") before hello-ok.
Later emit hello-ok (representing a successful reconnect).

Expected

The call waits and succeeds (or times out), rather than failing immediately on the transient close.

Actual

Before this change, callGateway failed immediately with a gateway closed (1000 ...) error.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios: Ran unit tests covering the new transient close cases.
Edge cases checked: Ensured non-empty close reasons and post-hello closes remain fatal for one-shot calls.
What you did not verify: Live gateway reproduction on a real running daemon.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

Backward compatible? (Yes/No) Yes
Config/env changes? (Yes/No) No
Migration needed? (Yes/No) No
If yes, exact upgrade steps: N/A

Failure Recovery (if this breaks)

How to disable/revert this change quickly: Revert this commit.
Files/config to restore: src/gateway/call.ts, src/gateway/client.ts.
Known bad symptoms reviewers should watch for: One-shot calls hanging until timeout when the gateway is down.

Risks and Mitigations

Risk: Suppressing a (1000, "") close could delay surfacing a real shutdown by up to the call timeout.
- Mitigation: Only suppressed before hello-ok and still bounded by the existing call timeout; other close codes/reasons remain fatal.

AI-assisted: Yes (OpenClaw agent-assisted implementation). Local testing: targeted gateway unit tests (see Evidence above).

greptile-apps · 2026-03-26T00:42:25Z

Greptile Summary

This PR fixes a real user-visible regression where callGateway (one-shot CLI calls) would immediately fail with gateway closed (1000 normal closure): no close reason when the WebSocket received a transient pre-hello-ok close, even though GatewayClient would successfully reconnect moments later.

The fix operates at two coordinated layers:

client.ts: Detects a transient pre-hello normal-close (1000, "") pattern and suppresses the onClose and onConnectError callbacks for that specific event, letting the auto-reconnect proceed silently. Two new flags (helloOkReceived, suppressNextConnectError) track per-connection state and are correctly reset in beginPreauthHandshake() on each new socket open.
call.ts: Adds a secondary guard that short-circuits the fatal error path in onClose if hello-ok hasn't arrived yet and the close is (1000, ""). This is belt-and-suspenders relative to the client.ts suppression and is directly exercised by the stub-based unit tests.

Key design properties that make this safe:

Suppression is bounded by the pre-existing call timeout — the call cannot hang indefinitely.
Only code === 1000 + empty reason + pre-hello-ok is suppressed; all other close codes/reasons and post-hello-ok closes remain fatal.
Test coverage added at both the call.ts (stub) and client.ts (fake-WS) layers targeting the exact regression scenario.

Minor note: the suppressNextConnectError boolean relies on the Node.js guarantee that promise microtasks drain before reconnect timers fire, to ensure the suppression is consumed by the right .catch() handler. This invariant holds in practice but is implicit — a generation counter or per-WS token would make it structurally impossible to misapply.

Confidence Score: 5/5

Safe to merge — the fix is correctly scoped, timeout-bounded, and covered by targeted unit tests at both affected layers.
The logic is correct and well-contained. Both changed source files have matching new unit tests that reproduce the exact regression scenario. The only non-blocking concern is that suppressNextConnectError relies implicitly on microtask/timer ordering rather than a more structurally explicit token; this is a future hardening opportunity, not a current correctness issue.
No files require special attention; the client.ts timing invariant around suppressNextConnectError is the most subtle part but is safe under normal Node.js event-loop behavior.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: src/gateway/client.ts
Line: 271-273

Comment:
**`suppressNextConnectError` consumed after reconnect reset in edge case**

When the transient close fires, `suppressNextConnectError` is set to `true` (line 273) and `flushPendingErrors` synchronously calls `p.reject()` on the in-flight connect promise, scheduling its `.catch()` handler as a microtask. In normal flow, that microtask runs and resets `suppressNextConnectError = false` before `scheduleReconnect()` fires the reconnect timer — this is safe because microtasks drain before timers in Node.js.

However, if for any reason `beginPreauthHandshake()` on the reconnect socket fires before the original `.catch()` microtask runs (e.g. a synchronous reconnect in a test harness or a zero-delay `scheduleReconnect`), the flag is reset to `false` prematurely. The first connect's `.catch()` then falls through to the full error path, calling `onConnectError` and logging — which is exactly the noise the fix is meant to suppress.

The flag was already consumed at the `.catch()` level: you could strengthen this by keying the suppression to the specific rejected promise (e.g. a generation counter or a WeakRef to the WS instance) rather than a shared boolean. For now the current approach is correct for the documented reconnect timer delay, but the coupling is subtle.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(gateway): ignore transient pre-hello..." | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73d1dce54c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

clawsweeper · 2026-04-28T02:22:51Z

Codex automated review: keeping this open.

Keep this PR open. Current main still treats a pre-hello code-1000 empty-reason gateway close as fatal in one-shot gateway calls, while this PR is a focused implementation candidate with regression coverage and a bounded client-side suppression path. It also overlaps with #54475, so maintainers should choose one canonical branch before merging or closing either one.

Best possible solution:

Keep this PR open for maintainer review and consolidate it with #54475. The best path is a narrow shared gateway fix: track hello-ok in src/gateway/call.ts, suppress only pre-hello code-1000 empty-reason closes in src/gateway/client.ts, keep suppression bounded and keyed to a specific connect attempt, and retain focused regression tests in src/gateway/call.test.ts and src/gateway/client.test.ts. After one branch is selected and lands, close the other overlapping PR as superseded.

What I checked:

Current main still fails one-shot calls on any early close: executeGatewayRequestWithScopes tracks settled and ignoreClose, but does not track whether hello-ok has arrived. The onClose handler immediately sets ignoreClose and rejects through formatGatewayCloseError for a pre-settle close, including code 1000 with an empty reason. (src/gateway/call.ts:573, 5828dcdb05aa)
Current GatewayClient surfaces the close before reconnect completes: The WebSocket close handler currently flushes pending errors with gateway closed, schedules reconnect, and still calls opts.onClose; the connect promise catch also calls onConnectError and logs gateway connect failed. There is no current-main pre-hello code-1000 empty-reason suppression. (src/gateway/client.ts:334, 5828dcdb05aa)
Current tests do not cover the requested tolerance: The current call.test.ts stub supports only hello, close, and silent, and the existing close test asserts immediate failure details. A targeted search found no close-then-hello, pre-hello transient, or equivalent regression case on current main. (src/gateway/call.test.ts:43, 5828dcdb05aa)
PR diff is focused and includes regression coverage: The PR patch touches only src/gateway/call.ts, src/gateway/client.ts, and their tests. It adds helloOk tracking in the one-shot call path, suppresses only pre-hello code-1000 empty-reason closes, caps repeated suppression at 3 in GatewayClient, keys connect-error suppression by connect attempt, and adds reconnect-success plus repeated-failure tests. (src/gateway/client.ts:316, 60bef44484b0)
Related same-author PR remains open: The supplied GitHub context shows fix(gateway): tolerate transient pre-hello closes in CLI calls #54475 is an open same-author PR for the same gateway pre-hello close problem. That makes this a consolidation/review question, not a conservative cleanup close while both implementation candidates remain open.
Security review pass found no supply-chain or permissions expansion: The PR patch is limited to gateway runtime close/error handling and Vitest coverage. It does not touch workflows, dependency sources, lockfiles, package publishing metadata, install/build scripts, downloaded artifacts, GitHub permissions, or secret-handling code. (60bef44484b0)

Remaining risk / open question:

fix(gateway): tolerate transient pre-hello closes in CLI calls #54475 overlaps with this PR; maintainers should choose one canonical implementation before merge and then close the other as superseded.
The behavior intentionally delays failure for a narrow pre-hello close shape; the cap and timeout bound the risk, but targeted gateway tests plus the changed gate should run before landing.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against 5828dcdb05aa.

openclaw-clownfish · 2026-04-29T19:50:34Z

Thanks @ruanrrn for the focused gateway fix here. I am closing this as superseded by #54475 because both PRs target the same transient pre-hello (1000, "") gateway close path, and #54475 is now the canonical branch that Clownfish repaired for the original contributor path: #54475.

The useful work from this source PR is still represented in the canonical path, including the same src/gateway/call.ts / src/gateway/client.ts behavior and focused regression tests. Credit and attribution stay visible through this PR and the canonical PR context. If #54475 misses a reproduction path that only this branch covers, please reply and we can reopen or split it back out.

…26.6.8) (#1144) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.6.6` → `2026.6.8` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.6.8`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#202668) [Compare Source](openclaw/openclaw@v2026.6.6...v2026.6.8) ##### Highlights - Telegram and WhatsApp channel delivery are richer and less brittle: Telegram can send structured rich text with tables, lists, expandable blockquotes, prompt-preserving CLI backend delivery, retired native draft migration, and safer rich-media boundaries, while WhatsApp now honors configured ACP bindings. ([#92679](openclaw/openclaw#92679), [#84082](openclaw/openclaw#84082), [#89421](openclaw/openclaw#89421), [#92513](openclaw/openclaw#92513)) Thanks [@obviyus](https://github.com/obviyus), [@jzakirov](https://github.com/jzakirov), [@spacegeologist](https://github.com/spacegeologist), and [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent and Gateway recovery is sharper across account-scoped DM sends, generated media completions, restart shutdown aborts, yielded subagent pauses, yielded cron media, heartbeat dedupe, session identity prompts, and unknown OpenAI agent selector rejection. ([#92788](openclaw/openclaw#92788), [#91246](openclaw/openclaw#91246), [#91357](openclaw/openclaw#91357), [#92631](openclaw/openclaw#92631), [#92146](openclaw/openclaw#92146), [#91287](openclaw/openclaw#91287), [#92468](openclaw/openclaw#92468), [#92510](openclaw/openclaw#92510)) Thanks [@yetval](https://github.com/yetval), [@TurboTheTurtle](https://github.com/TurboTheTurtle), [@ooiuuii](https://github.com/ooiuuii), [@openperf](https://github.com/openperf), [@IWhatsskill](https://github.com/IWhatsskill), [@ZengWen-DT](https://github.com/ZengWen-DT), and [@zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Provider/model handling expands and tightens with GLM-5.2, Claude Haiku 4.5 catalog rows, OpenRouter and Google Vertex provider-prefix normalization, managed SecretRef auth, bounded model browse discovery, storeless OpenAI Responses replay gating, and Claude 4.5 Copilot tool-streaming safety. ([#92796](openclaw/openclaw#92796), [#90116](openclaw/openclaw#90116), [#92627](openclaw/openclaw#92627), [#91218](openclaw/openclaw#91218), [#90686](openclaw/openclaw#90686), [#92247](openclaw/openclaw#92247), [#90706](openclaw/openclaw#90706), [#75393](openclaw/openclaw#75393)) Thanks [@arkyu2077](https://github.com/arkyu2077), [@liuhao1024](https://github.com/liuhao1024), [@bymle](https://github.com/bymle), [@rohitjavvadi](https://github.com/rohitjavvadi), [@samson910022](https://github.com/samson910022), [@snowzlm](https://github.com/snowzlm), and [@Kailigithub](https://github.com/Kailigithub). - `/usage` and reply payload hooks now have a native full footer renderer, default template, fixed-decimal formatting, credential-aware limits, better partial-count handling, and warnings for broken templates instead of silent bad output. ([#92657](openclaw/openclaw#92657), [#89835](openclaw/openclaw#89835), [#89629](openclaw/openclaw#89629)) Thanks [@Marvinthebored](https://github.com/Marvinthebored). - UI and mobile flows are steadier: workspace files can collapse and start collapsed, WebChat backscroll survives streaming, the sidebar session picker remains interactive above the desktop workbench, reset soft args survive UI dispatch, stale dashboard session parent lineage is preserved, and iOS reconnects stale foreground gateways. ([#92779](openclaw/openclaw#92779), [#92622](openclaw/openclaw#92622), [#92705](openclaw/openclaw#92705), [#91353](openclaw/openclaw#91353), [#90658](openclaw/openclaw#90658), [#92552](openclaw/openclaw#92552)) Thanks [@shakkernerd](https://github.com/shakkernerd), [@TurboTheTurtle](https://github.com/TurboTheTurtle), [@NianJiuZst](https://github.com/NianJiuZst), [@zhouhe-xydt](https://github.com/zhouhe-xydt), [@luoyanglang](https://github.com/luoyanglang), and [@Solvely-Colin](https://github.com/Solvely-Colin). - Memory, state, and diagnostics recover cleaner: oversized OpenAI embedding batches split before 431s, QMD memory search stays available in transient mode, SQLite avoids WAL on NFS state volumes, stuck-session recovery scheduling no longer resets warning backoff, and Infinity chunk limits stay genuinely unbounded. ([#92650](openclaw/openclaw#92650), [#92618](openclaw/openclaw#92618), [#92639](openclaw/openclaw#92639), [#91247](openclaw/openclaw#91247), [#92752](openclaw/openclaw#92752), [#92735](openclaw/openclaw#92735)) Thanks [@mushuiyu886](https://github.com/mushuiyu886), [@TurboTheTurtle](https://github.com/TurboTheTurtle), [@849261680](https://github.com/849261680), [@gnanam1990](https://github.com/gnanam1990), and [@yhterrance](https://github.com/yhterrance). ##### Changes - Providers/models: add GLM-5.2 support and Claude Haiku 4.5 catalog entries while keeping provider-qualified model IDs normalized across OpenRouter and Google Vertex paths. ([#92796](openclaw/openclaw#92796), [#90116](openclaw/openclaw#90116), [#92627](openclaw/openclaw#92627), [#91218](openclaw/openclaw#91218)) Thanks [@arkyu2077](https://github.com/arkyu2077), [@liuhao1024](https://github.com/liuhao1024), and [@bymle](https://github.com/bymle). - Channel plugins: ship Telegram rich-message delivery and WhatsApp ACP binding support, including rich prompt handoff to CLI backends and transport fixtures for richer drafts. ([#92679](openclaw/openclaw#92679), [#92513](openclaw/openclaw#92513)) Thanks [@obviyus](https://github.com/obviyus) and [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent commands: support `/btw` in CLI-backed sessions and keep CLI usage-error exits classified as usage failures instead of successful runs. ([#92669](openclaw/openclaw#92669), [#92162](openclaw/openclaw#92162)) Thanks [@joshavant](https://github.com/joshavant) and [@Pandah97](https://github.com/Pandah97). - Usage hooks: add built-in full footer rendering, default footer templates, per-turn usage state, credential-aware limits, and fixed-decimal formatting for usage-bar templates. ([#92657](openclaw/openclaw#92657), [#89835](openclaw/openclaw#89835), [#89629](openclaw/openclaw#89629)) Thanks [@Marvinthebored](https://github.com/Marvinthebored). - Docs and operator guidance: document node config examples, clarify before-install hook scope, correct agent default concurrency comments, refresh ZAI provider docs, and update channel/group docs for current Telegram and WhatsApp behavior. ([#92677](openclaw/openclaw#92677), [#92766](openclaw/openclaw#92766), [#92695](openclaw/openclaw#92695)) Thanks [@liuhao1024](https://github.com/liuhao1024), [@sallyom](https://github.com/sallyom), and [@ArielSmoliar](https://github.com/ArielSmoliar). ##### Fixes - Onboarding/skills: show the Homebrew install recommendation only on macOS and Linux, so FreeBSD and other unsupported platforms no longer get a misleading brew prompt. Fixes [#68893](openclaw/openclaw#68893); carries forward [#68894](openclaw/openclaw#68894), [#68910](openclaw/openclaw#68910), [#68941](openclaw/openclaw#68941), [#68943](openclaw/openclaw#68943), [#69002](openclaw/openclaw#69002), and [#69545](openclaw/openclaw#69545). Thanks [@yurivict](https://github.com/yurivict), [@Sanjays2402](https://github.com/Sanjays2402), [@Eruditi](https://github.com/Eruditi), [@JustInCache](https://github.com/JustInCache), [@nnish16](https://github.com/nnish16), and [@Mlightsnow](https://github.com/Mlightsnow). - Channels and delivery: preserve account-scoped DM channel send policy, rich Telegram final replies, rich Telegram tables and lists, Telegram thread-create CLI remapping, Slack outbound `message_sent` hooks, contributed message-tool schema optionality, same-channel generated media completions, and channel chunking around surrogate pairs and Infinity limits. ([#92788](openclaw/openclaw#92788), [#92679](openclaw/openclaw#92679), [#89421](openclaw/openclaw#89421), [#89943](openclaw/openclaw#89943), [#91137](openclaw/openclaw#91137), [#91246](openclaw/openclaw#91246), [#92735](openclaw/openclaw#92735)) Thanks [@yetval](https://github.com/yetval), [@obviyus](https://github.com/obviyus), [@spacegeologist](https://github.com/spacegeologist), [@rishitamrakar](https://github.com/rishitamrakar), [@lundog](https://github.com/lundog), [@TurboTheTurtle](https://github.com/TurboTheTurtle), and [@yhterrance](https://github.com/yhterrance). - Auto-reply/groups: keep ordinary group text replies on automatic final-reply delivery while allowing `message(action=send)` for files, images, and other attachments to the same group or topic. Carries forward [#43276](openclaw/openclaw#43276); refs [#48004](openclaw/openclaw#48004). Thanks [@NayukiChiba](https://github.com/NayukiChiba) and [@ShakaRover](https://github.com/ShakaRover). - Auto-reply/skills: preserve multiline payloads for `/skill` and direct skill slash commands while keeping command-head normalization for aliases, colon syntax, and bot mentions. Fixes [#79155](openclaw/openclaw#79155); carries forward [#81305](openclaw/openclaw#81305). Thanks [@web3blind](https://github.com/web3blind). - iMessage: normalize leading NUL sent-message echo prefixes while preserving interior NUL bytes and the leading attributedBody marker handling from [#73942](openclaw/openclaw#73942). Carries forward [#63581](openclaw/openclaw#63581). Thanks [@drvoss](https://github.com/drvoss). - Discord: give generated auto-thread titles a 60-second timeout and 4,096-token reasoning-model output budget, clamped to the selected model output cap. ([#64734](openclaw/openclaw#64734)) Thanks [@hanamizuki](https://github.com/hanamizuki). - Agent, cron, and Gateway runtime: mark active main sessions before restart shutdown aborts, pause yielded subagent runs whose terminal also signals abort, preserve yielded media completions, de-duplicate main-session heartbeat events, expose session identity in runtime prompts, reject unknown OpenAI agent selectors, keep generated media completions and slash-command block replies in WebChat, preserve fresh post-compaction usage while clearing stale usage snapshots, and require admin privileges for HTTP session/model override surfaces. ([#91357](openclaw/openclaw#91357), [#92631](openclaw/openclaw#92631), [#92146](openclaw/openclaw#92146), [#91287](openclaw/openclaw#91287), [#92468](openclaw/openclaw#92468), [#92510](openclaw/openclaw#92510), [#91246](openclaw/openclaw#91246), [#50795](openclaw/openclaw#50795), [#50845](openclaw/openclaw#50845), [#82874](openclaw/openclaw#82874), [#92651](openclaw/openclaw#92651), [#92646](openclaw/openclaw#92646)) Thanks [@ooiuuii](https://github.com/ooiuuii), [@openperf](https://github.com/openperf), [@IWhatsskill](https://github.com/IWhatsskill), [@ZengWen-DT](https://github.com/ZengWen-DT), [@zhangguiping-xydt](https://github.com/zhangguiping-xydt), [@Hollychou924](https://github.com/Hollychou924), [@leno23](https://github.com/leno23), and [@TurboTheTurtle](https://github.com/TurboTheTurtle). - Agents/exec: default empty-success background completion notices on only for real chat channels, preserving explicit opt-outs and keeping generic providers silent while carrying forward the narrow UX intent from [#39726](openclaw/openclaw#39726) and [#46926](openclaw/openclaw#46926). Thanks [@Sapientropic](https://github.com/Sapientropic) and [@wenkang-xie](https://github.com/wenkang-xie). - Providers and model replay: preserve storeless OpenAI Responses replay compatibility, avoid eager tool streaming for Claude 4.5 in Copilot, honor profile auth for SecretRef model entries, bound model browsing, strip provider prefixes where runtimes need bare IDs, and surface nested embedding fetch failures. ([#90706](openclaw/openclaw#90706), [#75393](openclaw/openclaw#75393), [#90686](openclaw/openclaw#90686), [#92247](openclaw/openclaw#92247), [#92627](openclaw/openclaw#92627), [#91218](openclaw/openclaw#91218), [#92628](openclaw/openclaw#92628)) Thanks [@snowzlm](https://github.com/snowzlm), [@Kailigithub](https://github.com/Kailigithub), [@rohitjavvadi](https://github.com/rohitjavvadi), [@samson910022](https://github.com/samson910022), [@liuhao1024](https://github.com/liuhao1024), [@bymle](https://github.com/bymle), and [@mushuiyu886](https://github.com/mushuiyu886). - Memory, state, diagnostics, and config: split header-too-large embedding batches, keep QMD memory search enabled in transient mode, avoid SQLite WAL on NFS volumes, preserve recovery scheduling outside stuck-session warning backoff, and keep shell environment fallbacks contained in config write tests. ([#92650](openclaw/openclaw#92650), [#92618](openclaw/openclaw#92618), [#92639](openclaw/openclaw#92639), [#91247](openclaw/openclaw#91247), [#92752](openclaw/openclaw#92752)) Thanks [@mushuiyu886](https://github.com/mushuiyu886), [@TurboTheTurtle](https://github.com/TurboTheTurtle), [@849261680](https://github.com/849261680), and [@gnanam1990](https://github.com/gnanam1990). - Workspace setup state: store setup completion outside the workspace dot directory using an OpenClaw-named root file, migrate valid legacy state forward, and avoid clobbering generic root `workspace-state.json` files for TigerFS-style dot-path compatibility. This Clownfish replacement carries forward the focused [#53326](openclaw/openclaw#53326) fix idea because the original branch was closed and uneditable. ([#53326](openclaw/openclaw#53326), [#44783](openclaw/openclaw#44783), [#39446](openclaw/openclaw#39446)) Thanks [@1qh](https://github.com/1qh). - UI/mobile/TUI: preserve dashboard session parent lineage, WebChat backscroll, reset soft command args, sidebar session picker interactivity, collapsed workspace files, resolved `/model` confirmation refs, and stale foreground iOS Gateway reconnects. ([#90658](openclaw/openclaw#90658), [#92622](openclaw/openclaw#92622), [#91353](openclaw/openclaw#91353), [#92705](openclaw/openclaw#92705), [#92779](openclaw/openclaw#92779), [#92773](openclaw/openclaw#92773), [#92552](openclaw/openclaw#92552)) Thanks [@luoyanglang](https://github.com/luoyanglang), [@TurboTheTurtle](https://github.com/TurboTheTurtle), [@zhouhe-xydt](https://github.com/zhouhe-xydt), [@NianJiuZst](https://github.com/NianJiuZst), [@shakkernerd](https://github.com/shakkernerd), [@NarahariRaghava](https://github.com/NarahariRaghava), and [@Solvely-Colin](https://github.com/Solvely-Colin). - TUI: reload the active session after external `/new` or `/reset` session-change events so stale transcript and stream state clear promptly. Fixes [#38966](openclaw/openclaw#38966); carries forward [#40472](openclaw/openclaw#40472). Thanks [@yizhanzjz](https://github.com/yizhanzjz) and [@wsyjh8](https://github.com/wsyjh8). - Control UI: preserve Gateway Access tokens during same-normalized WebSocket URL edits and reload gateway-scoped tokens when switching endpoints. Fixes [#41545](openclaw/openclaw#41545); repairs [#42001](openclaw/openclaw#42001) with additional source PRs [#41546](openclaw/openclaw#41546), [#41552](openclaw/openclaw#41552), and [#41718](openclaw/openclaw#41718). Thanks [@wsyjh8](https://github.com/wsyjh8), [@llagy0020](https://github.com/llagy0020), [@llagy007](https://github.com/llagy007), [@pingfanfan](https://github.com/pingfanfan), and [@zheliu2](https://github.com/zheliu2). - Gateway CLI: tolerate a single transient clean WebSocket close before `hello-ok` so one-shot RPC calls reconnect instead of failing noisily, while repeated clean pre-hello closes still surface. Carries forward source PRs [#54475](openclaw/openclaw#54475) and [#54774](openclaw/openclaw#54774); [#85253](openclaw/openclaw#85253) covered adjacent connect assembly diagnostics. Thanks [@ruanrrn](https://github.com/ruanrrn). - Gateway/Linux: keep root-owned systemd user service lifecycle commands on root's user manager when a stale `SUDO_USER` remains in a root shell with root's user bus environment. Fixes [#81410](openclaw/openclaw#81410). Thanks [@Ericksza](https://github.com/Ericksza) and [@ChuckClose-tech](https://github.com/ChuckClose-tech). - Release and test reliability: extend slow Gateway/full-suite watchdogs, split local full-suite shards when throttled, stabilize plugin auth marker fixtures, avoid brittle provider-ref error text, and keep QA Lab bootstrap selection assertions aligned with flow-only scenarios. ([#92652](openclaw/openclaw#92652)) - macOS Peekaboo bridge: update the embedded Peekaboo package to 3.5.2 and route bundled-skill CLI commands through the OpenClaw app bridge so they inherit its Screen Recording and Accessibility grants. - Agent routing: route subagent RPC callbacks addressed to an agent-shaped `--to` target to the correct session key instead of falling back to the main session, so WeChat (and other channel) session-key callbacks reach the intended subagent session. ([#90231](openclaw/openclaw#90231)) Thanks [@zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Cron: preserve model, fallback, thinking, timeout, light-context, unsafe-content, and tool allow-list overrides on implicit text payloads by promoting them to agent turns, while explicit system events still prune those fields. Fixes [#28905](openclaw/openclaw#28905); carries forward [#64060](openclaw/openclaw#64060) and [#73946](openclaw/openclaw#73946). Thanks [@liaoandi](https://github.com/liaoandi). - QQBot delivery: keep markdown table chunks self-contained across message boundaries by preserving table state across block deliveries, flushing unfinished table-row fragments as plain text, and detecting short pipe-terminated rows by column count so split rows are not sent as malformed markdown. ([#92428](openclaw/openclaw#92428)) Thanks [@sliverp](https://github.com/sliverp). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1144

openclaw-barnacle Bot added gateway Gateway runtime size: S labels Mar 26, 2026

greptile-apps Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread src/gateway/client.ts Outdated

chatgpt-codex-connector Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread src/gateway/client.ts Outdated

ruanrrn added 2 commits April 27, 2026 21:35

fix(gateway): ignore transient pre-hello normal closes

8bbc5b6

fix(gateway): cap pre-hello normal-close suppression

60bef44

ruanrrn force-pushed the bughunt/fix-gateway-prehello-close-race branch from 51f15f0 to 60bef44 Compare April 27, 2026 13:36

clawsweeper Bot mentioned this pull request Apr 28, 2026

fix(gateway): tolerate transient pre-hello closes in CLI calls #54475

Closed

25 tasks

openclaw-clownfish Bot closed this Apr 29, 2026

ruanrrn deleted the bughunt/fix-gateway-prehello-close-race branch April 30, 2026 00:38

vincentkoc mentioned this pull request Jun 16, 2026

fix(gateway): tolerate transient pre-hello clean closes #93528

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(gateway): ignore transient pre-hello close in one-shot calls#54774

fix(gateway): ignore transient pre-hello close in one-shot calls#54774
ruanrrn wants to merge 2 commits into
openclaw:mainfrom
ruanrrn:bughunt/fix-gateway-prehello-close-race

ruanrrn commented Mar 26, 2026

Uh oh!

greptile-apps Bot commented Mar 26, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

clawsweeper Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

openclaw-clownfish Bot commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

ruanrrn commented Mar 26, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Root Cause / Regression History (if applicable)

Regression Test Plan (if applicable)

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps Bot commented Mar 26, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

clawsweeper Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openclaw-clownfish Bot commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Apr 28, 2026 •

edited

Loading